Skip to content

Commit e477a8f

Browse files
feat(configurations): add dynamodb to the default list of DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES (#12688)
add dynamodb to the default list of DD_TRACE_CLOUD_PAYLOAD_TAGGING_SEVICES ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: erikayasuda <[email protected]>
1 parent 942c3ef commit e477a8f

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

ddtrace/contrib/internal/botocore/patch.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,9 @@ def _load_dynamodb_primary_key_names_for_tables() -> Dict[str, Set[str]]:
114114
), # RFC defined default limit - spans are limited past 1000
115115
"payload_tagging_services": set(
116116
service.strip()
117-
for service in os.getenv("DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES", "s3,sns,sqs,kinesis,eventbridge").split(
118-
","
119-
)
117+
for service in os.getenv(
118+
"DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES", "s3,sns,sqs,kinesis,eventbridge,dynamodb"
119+
).split(",")
120120
),
121121
},
122122
)
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
features:
3+
- |
4+
Includes `dynamodb` in the default list of cloud services for payload tagging, i.e. `DD_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES`
5+
Note that cloud services payload tagging feature is still gated by `DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING` and `DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING`.

0 commit comments

Comments
 (0)