feat(profiling): add memory allocator testing variants (#14659)

vlad-scherbich · web-flow · commit e9bc459014d3 · 2025-10-06T20:00:12.000Z
[PROF-12490: Running memory allocator tests with different allocators](https://datadoghq.atlassian.net/browse/PROF-12490) ## Description Some clients might be using non-default allocator types in their Python code. The goal of this PR is to ensure that existing memory-related tests are working for (a) all standard allocator types and (b) `jemalloc`, a powerful implementation optimized to avoid memory fragmentation, and providing scalable concurrency, particularly in multithreaded applications. Allocators tested * profile-v2-pymalloc (default) * profile-v2-malloc * profile-v2-malloc-debug * profile-v2-pymalloc-debug **note:** there are perm issues for Docker containers setup affecting testing of **`jemalloc`**. Adding a defensive try/catch strategy to determine if it's installed. I will try to figure out Docker perm issues to install the lib in a follow up PR. ## Testing 1) Ran all `test_memory_collector*` tests ``` $ ./scripts/ddtest riot -v run -s -p 3.10 profile-v2 -- -s -vv -k "test_memory_collector" tests/profiling_v2/collector/test_memalloc.py ... 9 passed with 0 warnings, 0 failed ``` 2) Spot-checked that new allocator types are being used: ``` -------------------summary------------------- ✓ profile-v2: [111cc29] _DD_CIVISIBILITY_USE_CI_CONTEXT_PROVIDER=1 DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false DD_INJECTION_ENABLED=1 DD_INJECT_FORCE=1 DD_PATCH_MODULES=unittest:false CMAKE_BUILD_PARALLEL_LEVEL=12 CARGO_BUILD_JOBS=12 DD_PROFILING_ENABLE_ASSERTS=1 CPUCOUNT=12 PYTHONMALLOC=pymalloc pythonInterpreter(_hint='3.10') 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'gunicorn' 'jsonschema' 'lz4' 'pytest-cpp' 'pytest-benchmark' 'py-cpuinfo~=8.0.0' 'pytest-asyncio==0.21.1' 'pytest-randomly' 'uwsgi<2.0.30' ✓ profile-v2-pymalloc: [5178213] _DD_CIVISIBILITY_USE_CI_CONTEXT_PROVIDER=1 DD_TESTING_RAISE=1 DD_REMOTE_CONFIGURATION_ENABLED=false DD_INJECTION_ENABLED=1 DD_INJECT_FORCE=1 DD_PATCH_MODULES=unittest:false CMAKE_BUILD_PARALLEL_LEVEL=12 CARGO_BUILD_JOBS=12 DD_PROFILING_ENABLE_ASSERTS=1 CPUCOUNT=12 PYTHONMALLOC=pymalloc pythonInterpreter(_hint='3.10') 'mock' 'pytest' 'pytest-mock' 'coverage' 'pytest-cov' 'opentracing' 'hypothesis<6.45.1' 'gunicorn' 'jsonschema' 'lz4' 'pytest-cpp' 'pytest-benchmark' 'py-cpuinfo~=8.0.0' 'pytest-asyncio==0.21.1' 'pytest-randomly' ``` 3) Hard-coded invalid allocator names, such as "foo", and observed test failures due to "invalid allocator type" ## Risks None ## Additional Notes
diff --git a/.riot/requirements/17a060e.txt b/.riot/requirements/17a060e.txt
@@ -0,0 +1,30 @@
+#
+# This file is autogenerated by pip-compile with Python 3.13
+# by the following command:
+#
+#    pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --no-annotate --pip-args=None .riot/requirements/17a060e.in
+#
+attrs==25.3.0
+coverage[toml]==7.10.7
+gunicorn==23.0.0
+hypothesis==6.45.0
+iniconfig==2.1.0
+jsonschema==4.25.1
+jsonschema-specifications==2025.9.1
+lz4==4.4.4
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pluggy==1.6.0
+py-cpuinfo==8.0.0
+pygments==2.19.2
+pytest==8.4.2
+pytest-asyncio==0.21.1
+pytest-benchmark==5.1.0
+pytest-cov==7.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.15.1
+pytest-randomly==4.0.1
+referencing==0.36.2
+rpds-py==0.27.1
+sortedcontainers==2.4.0
diff --git a/.riot/requirements/18fddc3.txt b/.riot/requirements/18fddc3.txt
@@ -0,0 +1,35 @@
+#
+# This file is autogenerated by pip-compile with Python 3.9
+# by the following command:
+#
+#    pip-compile --allow-unsafe --no-annotate .riot/requirements/18fddc3.in
+#
+attrs==25.3.0
+coverage[toml]==7.10.7
+exceptiongroup==1.3.0
+gunicorn==23.0.0
+hypothesis==6.45.0
+importlib-metadata==8.7.0
+iniconfig==2.1.0
+jsonschema==4.25.1
+jsonschema-specifications==2025.9.1
+lz4==4.4.4
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pluggy==1.6.0
+py-cpuinfo==8.0.0
+pygments==2.19.2
+pytest==8.4.2
+pytest-asyncio==0.21.1
+pytest-benchmark==5.1.0
+pytest-cov==7.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.15.1
+pytest-randomly==4.0.1
+referencing==0.36.2
+rpds-py==0.27.1
+sortedcontainers==2.4.0
+tomli==2.2.1
+typing-extensions==4.15.0
+zipp==3.23.0
diff --git a/.riot/requirements/1a1c5ae.txt b/.riot/requirements/1a1c5ae.txt
@@ -0,0 +1,36 @@
+#
+# This file is autogenerated by pip-compile with Python 3.8
+# by the following command:
+#
+#    pip-compile --allow-unsafe --no-annotate .riot/requirements/1a1c5ae.in
+#
+attrs==25.3.0
+coverage[toml]==7.6.1
+exceptiongroup==1.3.0
+gunicorn==23.0.0
+hypothesis==6.45.0
+importlib-metadata==8.5.0
+importlib-resources==6.4.5
+iniconfig==2.1.0
+jsonschema==4.23.0
+jsonschema-specifications==2023.12.1
+lz4==4.3.3
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pkgutil-resolve-name==1.3.10
+pluggy==1.5.0
+py-cpuinfo==8.0.0
+pytest==8.3.5
+pytest-asyncio==0.21.1
+pytest-benchmark==4.0.0
+pytest-cov==5.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.14.1
+pytest-randomly==3.15.0
+referencing==0.35.1
+rpds-py==0.20.1
+sortedcontainers==2.4.0
+tomli==2.2.1
+typing-extensions==4.13.2
+zipp==3.20.2
diff --git a/.riot/requirements/748e276.txt b/.riot/requirements/748e276.txt
@@ -0,0 +1,31 @@
+#
+# This file is autogenerated by pip-compile with Python 3.11
+# by the following command:
+#
+#    pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --no-annotate --pip-args=None .riot/requirements/748e276.in
+#
+attrs==25.3.0
+coverage[toml]==7.10.7
+gunicorn==23.0.0
+hypothesis==6.45.0
+iniconfig==2.1.0
+jsonschema==4.25.1
+jsonschema-specifications==2025.9.1
+lz4==4.4.4
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pluggy==1.6.0
+py-cpuinfo==8.0.0
+pygments==2.19.2
+pytest==8.4.2
+pytest-asyncio==0.21.1
+pytest-benchmark==5.1.0
+pytest-cov==7.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.15.1
+pytest-randomly==4.0.1
+referencing==0.36.2
+rpds-py==0.27.1
+sortedcontainers==2.4.0
+typing-extensions==4.15.0
diff --git a/.riot/requirements/dcbb0e8.txt b/.riot/requirements/dcbb0e8.txt
@@ -0,0 +1,31 @@
+#
+# This file is autogenerated by pip-compile with Python 3.12
+# by the following command:
+#
+#    pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --no-annotate --pip-args=None .riot/requirements/dcbb0e8.in
+#
+attrs==25.3.0
+coverage[toml]==7.10.7
+gunicorn==23.0.0
+hypothesis==6.45.0
+iniconfig==2.1.0
+jsonschema==4.25.1
+jsonschema-specifications==2025.9.1
+lz4==4.4.4
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pluggy==1.6.0
+py-cpuinfo==8.0.0
+pygments==2.19.2
+pytest==8.4.2
+pytest-asyncio==0.21.1
+pytest-benchmark==5.1.0
+pytest-cov==7.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.15.1
+pytest-randomly==4.0.1
+referencing==0.36.2
+rpds-py==0.27.1
+sortedcontainers==2.4.0
+typing-extensions==4.15.0
diff --git a/.riot/requirements/dd5c1a4.txt b/.riot/requirements/dd5c1a4.txt
@@ -0,0 +1,33 @@
+#
+# This file is autogenerated by pip-compile with Python 3.10
+# by the following command:
+#
+#    pip-compile --allow-unsafe --cert=None --client-cert=None --index-url=None --no-annotate --pip-args=None .riot/requirements/dd5c1a4.in
+#
+attrs==25.3.0
+coverage[toml]==7.10.7
+exceptiongroup==1.3.0
+gunicorn==23.0.0
+hypothesis==6.45.0
+iniconfig==2.1.0
+jsonschema==4.25.1
+jsonschema-specifications==2025.9.1
+lz4==4.4.4
+mock==5.2.0
+opentracing==2.4.0
+packaging==25.0
+pluggy==1.6.0
+py-cpuinfo==8.0.0
+pygments==2.19.2
+pytest==8.4.2
+pytest-asyncio==0.21.1
+pytest-benchmark==5.1.0
+pytest-cov==7.0.0
+pytest-cpp==2.6.0
+pytest-mock==3.15.1
+pytest-randomly==4.0.1
+referencing==0.36.2
+rpds-py==0.27.1
+sortedcontainers==2.4.0
+tomli==2.2.1
+typing-extensions==4.15.0
diff --git a/riotfile.py b/riotfile.py
@@ -3470,7 +3470,7 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
         Venv(
             name="profile-v2",
             # NB riot commands that use this Venv must include --pass-env to work properly
-            command="python -m tests.profiling.run pytest -v --no-cov --capture=no --benchmark-disable {cmdargs} tests/profiling_v2",  # noqa: E501
+            command="python -m tests.profiling.run pytest -v --no-cov --capture=no --benchmark-disable --ignore='tests/profiling_v2/collector/test_memalloc.py' {cmdargs} tests/profiling_v2",  # noqa: E501
             env={
                 "DD_PROFILING_ENABLE_ASSERTS": "1",
                 "CPUCOUNT": "12",
@@ -3567,6 +3567,25 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
                         ),
                     ],
                 ),
+                Venv(
+                    name="profile-v2-memalloc",
+                    command="python -m tests.profiling.run pytest -v --no-cov --capture=no --benchmark-disable {cmdargs} tests/profiling_v2/collector/test_memalloc.py",  # noqa: E501
+                    # skipping v3.14 for now due to an unstable `lz4 ` lib issue: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/1163312347
+                    pys=select_pys(max_version="3.13"),
+                    venvs=[
+                        # standard allocators
+                        Venv(
+                            env={
+                                "PYTHONMALLOC": [
+                                    "malloc",
+                                    "pymalloc",
+                                    "malloc_debug",
+                                    "pymalloc_debug",
+                                ],
+                            },
+                        ),
+                    ],
+                ),
             ],
         ),
         Venv(
diff --git a/tests/profiling/suitespec.yml b/tests/profiling/suitespec.yml
@@ -104,6 +104,6 @@ suites:
       - '@profiling'
       - tests/profiling/suitespec.yml
       - tests/profiling_v2/*
-    pattern: profile-v2$
+    pattern: profile-v2
     retry: 2
     runner: riot
