Skip to content

Commit ea25c02

Browse files
github-actions[bot]brettlangdonavara1986
authored
ci: don't fail with perf regressions on releases [backport 3.2] (#13137)
Backport 698db4a from #13135 to 3.2. This is a stop gap to unblock releases which introduce known performance regressions. In the future we need to continue to block releases that introduce a performance regression. This PR is meant as a quick fix since we don't have any other ways to signal to the release process that we accept the regression. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Brett Langdon <[email protected]> Co-authored-by: Alberto Vara <[email protected]>
1 parent c348dab commit ea25c02

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

.gitlab/benchmarks/microbenchmarks.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,11 @@ benchmarks-pr-comment:
8383

8484
check-big-regressions:
8585
stage: report
86+
rules:
87+
# Run and warn on release branches, but don't fail the pipeline
88+
- if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+$/
89+
allow_failure: true
90+
- allow_failure: false
8691
when: always
8792
tags: ["arch:amd64"]
8893
image: $MICROBENCHMARKS_CI_IMAGE

0 commit comments

Comments
 (0)