Skip to content

Commit efe936c

Browse files
authored
fix(ci): use container to run Python 2.7 in pylons framework test [backport #6167 to 1.13] (#6174)
Related to actions/setup-python#672. Setup-python removed Python 2.7 from their list of python-versions as of June 19, 2023, meaning our framework tests for Pylons (which is based on Python 2) now fail. The recommended solution was to instead use a Python 2.7 container within the ubuntu-20.04 image, which this PR does. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed. If no release note is required, add label `changelog/no-changelog`. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Backport labels are set (if [applicable](../docs/contributing.rst#release-branch-maintenance)) ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment. - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](../docs/contributing.rst#release-branch-maintenance)
1 parent 13732e8 commit efe936c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/test_frameworks.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -417,16 +417,15 @@ jobs:
417417
name: Pylons 1.0.3
418418
runs-on: "ubuntu-20.04"
419419
# Ubuntu 20.04 is the last version of ubuntu on github setup actions to provide Python 2.7.
420+
container:
421+
image: python:2.7.18-buster
420422
env:
421423
DD_TESTING_RAISE: true
422424
PYTHONPATH: ../ddtrace/tests/debugging/exploration/
423425
defaults:
424426
run:
425427
working-directory: pylons
426428
steps:
427-
- uses: actions/setup-python@v4
428-
with:
429-
python-version: '2.7'
430429
- uses: actions/checkout@v3
431430
with:
432431
path: ddtrace

0 commit comments

Comments
 (0)