Skip to content

Commit f8ff030

Browse files
authored
Merge pull request #1218 from DataDog/majorgreys/fix-tox-docs
fix(tox): do not skip install for docs
2 parents 50b3170 + e5af3b8 commit f8ff030

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

ddtrace/contrib/django/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
The Django integration provides automatic migration from enabling tracing using
9494
a middleware to the method consistent with our integrations. Application
9595
developers are encouraged to convert their configuration of the tracer to the
96-
later.
96+
latter.
9797
9898
1. Remove ``'ddtrace.config.django'`` from ``INSTALLED_APPS`` in
9999
``settings.py``.

docs/installation_quickstart.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ variable before starting your application and importing the library:
4242

4343
.. list-table::
4444
:header-rows: 1
45-
:widths: 1 1 2
45+
:widths: 1 1 1 2
4646

4747
* - Configuration Variable
4848
- Configuration Type
@@ -64,7 +64,7 @@ that you can use the Datadog tracer in your OpenTracing-compatible
6464
applications.
6565

6666
Installation
67-
^^^^^^^^^^^^
67+
~~~~~~~~~~~~
6868

6969
Include OpenTracing with ``ddtrace``::
7070

@@ -78,7 +78,7 @@ you have the following in ``setup.py``::
7878
],
7979

8080
Configuration
81-
^^^^^^^^^^^^^
81+
~~~~~~~~~~~~~
8282

8383
The OpenTracing convention for initializing a tracer is to define an
8484
initialization method that will configure and instantiate a new tracer and

tox.ini

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -510,10 +510,12 @@ basepython=python3.7
510510

511511
[testenv:docs]
512512
commands_pre=
513-
skip_install=true
514-
deps = sphinx
515-
commands = sphinx-build -b html docs docs/_build/html
516-
basepython = python
513+
extras=
514+
opentracing
515+
deps=
516+
sphinx
517+
commands=sphinx-build -W -b html docs docs/_build/html
518+
basepython=python
517519

518520
# do not use develop mode with celery as running multiple python versions within
519521
# same job will cause problem for tests that use ddtrace-run

0 commit comments

Comments
 (0)