Skip to content

Commit faed10b

Browse files
committed
tracer: clean up writer args
1 parent a5680d0 commit faed10b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ddtrace/tracer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ def write(self, spans):
160160

161161
if self.enabled and self.writer:
162162
# only submit the spans if we're actually enabled (and don't crash :)
163-
self.writer.write(spans)
163+
self.writer.write(spans=spans)
164164

165165
def set_service_info(self, service, app, app_type):
166166
"""Set the information about the given service.
@@ -181,8 +181,8 @@ def set_service_info(self, service, app, app_type):
181181
log.debug("set_service_info: service:%s app:%s type:%s",
182182
service, app, app_type)
183183

184-
if self.writer:
185-
self.writer.write(spans=None, services=services)
184+
if self.enabled and self.writer:
185+
self.writer.write(services=services)
186186

187187
def wrap(self, name=None, service=None, resource=None, span_type=None):
188188
"""A decorator used to trace an entire function.

ddtrace/writer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def __init__(self, hostname='localhost', port=7777):
2828
self._worker = None
2929
self._api = api.API(hostname, port)
3030

31-
def write(self, spans, services=None):
31+
def write(self, spans=None, services=None):
3232
# if the worker needs to be reset, do it.
3333
self._reset_worker()
3434

0 commit comments

Comments
 (0)