Skip to content

Commit 183d368

Browse files
committed
fix rebase collateral
1 parent 784f099 commit 183d368

File tree

4 files changed

+27
-20
lines changed

4 files changed

+27
-20
lines changed

src/main/java/com/timgroup/statsd/StatsDBlockingProcessor.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ public class StatsDBlockingProcessor extends StatsDProcessor {
1616

1717
private class ProcessingTask extends StatsDProcessor.ProcessingTask {
1818

19+
public ProcessingTask(int id) {
20+
super(id);
21+
}
22+
1923
@Override
2024
public void run() {
2125
ByteBuffer sendBuffer;
@@ -76,7 +80,7 @@ public void run() {
7680
writeBuilderToSendBuffer(sendBuffer);
7781
}
7882

79-
if (null == messages.peek()) {
83+
if (null == processorWorkQueue[this.processorQueueId].peek()) {
8084
outboundQueue.put(sendBuffer);
8185
sendBuffer = bufferPool.borrow();
8286
}
@@ -96,7 +100,6 @@ public void run() {
96100
aggregator.stop();
97101
endSignal.countDown();
98102
}
99-
100103
}
101104

102105
StatsDBlockingProcessor(final int queueSize, final StatsDClientErrorHandler handler,
@@ -115,8 +118,8 @@ public void run() {
115118
}
116119

117120
@Override
118-
protected ProcessingTask createProcessingTask() {
119-
return new ProcessingTask();
121+
protected ProcessingTask createProcessingTask(int id) {
122+
return new ProcessingTask(id);
120123
}
121124

122125
StatsDBlockingProcessor(final StatsDBlockingProcessor processor)

src/main/java/com/timgroup/statsd/StatsDNonBlockingProcessor.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ private class ProcessingTask extends StatsDProcessor.ProcessingTask {
2020
private final int processorQueueId;
2121

2222
public ProcessingTask(int id) {
23-
super();
24-
this.processorQueueId = id;
23+
super(id);
2524
}
2625

2726
@Override
@@ -144,8 +143,8 @@ public void run() {
144143
}
145144

146145
@Override
147-
protected ProcessingTask createProcessingTask() {
148-
return new ProcessingTask();
146+
protected ProcessingTask createProcessingTask(int id) {
147+
return new ProcessingTask(id);
149148
}
150149

151150
StatsDNonBlockingProcessor(final StatsDNonBlockingProcessor processor) throws Exception {

src/main/java/com/timgroup/statsd/StatsDProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public Thread newThread(final Runnable runnable) {
137137
processor.getAggregator().getFlushInterval());
138138
}
139139

140-
protected abstract ProcessingTask createProcessingTask();
140+
protected abstract ProcessingTask createProcessingTask(int id);
141141

142142
protected abstract boolean send(final Message message);
143143

@@ -172,7 +172,7 @@ public static int getThreadId() {
172172
public void run() {
173173

174174
for (int i = 0 ; i < workers ; i++) {
175-
executor.submit(createProcessingTask());
175+
executor.submit(createProcessingTask(i));
176176
}
177177

178178
boolean done = false;

src/test/java/com/timgroup/statsd/TelemetryTest.java

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,16 @@ public static class FakeProcessor extends StatsDProcessor {
3131
public final List<Message> messages = new ArrayList<>();
3232

3333
FakeProcessor(final StatsDClientErrorHandler handler) throws Exception {
34-
super(0, handler, 0, 1, 1, 0, 0);
34+
super(0, handler, 0, 1, 1, 1, 0, 0);
3535
}
3636

3737

3838
private class FakeProcessingTask extends StatsDProcessor.ProcessingTask {
39+
40+
public FakeProcessingTask(int id) {
41+
super(id);
42+
}
43+
3944
@Override
4045
public void run() {}
4146
}
@@ -50,8 +55,8 @@ public boolean send(final Message msg) {
5055
public void run(){}
5156

5257
@Override
53-
protected ProcessingTask createProcessingTask() {
54-
return new FakeProcessingTask();
58+
protected ProcessingTask createProcessingTask(int id) {
59+
return new FakeProcessingTask(id);
5560
}
5661

5762
public List<Message> getMessages() {
@@ -82,12 +87,12 @@ public StatsDNonBlockingTelemetry(final String prefix, final int queueSize, Stri
8287
final StatsDClientErrorHandler errorHandler, Callable<SocketAddress> addressLookup,
8388
final int timeout, final int bufferSize, final int maxPacketSizeBytes,
8489
String entityID, final int poolSize, final int processorWorkers,
85-
final int senderWorkers, boolean blocking, final boolean enableTelemetry,
86-
final int telemetryFlushInterval)
90+
final int senderWorkers, final int lockShardGrain, boolean blocking,
91+
final boolean enableTelemetry, final int telemetryFlushInterval)
8792
throws StatsDClientException {
8893
super(prefix, queueSize, constantTags, errorHandler, addressLookup, addressLookup, timeout,
8994
bufferSize, maxPacketSizeBytes, entityID, poolSize, processorWorkers, senderWorkers,
90-
blocking, enableTelemetry, telemetryFlushInterval, 0, 0);
95+
lockShardGrain, blocking, enableTelemetry, telemetryFlushInterval, 0, 0);
9196
}
9297
};
9398

@@ -98,13 +103,13 @@ public StatsDNonBlockingTelemetry build() throws StatsDClientException {
98103
if (addressLookup != null) {
99104
return new StatsDNonBlockingTelemetry(prefix, queueSize, constantTags, errorHandler,
100105
addressLookup, timeout, socketBufferSize, maxPacketSizeBytes, entityID,
101-
bufferPoolSize, processorWorkers, senderWorkers, blocking, enableTelemetry,
102-
telemetryFlushInterval);
106+
bufferPoolSize, processorWorkers, senderWorkers, lockShardGrain, blocking,
107+
enableTelemetry, telemetryFlushInterval);
103108
} else {
104109
return new StatsDNonBlockingTelemetry(prefix, queueSize, constantTags, errorHandler,
105110
staticStatsDAddressResolution(hostname, port), timeout, socketBufferSize, maxPacketSizeBytes,
106-
entityID, bufferPoolSize, processorWorkers, senderWorkers, blocking, enableTelemetry,
107-
telemetryFlushInterval);
111+
entityID, bufferPoolSize, processorWorkers, senderWorkers, lockShardGrain, blocking,
112+
enableTelemetry, telemetryFlushInterval);
108113
}
109114
}
110115
}

0 commit comments

Comments
 (0)