external-snapshotter constantly retrying CreateSnapshot calls on error w/o backoff

sameshai · sameshai · commit ffaba0f81dce · 2023-06-28T18:32:07.000+05:30
diff --git a/pkg/sidecar-controller/snapshot_controller_base.go b/pkg/sidecar-controller/snapshot_controller_base.go
@@ -123,7 +123,7 @@ func NewCSISnapshotSideCarController(
 				// So we are skipping the re-queue here to avoid CreateSnapshot being called without exponential backoff.
 				newSnapContent := newObj.(*crdv1.VolumeSnapshotContent)
 				if newSnapContent.Status != nil && newSnapContent.Status.Error != nil {
-						return
+					return
 				}
 				ctrl.enqueueContentWork(newObj)
 			},

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ func NewCSISnapshotSideCarController(`
`123`	`123`	`// So we are skipping the re-queue here to avoid CreateSnapshot being called without exponential backoff.`
`124`	`124`	`newSnapContent := newObj.(*crdv1.VolumeSnapshotContent)`
`125`	`125`	`if newSnapContent.Status != nil && newSnapContent.Status.Error != nil {`
`126`		`- return`
	`126`	`+ return`
`127`	`127`	`}`
`128`	`128`	`ctrl.enqueueContentWork(newObj)`
`129`	`129`	`},`