Add SMP CLI to preflight checks

Author: preinlein

.claude/skills/lading-preflight/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: lading-preflight
-description: Environment validation checklist. Run this FIRST when starting a new Claude session to verify the environment is ready for optimization work. Checks Rust toolchain, ci/ scripts, build, benchmarking tools, profilers, memory tools, and git state.
+description: Environment validation checklist. Run this FIRST when starting a new Claude session to verify the environment is ready for optimization work. Checks Rust toolchain, ci/ scripts, build, benchmarking tools, profilers, memory tools, git state, and SMP CLI.
 allowed-tools: Bash
 context: fork
 ---
@@ -11,9 +11,11 @@ context: fork
 .claude/skills/lading-preflight/scripts/preflight
 ```
 
-**STOP on any failure.** Use the table below to resolve `[X]` items:
+**STOP on any failure.** Use the table below to suggest fixes for `[X]` items.
 
-# Offer suggestions
+# Offer suggestions then ask before proceeding
+
+For each failed check, show the user the suggested fix from the table below and **ask if they want you to run it**. Do NOT automatically execute fixes — wait for user confirmation before taking action.
 
 | Failed Check                             | Fix                                                               |
 | ---------------------------------------- | ----------------------------------------------------------------- |
@@ -29,3 +31,6 @@ context: fork
 | payloadtool --memory-stats not supported | Rebuild payloadtool from current branch                           |
 | git user.name not set                    | `git config user.name "Your Name"`                                |
 | git user.email not set                   | `git config user.email "you@example.com"`                         |
+| gh not found                             | `brew install gh`                                                 |
+| aws CLI not found                        | `brew install awscli`                                             |
+| smp not found                            | `.claude/skills/lading-preflight/scripts/install_smp`             |

.claude/skills/lading-preflight/scripts/install_smp

@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+# Install the SMP CLI binary from S3.
+# Resolves the latest stable version via gh, detects the platform,
+# and downloads the binary to ~/.cargo/bin.
+
+SMP_INSTALL_DIR="${HOME}/.cargo/bin"
+
+if command -v smp >/dev/null 2>&1; then
+  echo "smp is already installed: $(smp --version 2>/dev/null)"
+  exit 0
+fi
+
+# Resolve latest stable version via gh
+if ! command -v gh >/dev/null 2>&1; then
+  echo "ERROR: gh CLI not found (needed to resolve version). Install with: brew install gh"
+  exit 1
+fi
+
+SMP_CLI_VERSION=$(gh release list --repo DataDog/single-machine-performance --limit 1 --exclude-pre-releases 2>/dev/null | awk '{print $1}')
+if [ -z "$SMP_CLI_VERSION" ]; then
+  echo "ERROR: could not resolve latest SMP version from GitHub"
+  exit 1
+fi
+
+echo "Resolved SMP CLI version: ${SMP_CLI_VERSION}"
+
+# Determine target triple
+OS="$(uname -s)"
+ARCH="$(uname -m)"
+case "${OS}-${ARCH}" in
+  Darwin-arm64)  TARGET="aarch64-apple-darwin" ;;
+  Darwin-x86_64) TARGET="x86_64-apple-darwin" ;;
+  Linux-aarch64) TARGET="aarch64-unknown-linux-musl" ;;
+  Linux-x86_64)  TARGET="x86_64-unknown-linux-musl" ;;
+  *)
+    echo "ERROR: unsupported platform ${OS}-${ARCH}"
+    exit 1
+    ;;
+esac
+
+# Download from S3
+if ! command -v aws >/dev/null 2>&1; then
+  echo "ERROR: aws CLI not found (needed to download from S3). Install with: brew install awscli"
+  exit 1
+fi
+
+mkdir -p "$SMP_INSTALL_DIR"
+S3_PATH="s3://smp-cli-releases/${SMP_CLI_VERSION}/${TARGET}/smp"
+echo "Downloading ${S3_PATH} -> ${SMP_INSTALL_DIR}/smp"
+
+if ! aws s3 cp "$S3_PATH" "${SMP_INSTALL_DIR}/smp"; then
+  echo "ERROR: download from S3 failed (check AWS credentials: aws sts get-caller-identity)"
+  exit 1
+fi
+
+chmod +x "${SMP_INSTALL_DIR}/smp"
+
+# smp --version emits ANSI escape codes and INFO log lines; extract just the version tag
+if SMP_RAW=$("${SMP_INSTALL_DIR}/smp" --version 2>/dev/null); then
+  SMP_VER=$(echo "$SMP_RAW" | sed 's/\x1b\[[0-9;]*m//g' | grep -oE 'v[0-9]+\.[0-9]+\.[0-9]+' | head -1)
+  echo "Installed smp ${SMP_VER:-unknown} to ${SMP_INSTALL_DIR}"
+else
+  echo "ERROR: downloaded binary failed version check"
+  exit 1
+fi

.claude/skills/lading-preflight/scripts/preflight

@@ -87,12 +87,14 @@ done
 # ── Check 3: Build ───────────────────────────────────────────────────
 section "Check 3 - Build"
 
+printf "  ... running ci/check (may take a moment)\r" >&2
 if ci/check >/dev/null 2>&1; then
   pass "ci/check passes"
 else
   fail "ci/check failed"
 fi
 
+printf "  ... building payloadtool (may take a moment)\r" >&2
 if cargo build --release --bin payloadtool >/dev/null 2>&1; then
   pass "payloadtool built"
 else
@@ -188,6 +190,35 @@ else
   pass "Working tree clean"
 fi
 
+# ── Check 8: GitHub CLI ─────────────────────────────────────────────
+section "Check 8 - GitHub CLI"
+
+if GH_VER=$(gh --version 2>/dev/null | head -1 | awk '{print $3}'); then
+  pass "gh $GH_VER"
+else
+  note "gh not found"
+fi
+
+# ── Check 9: AWS CLI ───────────────────────────────────────────────
+section "Check 9 - AWS CLI"
+
+if AWS_VER=$(aws --version 2>/dev/null | awk '{print $1}'); then
+  pass "$AWS_VER"
+else
+  note "aws CLI not found"
+fi
+
+# ── Check 10: SMP CLI ───────────────────────────────────────────────
+section "Check 10 - SMP CLI"
+
+if command -v smp >/dev/null 2>&1; then
+  # smp --version emits ANSI escape codes and INFO log lines; extract just the version tag
+  SMP_VER=$(smp --version 2>/dev/null | sed 's/\x1b\[[0-9;]*m//g' | grep -oE 'v[0-9]+\.[0-9]+\.[0-9]+' | head -1)
+  pass "smp ${SMP_VER:-unknown}"
+else
+  note "smp not found"
+fi
+
 # ── Report ────────────────────────────────────────────────────────────
 echo "LADING PREFLIGHT REPORT"
 echo "======================="