wip

Author: ekump

.github/actions/clippy-annotation-reporter/Cargo.toml

@@ -5,7 +5,7 @@ edition = "2021"
 version = "0.1.0"
 
 [dependencies]
-clap = { version = "4.3", features = ["derive"] }
+clap = { version = "4.3", features = ["derive", "env"] }
 octocrab = "0.28"
 anyhow = "1.0"
 regex = "1.9"

.github/actions/clippy-annotation-reporter/src/main.rs

@@ -1,58 +1,150 @@
-use anyhow::{Context, Result};
+use anyhow::{Context as _, Result};
 use octocrab::Octocrab;
+use serde_json::Value;
 use std::env;
+use std::fs;
+use clap::Parser;
+
+#[derive(Parser, Debug)]
+#[command(name = "clippy-annotation-reporter")]
+#[command(about = "Reports changes in clippy annotations for panic rules")]
+struct Args {
+    /// GitHub token for API access
+    #[arg(long, env = "GITHUB_TOKEN")]
+    token: String,
+
+    /// Comma-separated list of panic-related Clippy rules to track
+    #[arg(long, default_value = "unwrap_used,expect_used,todo,unimplemented,panic,unreachable")]
+    rules: String,
+
+    /// GitHub repository (owner/repo) - defaults to current repository
+    #[arg(long)]
+    repo: Option<String>,
+
+    /// Pull request number - defaults to PR from event context
+    #[arg(long)]
+    pr: Option<u64>,
+}
+
+/// GitHub event context extracted from environment
+struct GitHubContext {
+    repository: String,
+    pr_number: u64,
+    event_name: String,
+}
+
+impl GitHubContext {
+    /// Try to extract GitHub context from environment variables and event file
+    fn from_env() -> Result<Self> {
+        // Get repository from env or args
+        let repository = env::var("GITHUB_REPOSITORY")
+            .context("GITHUB_REPOSITORY environment variable not set")?;
+
+        // Get event name (pull_request, push, etc.)
+        let event_name = env::var("GITHUB_EVENT_NAME")
+            .context("GITHUB_EVENT_NAME environment variable not set")?;
+
+        // For PR events, get PR number from event payload
+        let event_path = env::var("GITHUB_EVENT_PATH")
+            .context("GITHUB_EVENT_PATH environment variable not set")?;
+
+        println!("Event name: {}", event_name);
+        println!("Event path: {}", event_path);
+
+        let event_data = fs::read_to_string(event_path)
+            .context("Failed to read GitHub event file")?;
+
+        let event_json: Value = serde_json::from_str(&event_data)
+            .context("Failed to parse GitHub event JSON")?;
+
+        // Print the event JSON for debugging
+        println!("Event JSON structure (top level): {:?}",
+                 event_json.as_object().map(|o| o.keys().collect::<Vec<_>>()));
+
+        // Extract PR number using different strategies based on event type
+        let pr_number = match event_name.as_str() {
+            "pull_request" | "pull_request_target" => {
+                event_json["pull_request"]["number"].as_u64()
+                    .context("Could not find pull_request.number in event data")?
+            },
+            "issue_comment" => {
+                event_json["issue"]["number"].as_u64()
+                    .context("Could not find issue.number in event data")?
+            },
+            _ => {
+                // For other events, PR number must be provided as an argument
+                0 // Will be overridden by required argument check below
+            }
+        };
+
+        Ok(GitHubContext {
+            repository,
+            pr_number,
+            event_name,
+        })
+    }
+}
 
 #[tokio::main]
 async fn main() -> Result<()> {
-    println!("Hello World from clippy-annotation-checker!");
-    println!("Action is running successfully!");
+    // Initialize logger
+    env_logger::init();
 
-    // Get required environment variables
-    let github_token = env::var("GITHUB_TOKEN")
-        .context("GITHUB_TOKEN environment variable not set")?;
+    // Parse command line arguments
+    let args = Args::parse();
 
-    let github_repository = env::var("GITHUB_REPOSITORY")
-        .context("GITHUB_REPOSITORY environment variable not set")?;
+    println!("Clippy Annotation Reporter starting...");
 
-    let event_path = env::var("GITHUB_EVENT_PATH")
-        .context("GITHUB_EVENT_PATH environment variable not set")?;
+    // Try to get GitHub context from environment
+    let github_ctx = GitHubContext::from_env()?;
 
-    // Parse event data to get PR number
-    let event_data = std::fs::read_to_string(event_path)
-        .context("Failed to read event file")?;
+    // Use provided values from args if available, otherwise use context
+    let repository = args.repo.unwrap_or(github_ctx.repository);
+    let pr_number = match args.pr {
+        Some(pr) => pr,
+        None => {
+            if github_ctx.pr_number == 0 {
+                anyhow::bail!("No PR number found in event context. Please provide --pr argument.");
+            }
+            github_ctx.pr_number
+        }
+    };
 
-    let event_json: serde_json::Value = serde_json::from_str(&event_data)
-        .context("Failed to parse event JSON")?;
+    println!("Repository: {}", repository);
+    println!("PR Number: {}", pr_number);
+    println!("Event Type: {}", github_ctx.event_name);
+    println!("Checking for rules: {}", args.rules);
 
-    let pr_number = event_json["pull_request"]["number"]
-        .as_u64()
-        .context("Could not find PR number in event data")?;
+    // Initialize GitHub API client with token
+    let octocrab = Octocrab::builder()
+        .personal_token(args.token)
+        .build()
+        .context("Failed to build GitHub API client")?;
 
     // Split repository into owner and name
-    let repo_parts: Vec<&str> = github_repository.split('/').collect();
+    let repo_parts: Vec<&str> = repository.split('/').collect();
     if repo_parts.len() != 2 {
-        anyhow::bail!("Invalid repository format: {}", github_repository);
+        anyhow::bail!("Invalid repository format. Expected 'owner/repo', got '{}'", repository);
     }
-
     let owner = repo_parts[0];
     let repo = repo_parts[1];
 
-    println!("Posting Hello World comment to PR #{} in {}/{}", pr_number, owner, repo);
+    // This is just a "Hello World" example that posts a comment to verify everything works
+    println!("Posting a test comment to PR #{} in {}/{}", pr_number, owner, repo);
 
-    // Initialize GitHub client
-    let octocrab = Octocrab::builder()
-        .personal_token(github_token)
-        .build()
-        .context("Failed to build GitHub client")?;
-
-    // Post a simple comment
     octocrab
         .issues(owner, repo)
-        .create_comment(pr_number, "## Hello World from clippy-annotation-checker!\n\nThis action is running successfully and can post comments to PRs.")
+        .create_comment(
+            pr_number,
+            format!("## Clippy Annotation Reporter Test\n\nSuccessfully connected to PR #{} in {}/{}.\n\nWill scan for the following rules: `{}`",
+                    pr_number, owner, repo, args.rules)
+        )
         .await
-        .context("Failed to post comment")?;
+        .context("Failed to post comment to PR")?;
 
     println!("Comment posted successfully!");
 
+    // TODO: Add actual clippy annotation checking logic here
+
     Ok(())
-}
+}