clippy happy

Author: danielsn

datadog-profiling-otel/build.rs

@@ -35,6 +35,7 @@ fn main() {
 // SPDX-License-Identifier: Apache-2.0
 
 // This module is generated by prost-build from profiles.proto
+#[allow(clippy::all)]
 pub mod opentelemetry {
     pub mod proto {
         pub mod common {

datadog-profiling-otel/examples/basic_usage.rs

@@ -23,16 +23,20 @@ fn main() {
     };
 
     // Create a profile
-    let mut profile = Profile::default();
-    profile.sample_type = Some(sample_type);
-    profile.time_nanos = std::time::SystemTime::now()
-        .duration_since(std::time::UNIX_EPOCH)
-        .unwrap()
-        .as_nanos() as i64;
+    let profile = Profile {
+        sample_type: Some(sample_type),
+        time_nanos: std::time::SystemTime::now()
+            .duration_since(std::time::UNIX_EPOCH)
+            .unwrap()
+            .as_nanos() as i64,
+        ..Default::default()
+    };
 
     // Create profiles data
-    let mut profiles_data = ProfilesData::default();
-    profiles_data.dictionary = Some(profiles_dict);
+    let mut profiles_data = ProfilesData {
+        dictionary: Some(profiles_dict),
+        ..Default::default()
+    };
 
     let mut scope_profiles = ScopeProfiles::default();
     scope_profiles.profiles.push(profile);

datadog-profiling-otel/src/lib.rs

@@ -22,8 +22,10 @@ mod tests {
         let mut profiles_dict = ProfilesDictionary::default();
         profiles_dict.string_table.push("test".to_string());
 
-        let mut profiles_data = ProfilesData::default();
-        profiles_data.dictionary = Some(profiles_dict);
+        let profiles_data = ProfilesData {
+            dictionary: Some(profiles_dict),
+            ..Default::default()
+        };
 
         // Verify the data was set correctly
         assert_eq!(profiles_data.dictionary.as_ref().unwrap().string_table[0], "test");

datadog-profiling/src/internal/profile/otel_emitter/location.rs

@@ -47,7 +47,7 @@ mod tests {
         assert_eq!(otel_location.line[0].function_index, 3);
         assert_eq!(otel_location.line[0].line, 42);
         assert_eq!(otel_location.line[0].column, 0);
-        assert_eq!(otel_location.is_folded, false);
+        assert!(!otel_location.is_folded);
         assert_eq!(otel_location.attribute_indices, vec![] as Vec<i32>);
     }
 

datadog-profiling/src/internal/profile/otel_emitter/mapping.rs

@@ -45,10 +45,10 @@ mod tests {
         assert_eq!(otel_mapping.file_offset, 0x100);
         assert_eq!(otel_mapping.filename_strindex, 42);
         assert_eq!(otel_mapping.attribute_indices, vec![] as Vec<i32>);
-        assert_eq!(otel_mapping.has_functions, true);
-        assert_eq!(otel_mapping.has_filenames, true);
-        assert_eq!(otel_mapping.has_line_numbers, true);
-        assert_eq!(otel_mapping.has_inline_frames, false);
+        assert!(otel_mapping.has_functions);
+        assert!(otel_mapping.has_filenames);
+        assert!(otel_mapping.has_line_numbers);
+        assert!(!otel_mapping.has_inline_frames);
     }
 
     #[test]

datadog-trace-protobuf/src/remoteconfig.rs

@@ -3,15 +3,17 @@
 
 use serde::{Deserialize, Serialize};
 // This file is @generated by prost-build.
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct File {
     #[prost(string, tag = "1")]
     pub path: ::prost::alloc::string::String,
     #[prost(bytes = "vec", tag = "2")]
     #[serde(with = "serde_bytes")]
     pub raw: ::prost::alloc::vec::Vec<u8>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct Client {
     #[prost(message, optional, tag = "1")]
     pub state: ::core::option::Option<ClientState>,
@@ -33,7 +35,8 @@ pub struct Client {
     #[prost(bytes = "vec", tag = "11")]
     pub capabilities: ::prost::alloc::vec::Vec<u8>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ClientTracer {
     #[prost(string, tag = "1")]
     pub runtime_id: ::prost::alloc::string::String,
@@ -52,7 +55,8 @@ pub struct ClientTracer {
     #[prost(string, repeated, tag = "7")]
     pub tags: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ClientAgent {
     #[prost(string, tag = "1")]
     pub name: ::prost::alloc::string::String,
@@ -65,7 +69,8 @@ pub struct ClientAgent {
     #[prost(string, repeated, tag = "5")]
     pub cws_workloads: ::prost::alloc::vec::Vec<::prost::alloc::string::String>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ConfigState {
     #[prost(string, tag = "1")]
     pub id: ::prost::alloc::string::String,
@@ -78,7 +83,8 @@ pub struct ConfigState {
     #[prost(string, tag = "5")]
     pub apply_error: ::prost::alloc::string::String,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ClientState {
     #[prost(uint64, tag = "1")]
     pub root_version: u64,
@@ -93,14 +99,16 @@ pub struct ClientState {
     #[prost(bytes = "vec", tag = "6")]
     pub backend_client_state: ::prost::alloc::vec::Vec<u8>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct TargetFileHash {
     #[prost(string, tag = "1")]
     pub algorithm: ::prost::alloc::string::String,
     #[prost(string, tag = "3")]
     pub hash: ::prost::alloc::string::String,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct TargetFileMeta {
     #[prost(string, tag = "1")]
     pub path: ::prost::alloc::string::String,
@@ -109,14 +117,16 @@ pub struct TargetFileMeta {
     #[prost(message, repeated, tag = "3")]
     pub hashes: ::prost::alloc::vec::Vec<TargetFileHash>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ClientGetConfigsRequest {
     #[prost(message, optional, tag = "1")]
     pub client: ::core::option::Option<Client>,
     #[prost(message, repeated, tag = "2")]
     pub cached_target_files: ::prost::alloc::vec::Vec<TargetFileMeta>,
 }
-#[derive(Deserialize, Serialize, Clone, PartialEq, ::prost::Message)]
+#[derive(Deserialize, Serialize)]
+#[derive(Clone, PartialEq, ::prost::Message)]
 pub struct ClientGetConfigsResponse {
     #[prost(bytes = "vec", repeated, tag = "1")]
     #[serde(with = "crate::serde")]