fix(bin_tests): race conditions between concurrent tests (#1402)

fix(bin_tests): race conditions between concurrent tests

test: skip serial_tests in miri as they leak

Co-authored-by: gyuheon.oh <[email protected]>

Author: morrisonlevi

Cargo.lock

@@ -27494,9 +27494,9 @@ third_party_libraries:
 - package_name: stringmetrics
   package_version: 2.2.2
   repository: https://github.com/pluots/stringmetrics
-  license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-1949cf8c6b5b557f/stringmetrics-2.2.2/LICENSE)
+  license: License specified in file ($CARGO_HOME/registry/src/github.com-25cdd57fae9f0462/stringmetrics-2.2.2/LICENSE)
   licenses:
-  - license: License specified in file ($CARGO_HOME/registry/src/index.crates.io-1949cf8c6b5b557f/stringmetrics-2.2.2/LICENSE)
+  - license: License specified in file ($CARGO_HOME/registry/src/github.com-25cdd57fae9f0462/stringmetrics-2.2.2/LICENSE)
     text: |
       Copyright 2022 Trevor Gross
 

LICENSE-3rdparty.yml

@@ -24,6 +24,9 @@ nix = { version = "0.29", features = ["signal", "socket"] }
 hex = "0.4"
 os_info = "3.7.0"
 
+[dev-dependencies]
+serial_test = "3.2"
+
 [lib]
 bench = false
 

bin_tests/Cargo.toml

@@ -85,8 +85,11 @@ unsafe extern "C" fn test_runtime_callback_frame(
 mod tests {
     use super::*;
     use libdd_crashtracker::{clear_runtime_callback, is_runtime_callback_registered};
+    use serial_test::serial;
 
     #[test]
+    #[cfg_attr(miri, ignore)] // serial_test has intentional leaks that Miri flags
+    #[serial(runtime_callback)]
     fn test_runtime_callback_frame_registration() {
         // Ensure clean state
         unsafe {

bin_tests/src/modes/unix/test_010_runtime_callback_frame.rs

@@ -52,8 +52,11 @@ unsafe extern "C" fn test_runtime_callback_string(
 mod tests {
     use super::*;
     use libdd_crashtracker::{clear_runtime_callback, is_runtime_callback_registered};
+    use serial_test::serial;
 
     #[test]
+    #[cfg_attr(miri, ignore)] // serial_test has intentional leaks that Miri flags
+    #[serial(runtime_callback)]
     fn test_runtime_callback_string_registration() {
         unsafe {
             clear_runtime_callback();

bin_tests/src/modes/unix/test_011_runtime_callback_string.rs

@@ -136,8 +136,11 @@ unsafe extern "C" fn test_runtime_callback_frame_with_invalid_utf8(
 mod tests {
     use super::*;
     use libdd_crashtracker::{clear_runtime_callback, is_runtime_callback_registered};
+    use serial_test::serial;
 
     #[test]
+    #[cfg_attr(miri, ignore)] // serial_test has intentional leaks that Miri flags
+    #[serial(runtime_callback)]
     fn test_runtime_callback_frame_invalid_utf8_registration() {
         // Ensure clean state
         unsafe {