style: clippy::large_enum_variant and clippy::derivable_impls

Author: morrisonlevi

datadog-profiling-ffi/src/profiles/datatypes.rs

@@ -6,13 +6,13 @@ use anyhow::Context;
 use datadog_profiling::api;
 use datadog_profiling::api::ManagedStringId;
 use datadog_profiling::internal;
+use datadog_profiling::serializer::UploadCompression;
 use ddcommon_ffi::slice::{AsBytes, ByteSlice, CharSlice, Slice};
 use ddcommon_ffi::{wrap_with_ffi_result, Error, Handle, Timespec, ToInner};
 use function_name::named;
 use std::num::NonZeroI64;
 use std::str::Utf8Error;
 use std::time::SystemTime;
-use datadog_profiling::serializer::UploadCompression;
 
 /// Represents a profile. Do not access its member for any reason, only use
 /// the C API functions on this struct.

datadog-profiling/src/serializer/compressed_streaming_encoder.rs

@@ -7,6 +7,9 @@ use lz4_flex::frame::FrameEncoder;
 use prost::encoding::{encode_key, encode_varint, encoded_len_varint, key_len, WireType};
 use std::io::{self, Write};
 
+// None is not really for prod, so the fact it takes 0 space, creating a large
+// discrepancy in size between the enum variants, is irrelevant.
+#[allow(clippy::large_enum_variant)]
 enum Compressor {
     None,
     Lz4 { zipper: FrameEncoder<Vec<u8>> },

datadog-profiling/src/serializer/mod.rs

@@ -6,17 +6,12 @@ mod compressed_streaming_encoder;
 pub use compressed_streaming_encoder::*;
 
 #[repr(C)]
-#[derive(Debug)]
+#[derive(Debug, Default)]
 pub enum UploadCompression {
     Off,
     /// On is the default, with the exact compression algorithm being
     /// unspecified, and free to change. For example, we're testing zstd.
+    #[default]
     On,
     Lz4,
 }
-
-impl Default for UploadCompression {
-    fn default() -> Self {
-        UploadCompression::On
-    }
-}