Skip to content

[Crashtracker] Use range-based datastructure to store modules #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Crashtracker] Use range-based datastructure to store modules #1250

wants to merge 2 commits into from

Conversation

gleocadie
Copy link
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-09-30 13:01:17

Comparing candidate commit 7062850 in PR branch gleocadie/improve-windows-crashtracker with baseline commit 0b59f64 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

scenario:concentrator/add_spans_to_concentrator

  • 🟥 execution_time [+1.244ms; +1.250ms] or [+11.849%; +11.907%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 186.378µs 186.817µs ± 0.223µs 186.782µs ± 0.115µs 186.917µs 187.176µs 187.357µs 188.151µs 0.73% 2.002 8.589 0.12% 0.016µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 5314871.595op/s 5352848.060op/s ± 6363.289op/s 5353824.561op/s ± 3286.129op/s 5356657.829op/s 5360740.225op/s 5362594.377op/s 5365433.650op/s 0.22% -1.978 8.429 0.12% 449.952op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 17.563µs 17.654µs ± 0.037µs 17.651µs ± 0.025µs 17.680µs 17.718µs 17.745µs 17.761µs 0.62% 0.259 -0.033 0.21% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 56303535.673op/s 56644424.785op/s ± 118760.972op/s 56654971.493op/s ± 80331.382op/s 56721213.585op/s 56827101.752op/s 56885264.674op/s 56939079.491op/s 0.50% -0.247 -0.043 0.21% 8397.669op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 9.812µs 9.917µs ± 0.099µs 9.872µs ± 0.030µs 9.997µs 10.047µs 10.068µs 10.741µs 8.79% 3.192 22.411 0.99% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 93104244.772op/s 100850114.582op/s ± 973357.039op/s 101292288.651op/s ± 308032.774op/s 101523649.106op/s 101791926.466op/s 101896787.713op/s 101919668.629op/s 0.62% -2.806 18.055 0.96% 68826.736op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [186.786µs; 186.848µs] or [-0.017%; +0.017%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [5351966.169op/s; 5353729.950op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [17.649µs; 17.659µs] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [56627965.657op/s; 56660883.914op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_name/normalize_name/good execution_time [9.903µs; 9.930µs] or [-0.138%; +0.138%] None None None
normalization/normalize_name/normalize_name/good throughput [100715216.657op/s; 100985012.506op/s] or [-0.134%; +0.134%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.223µs 3.202µs ± 1.436µs 2.990µs ± 0.023µs 3.015µs 3.643µs 13.880µs 14.840µs 396.25% 7.404 55.796 44.74% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.003µs; 3.401µs] or [-6.216%; +6.216%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.950µs 5.026µs ± 0.042µs 5.017µs ± 0.026µs 5.044µs 5.104µs 5.107µs 5.109µs 1.81% 0.486 -0.833 0.84% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.020µs; 5.032µs] or [-0.117%; +0.117%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.222ms 60.714ms ± 2.438ms 60.408ms ± 0.081ms 60.482ms 60.658ms 79.763ms 81.055ms 34.18% 7.956 61.522 4.01% 0.172ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.376ms; 61.052ms] or [-0.557%; +0.557%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.819µs 25.817µs ± 10.103µs 18.074µs ± 0.163µs 35.521µs 45.315µs 46.587µs 70.665µs 290.97% 1.023 0.665 39.03% 0.714µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.417µs; 27.217µs] or [-5.423%; +5.423%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.407µs 2.434µs ± 0.015µs 2.431µs ± 0.009µs 2.442µs 2.467µs 2.470µs 2.478µs 1.95% 0.930 0.358 0.60% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.432µs; 2.436µs] or [-0.083%; +0.083%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.419µs 34.952µs ± 0.801µs 34.593µs ± 0.067µs 34.738µs 36.617µs 36.673µs 38.426µs 11.08% 1.809 1.913 2.29% 0.057µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.841µs; 35.063µs] or [-0.318%; +0.318%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.891µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.918µs 3.918µs 0.15% -1.474 10.271 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255250733.185op/s 255647269.200op/s ± 196552.209op/s 255643592.244op/s ± 133397.988op/s 255781421.621op/s 255898426.218op/s 255986442.438op/s 257023413.556op/s 0.54% 1.497 10.461 0.08% 13898.340op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 76.765µs 78.403µs ± 0.806µs 78.359µs ± 0.554µs 78.926µs 79.867µs 80.412µs 80.590µs 2.85% 0.367 -0.220 1.02% 0.057µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12408488.608op/s 12755951.611op/s ± 130613.457op/s 12761741.059op/s ± 89920.848op/s 12848046.778op/s 12949222.377op/s 13011868.021op/s 13026849.558op/s 2.08% -0.317 -0.271 1.02% 9235.766op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 69.877µs 71.155µs ± 0.676µs 71.077µs ± 0.511µs 71.595µs 72.510µs 72.861µs 73.031µs 2.75% 0.513 -0.243 0.95% 0.048µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13692814.050op/s 14055179.217op/s ± 132981.493op/s 14069194.879op/s ± 100463.344op/s 14168751.744op/s 14227137.694op/s 14289064.161op/s 14310906.992op/s 1.72% -0.471 -0.301 0.94% 9403.212op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.889µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.916µs 3.918µs 3.919µs 0.21% -1.714 10.957 0.08% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255179484.887op/s 255693588.442op/s ± 215205.788op/s 255703145.152op/s ± 129079.329op/s 255822430.238op/s 255948469.656op/s 256099617.438op/s 257152086.401op/s 0.57% 1.739 11.140 0.08% 15217.347op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 66.745µs 68.130µs ± 0.668µs 68.118µs ± 0.444µs 68.558µs 69.358µs 69.628µs 69.811µs 2.49% 0.207 -0.330 0.98% 0.047µs 1 200
credit_card/is_card_number/378282246310005 throughput 14324474.710op/s 14679262.856op/s ± 143675.717op/s 14680494.176op/s ± 96180.844op/s 14778074.160op/s 14903558.307op/s 14972274.138op/s 14982441.186op/s 2.06% -0.160 -0.362 0.98% 10159.407op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.139µs 52.201µs ± 0.040µs 52.192µs ± 0.021µs 52.218µs 52.279µs 52.328µs 52.385µs 0.37% 1.430 2.648 0.08% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19089384.652op/s 19156558.655op/s ± 14796.737op/s 19160044.601op/s ± 7735.144op/s 19166704.081op/s 19173287.680op/s 19177126.387op/s 19179456.884op/s 0.10% -1.424 2.621 0.08% 1046.287op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.041µs ± 0.027µs 6.033µs ± 0.003µs 6.037µs 6.105µs 6.194µs 6.218µs 3.07% 4.269 20.752 0.44% 0.002µs 1 200
credit_card/is_card_number/x371413321323331 throughput 160813145.800op/s 165542089.548op/s ± 713335.805op/s 165754558.115op/s ± 76162.576op/s 165815955.100op/s 165883817.517op/s 165914512.699op/s 165928034.898op/s 0.10% -4.211 20.156 0.43% 50440.459op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.892µs 3.911µs ± 0.002µs 3.911µs ± 0.001µs 3.912µs 3.915µs 3.916µs 3.918µs 0.18% -1.711 16.658 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255263779.727op/s 255712369.442op/s ± 156016.048op/s 255719357.955op/s ± 75199.728op/s 255797324.489op/s 255886086.771op/s 255925574.337op/s 256917248.230op/s 0.47% 1.740 16.897 0.06% 11032.001op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.034µs 64.401µs ± 0.172µs 64.395µs ± 0.106µs 64.497µs 64.659µs 64.886µs 65.040µs 1.00% 0.597 1.161 0.27% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15375127.991op/s 15527867.156op/s ± 41289.731op/s 15529195.410op/s ± 25686.101op/s 15554999.775op/s 15594528.596op/s 15611320.672op/s 15616652.036op/s 0.56% -0.575 1.109 0.27% 2919.625op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.778µs 57.985µs ± 0.143µs 57.954µs ± 0.078µs 58.043µs 58.263µs 58.421µs 58.639µs 1.18% 1.381 2.411 0.25% 0.010µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17053587.597op/s 17245834.675op/s ± 42507.274op/s 17255112.557op/s ± 23055.971op/s 17275702.590op/s 17296314.588op/s 17302750.217op/s 17307689.807op/s 0.30% -1.363 2.330 0.25% 3005.718op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.912µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.917µs 3.920µs 3.921µs 0.25% -0.028 4.641 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255043950.446op/s 255646005.513op/s ± 193131.580op/s 255679878.001op/s ± 104770.895op/s 255760455.385op/s 255877100.256op/s 255919458.186op/s 256722938.220op/s 0.41% 0.043 4.704 0.08% 13656.465op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.573µs 54.815µs ± 0.197µs 54.768µs ± 0.137µs 54.946µs 55.193µs 55.384µs 55.393µs 1.14% 0.955 0.248 0.36% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18052785.160op/s 18243256.579op/s ± 65214.679op/s 18258682.428op/s ± 45706.049op/s 18299663.744op/s 18315891.602op/s 18321855.445op/s 18324118.204op/s 0.36% -0.941 0.208 0.36% 4611.374op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.138µs 52.205µs ± 0.032µs 52.202µs ± 0.021µs 52.224µs 52.257µs 52.283µs 52.373µs 0.33% 0.990 2.852 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19093754.711op/s 19155217.269op/s ± 11791.258op/s 19156212.729op/s ± 7754.633op/s 19163557.621op/s 19170993.523op/s 19176222.597op/s 19179853.482op/s 0.12% -0.983 2.815 0.06% 833.768op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.026µs 6.034µs ± 0.008µs 6.033µs ± 0.003µs 6.036µs 6.041µs 6.073µs 6.106µs 1.21% 5.885 46.741 0.12% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163773062.524op/s 165723274.722op/s ± 205824.928op/s 165758968.753op/s ± 69822.177op/s 165820294.341op/s 165880270.391op/s 165924820.500op/s 165938387.087op/s 0.11% -5.832 46.048 0.12% 14554.020op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255620028.955op/s; 255674509.446op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.291µs; 78.515µs] or [-0.142%; +0.142%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12737849.842op/s; 12774053.380op/s] or [-0.142%; +0.142%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.061µs; 71.248µs] or [-0.132%; +0.132%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14036749.261op/s; 14073609.173op/s] or [-0.131%; +0.131%] None None None
credit_card/is_card_number/37828224631 execution_time [3.910µs; 3.911µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631 throughput [255663762.989op/s; 255723413.894op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 execution_time [68.037µs; 68.222µs] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/378282246310005 throughput [14659350.783op/s; 14699174.928op/s] or [-0.136%; +0.136%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.196µs; 52.207µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19154507.970op/s; 19158609.341op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.037µs; 6.045µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/x371413321323331 throughput [165443228.066op/s; 165640951.030op/s] or [-0.060%; +0.060%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.910µs; 3.911µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [255690747.118op/s; 255733991.766op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.377µs; 64.425µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15522144.797op/s; 15533589.516op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.965µs; 58.005µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17239943.576op/s; 17251725.775op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255619239.333op/s; 255672771.692op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.788µs; 54.843µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18234218.451op/s; 18252294.706op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.201µs; 52.210µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19153583.114op/s; 19156851.424op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.033µs; 6.035µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165694749.367op/s; 165751800.077op/s] or [-0.017%; +0.017%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 86.182µs 86.776µs ± 0.167µs 86.769µs ± 0.050µs 86.823µs 86.906µs 87.267µs 88.463µs 1.95% 5.129 52.872 0.19% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [86.753µs; 86.799µs] or [-0.027%; +0.027%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 155.590µs 156.632µs ± 0.285µs 156.590µs ± 0.127µs 156.725µs 157.069µs 157.514µs 158.198µs 1.03% 1.337 7.035 0.18% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [156.593µs; 156.672µs] or [-0.025%; +0.025%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.318µs 534.953µs ± 0.397µs 534.893µs ± 0.239µs 535.157µs 535.571µs 536.189µs 537.637µs 0.51% 2.133 10.079 0.07% 0.028µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1859991.442op/s 1869322.749op/s ± 1383.755op/s 1869534.327op/s ± 835.650op/s 1870315.822op/s 1871027.715op/s 1871191.379op/s 1871544.455op/s 0.11% -2.116 9.941 0.07% 97.846op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.237µs 380.843µs ± 0.323µs 380.791µs ± 0.192µs 381.039µs 381.323µs 381.760µs 382.245µs 0.38% 0.942 2.289 0.08% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2616125.845op/s 2625759.100op/s ± 2225.491op/s 2626112.937op/s ± 1325.090op/s 2627269.429op/s 2629228.871op/s 2629829.789op/s 2629937.193op/s 0.15% -0.934 2.257 0.08% 157.366op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 193.678µs 194.103µs ± 0.245µs 194.095µs ± 0.156µs 194.253µs 194.434µs 194.616µs 195.897µs 0.93% 1.990 12.737 0.13% 0.017µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5104715.857op/s 5151916.539op/s ± 6496.899op/s 5152115.885op/s ± 4148.746op/s 5156161.124op/s 5160935.313op/s 5162462.485op/s 5163220.262op/s 0.22% -1.950 12.374 0.13% 459.400op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 35.911µs 36.129µs ± 0.065µs 36.123µs ± 0.044µs 36.172µs 36.230µs 36.294µs 36.321µs 0.55% 0.157 0.378 0.18% 0.005µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 27532011.501op/s 27679011.920op/s ± 49809.984op/s 27682953.498op/s ± 33847.937op/s 27711891.253op/s 27757730.984op/s 27773104.369op/s 27846384.619op/s 0.59% -0.144 0.376 0.18% 3522.098op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.892µs 45.108µs ± 0.163µs 45.079µs ± 0.137µs 45.245µs 45.370µs 45.463µs 45.519µs 0.98% 0.343 -1.002 0.36% 0.012µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21969041.227op/s 22169365.920op/s ± 80229.000op/s 22183341.182op/s ± 67069.548op/s 22233592.921op/s 22274181.287op/s 22274869.454op/s 22275474.356op/s 0.42% -0.334 -1.015 0.36% 5673.047op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.898µs; 535.008µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1869130.974op/s; 1869514.524op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.798µs; 380.887µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2625450.668op/s; 2626067.531op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.069µs; 194.137µs] or [-0.018%; +0.018%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5151016.131op/s; 5152816.947op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.120µs; 36.138µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27672108.735op/s; 27685915.105op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.085µs; 45.131µs] or [-0.050%; +0.050%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22158246.952op/s; 22180484.887op/s] or [-0.050%; +0.050%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 239.905ns 253.760ns ± 13.857ns 246.788ns ± 3.592ns 263.230ns 280.894ns 290.795ns 296.904ns 20.31% 1.247 0.418 5.45% 0.980ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.840ns; 255.681ns] or [-0.757%; +0.757%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 6.186ms 6.259ms ± 0.042ms 6.249ms ± 0.019ms 6.273ms 6.363ms 6.398ms 6.418ms 2.69% 1.599 2.582 0.67% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [6.253ms; 6.265ms] or [-0.094%; +0.094%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 11.713ms 11.743ms ± 0.016ms 11.741ms ± 0.011ms 11.754ms 11.768ms 11.793ms 11.818ms 0.65% 0.961 2.114 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [11.741ms; 11.746ms] or [-0.019%; +0.019%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 7062850 1759236499 gleocadie/improve-windows-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.346ms 14.418ms ± 0.039ms 14.413ms ± 0.021ms 14.434ms 14.475ms 14.539ms 14.665ms 1.75% 1.979 8.115 0.27% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.412ms; 14.423ms] or [-0.038%; +0.038%] None None None

Baseline

Omitted due to size.

@gleocadie gleocadie force-pushed the gleocadie/improve-windows-crashtracker branch 3 times, most recently from d41cb20 to 4250409 Compare September 30, 2025 12:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.68%. Comparing base (f61c42a) to head (7062850).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1250      +/-   ##
==========================================
+ Coverage   71.65%   71.68%   +0.02%     
==========================================
  Files         355      355              
  Lines       56317    56312       -5     
==========================================
+ Hits        40354    40367      +13     
+ Misses      15963    15945      -18
Components Coverage Δ
datadog-crashtracker 49.30% <ø> (-0.03%) ⬇️
datadog-crashtracker-ffi 5.93% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.45% <ø> (+0.03%) ⬆️
data-pipeline-ffi 88.19% <ø> (ø)
ddcommon 84.29% <ø> (ø)
ddcommon-ffi 73.84% <ø> (ø)
ddtelemetry 59.98% <ø> (ø)
ddtelemetry-ffi 21.24% <ø> (ø)
dogstatsd-client 83.26% <ø> (ø)
datadog-ipc 82.39% <ø> (-0.11%) ⬇️
datadog-profiling 76.90% <ø> (ø)
datadog-profiling-ffi 62.12% <ø> (ø)
datadog-sidecar 37.19% <ø> (+0.10%) ⬆️
datdog-sidecar-ffi 11.87% <ø> (+0.50%) ⬆️
spawn-worker 55.35% <ø> (ø)
tinybytes 92.22% <ø> (ø)
datadog-trace-normalization 98.24% <ø> (ø)
datadog-trace-obfuscation 94.17% <ø> (ø)
datadog-trace-protobuf 59.65% <ø> (ø)
datadog-trace-utils 89.77% <ø> (ø)
datadog-tracer-flare 54.52% <ø> (ø)
datadog-log 76.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gleocadie gleocadie force-pushed the gleocadie/improve-windows-crashtracker branch from 4250409 to 7062850 Compare September 30, 2025 12:48
@dd-octo-sts
Copy link

dd-octo-sts bot commented Sep 30, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.19 MB 7.19 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 71.00 MB 71.00 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.25 MB 9.25 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 83.28 MB 83.28 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 18.39 MB 18.39 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 125.21 MB 125.91 MB +.56% (+720.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 654.56 MB 656.94 MB +.36% (+2.37 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.89 MB 5.89 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 65.77 KB 65.77 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 17.37 MB 17.37 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 32.24 MB 32.24 MB -0% (-52 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 15.68 MB 15.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 127.50 MB 128.24 MB +.58% (+760.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 644.68 MB 647.05 MB +.36% (+2.36 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 4.50 MB 4.50 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 66.79 KB 66.79 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 18.51 MB 18.51 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 30.27 MB 30.27 MB +0% (+152 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 63.65 MB 63.65 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.51 MB 8.51 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 78.06 MB 78.06 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.85 MB 9.85 MB 0% (0 B) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crashtracker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @codecov-commenter