Enabling metrics for requests that don't have a defined route. (#8)

* Enabling metrics for requests that don't have a defined route.

* Incrementing version.

* Exclude the `route` metric if the derived metric value is an empty string.

* Only sending metrics if there are tags associated with the request.

* Updating tests.

* Updating jest version to support the latest version of Node.

* Revert "Only sending metrics if there are tags associated with the request."

This reverts commit 3fed74f.

* Removing test case that is no longer valid.

* Refactoring the code that builds the request route into a separate function.

Author: lewisvail3

lib/index.js

@@ -27,6 +27,12 @@ module.exports = function (options) {
 		return str && str.replace(REGEX_PIPE, DELIM);
 	}
 
+	function getRoute(req, base_url) {
+		const routePath = req.route && req.route.path ? req.route.path : '';
+		const baseUrl = (base_url !== false) ? req.baseUrl : '';
+		return baseUrl + replacePipeChar(routePath);
+	}
+
 	return function (req, res, next) {
 		if (!req._startTime) {
 			req._startTime = new Date();
@@ -37,13 +43,13 @@ module.exports = function (options) {
 			res.end = end;
 			res.end(chunk, encoding);
 
-			if (!req.route || !req.route.path) {
-				return;
+			let statTags = [...tags];
+			
+			const route = getRoute(req, base_url);
+			if (route.length > 0) {
+				statTags.push(`route:${route}`);
 			}
 
-			const baseUrl = (base_url !== false) ? req.baseUrl : '';
-			let statTags = [`route:${baseUrl + replacePipeChar(req.route.path)}`].concat(tags);
-
 			if (method !== false) {
 				statTags.push(`method:${req.method.toLowerCase()}`);
 			}

lib/index.test.js

@@ -205,13 +205,33 @@ describe('connectDatadog', () => {
       })
 
       describe('when the path is not set in the request', () => {
-        it('should NOT send a response', async () => {
-          req = {}
+        describe('when base_url is truthly', () => {
+          it('uses the base URL as the route', async() => {
+            delete req.route
+            const stat = 'node.express.router'
+            const statTags = [
+              `route:${req.baseUrl}`,
+              `response_code:${res.statusCode}`,
+            ]
+    
+            await asyncConnectDatadogAndCallMiddleware({ base_url: true, response_code: true })
+            expectConnectedToDatadog(stat, statTags, false)
+            expect(next).toHaveBeenCalled()
+          })
+        })
 
-          await asyncConnectDatadogAndCallMiddleware({})
-          expect(mockStatsDImplementation.increment).not.toHaveBeenCalled()
-          expect(mockStatsDImplementation.histogram).not.toHaveBeenCalled()
-          expect(next).toHaveBeenCalled()
+        describe('when base_url is falsely', () => {
+          it('route tag is not specified', async() => {
+            delete req.route
+            const stat = 'node.express.router'
+            const statTags = [
+              `response_code:${res.statusCode}`,
+            ]
+    
+            await asyncConnectDatadogAndCallMiddleware({ response_code: true })
+            expectConnectedToDatadog(stat, statTags, false)
+            expect(next).toHaveBeenCalled()
+          })
         })
       })
     })