Skip to content

Commit 4f1dcf8

Browse files
Mohamed IssaVladimir Ivanov
Mohamed Issa
authored and
Vladimir Ivanov
committed
8368977: Provide clear naming for AVX10 identifiers
Reviewed-by: jbhateja, mhaessig, vlivanov
1 parent 17744fb commit 4f1dcf8

File tree

9 files changed

+99
-99
lines changed

9 files changed

+99
-99
lines changed

‎src/hotspot/cpu/x86/assembler_x86.hpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,8 @@ const int FPUStateSizeInWords = 2688 / wordSize;
449449
// imm8[1:0] = 00 (min) / 01 (max)
450450
//
451451
// [1] https://www.intel.com/content/www/us/en/content-details/856721/intel-advanced-vector-extensions-10-2-intel-avx10-2-architecture-specification.html?wapkw=AVX10
452-
const int AVX10_MINMAX_MAX_COMPARE_SIGN = 0x5;
453-
const int AVX10_MINMAX_MIN_COMPARE_SIGN = 0x4;
452+
const int AVX10_2_MINMAX_MAX_COMPARE_SIGN = 0x5;
453+
const int AVX10_2_MINMAX_MIN_COMPARE_SIGN = 0x4;
454454

455455
// The Intel x86/Amd64 Assembler: Pure assembler doing NO optimizations on the instruction
456456
// level (e.g. mov rax, 0 is not translated into xor rax, rax!); i.e., what you write

‎src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,8 +1033,8 @@ void C2_MacroAssembler::vminmax_fp(int opc, BasicType elem_bt, XMMRegister dst,
10331033
assert(opc == Op_MinV || opc == Op_MinReductionV ||
10341034
opc == Op_MaxV || opc == Op_MaxReductionV, "sanity");
10351035

1036-
int imm8 = (opc == Op_MinV || opc == Op_MinReductionV) ? AVX10_MINMAX_MIN_COMPARE_SIGN
1037-
: AVX10_MINMAX_MAX_COMPARE_SIGN;
1036+
int imm8 = (opc == Op_MinV || opc == Op_MinReductionV) ? AVX10_2_MINMAX_MIN_COMPARE_SIGN
1037+
: AVX10_2_MINMAX_MAX_COMPARE_SIGN;
10381038
if (elem_bt == T_FLOAT) {
10391039
evminmaxps(dst, mask, src1, src2, true, imm8, vlen_enc);
10401040
} else {
@@ -5163,7 +5163,7 @@ void C2_MacroAssembler::vector_castD2X_evex(BasicType to_elem_bt, XMMRegister ds
51635163
}
51645164
}
51655165

5166-
void C2_MacroAssembler::vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc) {
5166+
void C2_MacroAssembler::vector_castF2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc) {
51675167
switch(to_elem_bt) {
51685168
case T_LONG:
51695169
evcvttps2qqs(dst, src, vec_enc);
@@ -5183,7 +5183,7 @@ void C2_MacroAssembler::vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister d
51835183
}
51845184
}
51855185

5186-
void C2_MacroAssembler::vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc) {
5186+
void C2_MacroAssembler::vector_castF2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc) {
51875187
switch(to_elem_bt) {
51885188
case T_LONG:
51895189
evcvttps2qqs(dst, src, vec_enc);
@@ -5203,7 +5203,7 @@ void C2_MacroAssembler::vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister d
52035203
}
52045204
}
52055205

5206-
void C2_MacroAssembler::vector_castD2X_avx10(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc) {
5206+
void C2_MacroAssembler::vector_castD2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc) {
52075207
switch(to_elem_bt) {
52085208
case T_LONG:
52095209
evcvttpd2qqs(dst, src, vec_enc);
@@ -5223,7 +5223,7 @@ void C2_MacroAssembler::vector_castD2X_avx10(BasicType to_elem_bt, XMMRegister d
52235223
}
52245224
}
52255225

5226-
void C2_MacroAssembler::vector_castD2X_avx10(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc) {
5226+
void C2_MacroAssembler::vector_castD2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc) {
52275227
switch(to_elem_bt) {
52285228
case T_LONG:
52295229
evcvttpd2qqs(dst, src, vec_enc);

‎src/hotspot/cpu/x86/c2_MacroAssembler_x86.hpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,13 +347,13 @@
347347
XMMRegister xtmp2, XMMRegister xtmp3, XMMRegister xtmp4, XMMRegister xtmp5,
348348
AddressLiteral float_sign_flip, Register rscratch, int vec_enc);
349349

350-
void vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc);
350+
void vector_castF2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc);
351351

352-
void vector_castF2X_avx10(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc);
352+
void vector_castF2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc);
353353

354-
void vector_castD2X_avx10(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc);
354+
void vector_castD2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, XMMRegister src, int vec_enc);
355355

356-
void vector_castD2X_avx10(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc);
356+
void vector_castD2X_avx10_2(BasicType to_elem_bt, XMMRegister dst, Address src, int vec_enc);
357357

358358
void vector_cast_double_to_int_special_cases_avx(XMMRegister dst, XMMRegister src, XMMRegister xtmp1, XMMRegister xtmp2,
359359
XMMRegister xtmp3, XMMRegister xtmp4, XMMRegister xtmp5, Register rscratch,

‎src/hotspot/cpu/x86/macroAssembler_x86.cpp‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8899,9 +8899,9 @@ void MacroAssembler::evpmins(BasicType type, XMMRegister dst, KRegister mask, XM
88998899
case T_LONG:
89008900
evpminsq(dst, mask, nds, src, merge, vector_len); break;
89018901
case T_FLOAT:
8902-
evminmaxps(dst, mask, nds, src, merge, AVX10_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
8902+
evminmaxps(dst, mask, nds, src, merge, AVX10_2_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
89038903
case T_DOUBLE:
8904-
evminmaxpd(dst, mask, nds, src, merge, AVX10_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
8904+
evminmaxpd(dst, mask, nds, src, merge, AVX10_2_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
89058905
default:
89068906
fatal("Unexpected type argument %s", type2name(type)); break;
89078907
}
@@ -8918,9 +8918,9 @@ void MacroAssembler::evpmaxs(BasicType type, XMMRegister dst, KRegister mask, XM
89188918
case T_LONG:
89198919
evpmaxsq(dst, mask, nds, src, merge, vector_len); break;
89208920
case T_FLOAT:
8921-
evminmaxps(dst, mask, nds, src, merge, AVX10_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
8921+
evminmaxps(dst, mask, nds, src, merge, AVX10_2_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
89228922
case T_DOUBLE:
8923-
evminmaxpd(dst, mask, nds, src, merge, AVX10_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
8923+
evminmaxpd(dst, mask, nds, src, merge, AVX10_2_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
89248924
default:
89258925
fatal("Unexpected type argument %s", type2name(type)); break;
89268926
}
@@ -8937,9 +8937,9 @@ void MacroAssembler::evpmins(BasicType type, XMMRegister dst, KRegister mask, XM
89378937
case T_LONG:
89388938
evpminsq(dst, mask, nds, src, merge, vector_len); break;
89398939
case T_FLOAT:
8940-
evminmaxps(dst, mask, nds, src, merge, AVX10_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
8940+
evminmaxps(dst, mask, nds, src, merge, AVX10_2_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
89418941
case T_DOUBLE:
8942-
evminmaxpd(dst, mask, nds, src, merge, AVX10_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
8942+
evminmaxpd(dst, mask, nds, src, merge, AVX10_2_MINMAX_MIN_COMPARE_SIGN, vector_len); break;
89438943
default:
89448944
fatal("Unexpected type argument %s", type2name(type)); break;
89458945
}
@@ -8956,9 +8956,9 @@ void MacroAssembler::evpmaxs(BasicType type, XMMRegister dst, KRegister mask, XM
89568956
case T_LONG:
89578957
evpmaxsq(dst, mask, nds, src, merge, vector_len); break;
89588958
case T_FLOAT:
8959-
evminmaxps(dst, mask, nds, src, merge, AVX10_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
8959+
evminmaxps(dst, mask, nds, src, merge, AVX10_2_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
89608960
case T_DOUBLE:
8961-
evminmaxps(dst, mask, nds, src, merge, AVX10_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
8961+
evminmaxps(dst, mask, nds, src, merge, AVX10_2_MINMAX_MAX_COMPARE_SIGN, vector_len); break;
89628962
default:
89638963
fatal("Unexpected type argument %s", type2name(type)); break;
89648964
}

0 commit comments

Comments
 (0)