Use Agent 7.64.3 fixed version and explicitly cast to Integer to avoid eval error (#865)

Author: tbavelier

environments/etc/manifests/site.pp

@@ -1,6 +1,8 @@
 node default {
   class { 'datadog_agent':
     api_key             => 'somenonnullapikeythats32charlong',
+    # Pin the Agent version to 7.64.3 to avoid breaking changes in postint for kitchen tests
+    agent_version       => '7.64.3',
     agent_extra_options => {
       use_http => true,
     },

manifests/redhat.pp

@@ -19,7 +19,7 @@
     ]
     #In this regex, version '1:6.15.0~rc.1-1' would match as $1='1:', $2='6', $3='15', $4='0', $5='~rc.1', $6='1'
     if $agent_version =~ /([0-9]+:)?([0-9]+)\.([0-9]+)\.([0-9]+)((?:~|-)[^0-9\s-]+[^-\s]*)?(?:-([0-9]+))?/ or $agent_version == 'latest' {
-      if $agent_major_version >= 6 and ($agent_version == 'latest' or 0 + $3 > 35) {
+      if $agent_major_version >= 6 and ($agent_version == 'latest' or Integer($3, 10) > 35) {
         $keys = $all_keys[0,3]
       } else {
         $keys = $all_keys

manifests/suse.pp

@@ -19,7 +19,7 @@
   ]
   #In this regex, version '1:6.15.0~rc.1-1' would match as $1='1:', $2='6', $3='15', $4='0', $5='~rc.1', $6='1'
   if $agent_version =~ /([0-9]+:)?([0-9]+)\.([0-9]+)\.([0-9]+)((?:~|-)[^0-9\s-]+[^-\s]*)?(?:-([0-9]+))?/ or $agent_version == 'latest' {
-    if $agent_major_version >= 6 and ($agent_version == 'latest' or 0 + $3 > 35) {
+    if $agent_major_version >= 6 and ($agent_version == 'latest' or Integer($3, 10) > 35) {
       $keys_to_use = $all_keys[0,3]
     } else {
       $keys_to_use = $all_keys