fix: do not set empty tls_protocols_allowed and tls_ciphers for es (#852)

* fix: do not set empty tls_protocol_allowed and tls_ciphers for es

* fix: do not fail when tls_protocols_allowed and tls_ciphers are not passed via _instances

Fix: Added fallback for possible empty params

* fix: remove whitespace

Author: nielstholenaar

templates/agent-conf.d/elastic.yaml.erb

@@ -33,22 +33,25 @@ instances:
 <%- if instance['tls_ignore_warning'] && instance['tls_ignore_warning'] != :undef -%>
       tls_ignore_warning: <%= instance['tls_ignore_warning'] %>
 <%- end -%>
-<%- unless instance['tags'].empty? -%>
+<%- tags = Array(instance['tags']) -%>
+<%- unless tags.empty? -%>
       tags:
-  <%- instance['tags'].each do |tag| -%>
+    <%- tags.each do |tag| -%>
         - <%= tag %>
-  <%- end -%>
+    <%- end -%>
 <%- end -%>
-<%- unless instance['tls_protocols_allowed'].nil? -%>
+<%- protocols = Array(instance['tls_protocols_allowed']) -%>
+  <%- unless protocols.empty? -%>
       tls_protocols_allowed:
-  <%- instance['tls_protocols_allowed'].each do |protocol| -%>
+    <%- protocols.each do |protocol| -%>
         - <%= protocol %>
+    <%- end -%>
   <%- end -%>
-<%- end -%>
-<%- unless instance['tls_ciphers'].nil? -%>
+  <%- ciphers = Array(instance['tls_ciphers']) -%>
+  <%- unless ciphers.empty? -%>
       tls_ciphers:
-  <%- instance['tls_ciphers'].each do |cipher| -%>
+    <%- ciphers.each do |cipher| -%>
         - <%= cipher %>
+    <%- end -%>
   <%- end -%>
 <%- end -%>
-<%- end -%>