chore(agent-data-plane): only emit OTLP config-related logs if OTLP pipeline is enabled (#1100)

Author: tobz

bin/agent-data-plane/src/cli/run.rs

@@ -408,7 +408,21 @@ fn add_otlp_pipeline_to_blueprint(
     if dp_config.otlp().proxy().enabled() {
         let core_agent_otlp_grpc_endpoint = dp_config.otlp().proxy().core_agent_otlp_grpc_endpoint().to_string();
         let core_agent_otlp_http_endpoint = dp_config.otlp().proxy().core_agent_otlp_http_endpoint().to_string();
-        let api_key = config.get_typed::<String>("api_key").expect("API key is required");
+        let proxy_metrics = dp_config.otlp().proxy().proxy_metrics();
+        let proxy_logs = dp_config.otlp().proxy().proxy_logs();
+        let proxy_traces = dp_config.otlp().proxy().proxy_traces();
+        let api_key = config
+            .get_typed::<String>("api_key")
+            .error_context("API key must be set.")?;
+
+        info!(
+            proxy_grpc_endpoint = %core_agent_otlp_grpc_endpoint,
+            proxy_http_endpoint = %core_agent_otlp_http_endpoint,
+            proxy_metrics,
+            proxy_logs,
+            proxy_traces,
+            "OTLP proxy mode enabled. Select OTLP payloads will be proxied to the Core Agent."
+        );
 
         let otlp_relay_config = OtlpRelayConfiguration::from_configuration(config)?;
         let otlp_decoder_config = OtlpDecoderConfiguration::from_configuration(config)?;
@@ -434,13 +448,15 @@ fn add_otlp_pipeline_to_blueprint(
                 .connect_component("dd_traces_encode", ["otlp_traces_decode"])?;
         }
     } else {
+        info!("OTLP proxy mode disabled. OTLP signals will be handled natively.");
+
         let otlp_config =
             OtlpConfiguration::from_configuration(config)?.with_workload_provider(env_provider.workload().clone());
 
         blueprint
             // Components.
             .add_source("otlp_in", otlp_config)?
-            // Metrics and logs.
+            // Metrics, logs, and traces.
             //
             // We send OTLP metrics directly to the enrichment stage of the metrics pipeline, skipping aggregation,
             // to avoid transforming counters into rates.

bin/agent-data-plane/src/config.rs

@@ -1,7 +1,6 @@
 use saluki_config::GenericConfiguration;
 use saluki_error::GenericError;
 use saluki_io::net::ListenAddress;
-use tracing::info;
 
 /// General data plane configuration.
 #[derive(Clone, Debug)]
@@ -258,20 +257,6 @@ impl DataPlaneOtlpProxyConfiguration {
             .try_get_typed("data_plane.otlp.proxy.logs.enabled")?
             .unwrap_or(true);
 
-        if enabled {
-            info!(
-                proxy_enabled = enabled,
-                core_agent_otlp_grpc_endpoint = %core_agent_otlp_grpc_endpoint,
-                core_agent_otlp_http_endpoint = %core_agent_otlp_http_endpoint,
-                proxy_traces = proxy_traces,
-                proxy_metrics = proxy_metrics,
-                proxy_logs = proxy_logs,
-                "OTLP proxy mode enabled. Select OTLP payloads will be proxied to the Core Agent."
-            );
-        } else {
-            info!("OTLP proxy mode disabled. OTLP signals will be handled natively.");
-        }
-
         Ok(Self {
             enabled,
             core_agent_otlp_grpc_endpoint,