Skip to content

Commit 1395a10

Browse files
zarirhamzazarirhamza
authored
Re-enable debugging snapshots (#5713)
1 parent d19cafd commit 1395a10

9 files changed

+129
-127
lines changed

‎manifests/java.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1868,7 +1868,9 @@ tests/:
18681868
uds-spring-boot: v1.38.0
18691869
test_debugger_exception_replay.py:
18701870
Test_Debugger_Exception_Replay:
1871-
'*': irrelevant # Temporarily disabled - updating approval snapshots
1871+
'*': missing_feature
1872+
spring-boot: v1.56.0-SNAPSHOT
1873+
uds-spring-boot: v1.56.0-SNAPSHOT
18721874
test_debugger_expression_language.py:
18731875
Test_Debugger_Expression_Language:
18741876
'*': missing_feature

‎tests/debugger/utils/approvals/java/1.5.0/exception_replay_async_snapshots_expected.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
"locals": {},
1212
"staticFields": {},
1313
"throwable": {
14+
"type": "org.springframework.web.server.ResponseStatusException",
1415
"message": "500 INTERNAL_SERVER_ERROR \"Async exception\"",
1516
"stacktrace": [
1617
{
@@ -20,8 +21,7 @@
2021
{
2122
"<runtime>": "<scrubbed>"
2223
}
23-
],
24-
"type": "org.springframework.web.server.ResponseStatusException"
24+
]
2525
}
2626
}
2727
},

‎tests/debugger/utils/approvals/java/1.5.0/exception_replay_inner_snapshots_expected.json‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"locals": {},
1717
"staticFields": {},
1818
"throwable": {
19+
"type": "org.springframework.web.server.ResponseStatusException",
1920
"message": "500 INTERNAL_SERVER_ERROR \"Outer exception\"; nested exception is org.springframework.web.server.ResponseStatusException: 500 INTERNAL_SERVER_ERROR \"Inner exception\"",
2021
"stacktrace": [
2122
{
@@ -24,13 +25,12 @@
2425
},
2526
{
2627
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
27-
"lineNumber": 51
28+
"lineNumber": 57
2829
},
2930
{
3031
"<runtime>": "<scrubbed>"
3132
}
32-
],
33-
"type": "org.springframework.web.server.ResponseStatusException"
33+
]
3434
}
3535
}
3636
},
@@ -53,7 +53,7 @@
5353
},
5454
{
5555
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
56-
"lineNumber": 51
56+
"lineNumber": 57
5757
},
5858
{
5959
"<runtime>": "<scrubbed>"

‎tests/debugger/utils/approvals/java/1.5.0/exception_replay_multiframe_snapshots_expected.json‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
"locals": {},
1717
"staticFields": {},
1818
"throwable": {
19+
"type": "org.springframework.web.server.ResponseStatusException",
1920
"message": "500 INTERNAL_SERVER_ERROR \"multiple stack frames exception\"",
2021
"stacktrace": [
2122
{
@@ -36,13 +37,12 @@
3637
},
3738
{
3839
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
39-
"lineNumber": 51
40+
"lineNumber": 57
4041
},
4142
{
4243
"<runtime>": "<scrubbed>"
4344
}
44-
],
45-
"type": "org.springframework.web.server.ResponseStatusException"
45+
]
4646
}
4747
}
4848
},
@@ -69,7 +69,7 @@
6969
},
7070
{
7171
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
72-
"lineNumber": 51
72+
"lineNumber": 57
7373
},
7474
{
7575
"<runtime>": "<scrubbed>"
@@ -94,6 +94,7 @@
9494
"locals": {},
9595
"staticFields": {},
9696
"throwable": {
97+
"type": "org.springframework.web.server.ResponseStatusException",
9798
"message": "500 INTERNAL_SERVER_ERROR \"multiple stack frames exception\"",
9899
"stacktrace": [
99100
{
@@ -114,13 +115,12 @@
114115
},
115116
{
116117
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
117-
"lineNumber": 51
118+
"lineNumber": 57
118119
},
119120
{
120121
"<runtime>": "<scrubbed>"
121122
}
122-
],
123-
"type": "org.springframework.web.server.ResponseStatusException"
123+
]
124124
}
125125
}
126126
},
@@ -151,7 +151,7 @@
151151
},
152152
{
153153
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
154-
"lineNumber": 51
154+
"lineNumber": 57
155155
},
156156
{
157157
"<runtime>": "<scrubbed>"
@@ -176,6 +176,7 @@
176176
"locals": {},
177177
"staticFields": {},
178178
"throwable": {
179+
"type": "org.springframework.web.server.ResponseStatusException",
179180
"message": "500 INTERNAL_SERVER_ERROR \"multiple stack frames exception\"",
180181
"stacktrace": [
181182
{
@@ -196,13 +197,12 @@
196197
},
197198
{
198199
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
199-
"lineNumber": 51
200+
"lineNumber": 57
200201
},
201202
{
202203
"<runtime>": "<scrubbed>"
203204
}
204-
],
205-
"type": "org.springframework.web.server.ResponseStatusException"
205+
]
206206
}
207207
}
208208
},
@@ -237,7 +237,7 @@
237237
},
238238
{
239239
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
240-
"lineNumber": 51
240+
"lineNumber": 57
241241
},
242242
{
243243
"<runtime>": "<scrubbed>"
@@ -262,6 +262,7 @@
262262
"locals": {},
263263
"staticFields": {},
264264
"throwable": {
265+
"type": "org.springframework.web.server.ResponseStatusException",
265266
"message": "500 INTERNAL_SERVER_ERROR \"multiple stack frames exception\"",
266267
"stacktrace": [
267268
{
@@ -282,13 +283,12 @@
282283
},
283284
{
284285
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
285-
"lineNumber": 51
286+
"lineNumber": 57
286287
},
287288
{
288289
"<runtime>": "<scrubbed>"
289290
}
290-
],
291-
"type": "org.springframework.web.server.ResponseStatusException"
291+
]
292292
}
293293
}
294294
},
@@ -311,7 +311,7 @@
311311
},
312312
{
313313
"function": "datadog.trace.instrumentation.springweb.HandlerMappingResourceNameFilter.doFilterInternal",
314-
"lineNumber": 51
314+
"lineNumber": 57
315315
},
316316
{
317317
"<runtime>": "<scrubbed>"

0 commit comments

Comments
 (0)