Skip to content

Commit 3925258

Browse files
authored
Remove auto increment of ruby version number for dev runs (#5799)
1 parent 856495b commit 3925258

File tree

3 files changed

+9
-37
lines changed

3 files changed

+9
-37
lines changed

tests/parametric/test_process_discovery.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,7 @@ def get_context_tracer_version():
5151
if context.library.name == "ruby":
5252
major = context.library.version.major
5353
minor = context.library.version.minor
54-
if "dev" in context.library.version.prerelease:
55-
patch = context.library.version.patch - 1
56-
else:
57-
patch = context.library.version.patch
54+
patch = context.library.version.patch
5855
return Version(f"{major}.{minor}.{patch}")
5956
elif context.library.name == "java":
6057
return Version(str(context.library.version).replace("+", "-"))

tests/test_the_test/test_version.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,23 @@ def test_version_comparizon():
3838

3939
def test_ruby_version():
4040
v = ComponentVersion("ruby", "0.53.0.appsec.180045")
41-
assert str(v.version) == "0.53.1-appsec+180045"
41+
assert str(v.version) == "0.53.0-appsec+180045"
4242

4343
v = ComponentVersion("ruby", "1.0.0.beta1 de82857")
44-
assert v.version == Version("1.0.1-beta1+de82857")
44+
assert v.version == Version("1.0.0-beta1+de82857")
4545

4646
v = ComponentVersion("ruby", "2.3.0 7dbcc40")
47-
assert str(v.version) == "2.3.1-z+7dbcc40"
47+
assert str(v.version) == "2.3.0+7dbcc40"
4848

49-
assert ComponentVersion("ruby", "1.0.0.beta1") == "ruby@1.0.1-z+beta1"
50-
assert ComponentVersion("ruby", "1.0.0.beta1 de82857") == "ruby@1.0.1-beta1+de82857"
49+
assert ComponentVersion("ruby", "1.0.0.beta1") == "ruby@1.0.0-beta1"
50+
assert ComponentVersion("ruby", "1.0.0.beta1 de82857") == "ruby@1.0.0-beta1+de82857"
5151

5252
# very particular use case, because we hack the path for dev versions
5353
assert ComponentVersion("ruby", "1.0.0.beta1 de82857") < "ruby@1.0.1"
5454
assert ComponentVersion("ruby", "1.0.0.rc1") < "ruby@1.0.1"
5555

56-
assert ComponentVersion("ruby", "2.3.0 7dbcc40") >= "ruby@2.3.1-dev"
56+
assert ComponentVersion("ruby", "2.3.0 7dbcc40") > "ruby@2.3.0-dev"
57+
assert ComponentVersion("ruby", "2.3.0") > "ruby@2.3.0-dev"
5758

5859

5960
def test_library_version_comparizon():

utils/_context/component_version.py

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def __init__(self, name: str, version: str = "0.0.0"):
8484
build = r"[a-f0-9]+"
8585
if re.match(rf"{base}[\. ]{prerelease}[\. ]{build}", version):
8686
version = re.sub(rf"({base})[\. ]({prerelease})[\. ]({build})", r"\1-\2+\3", version)
87-
elif re.match(rf"{base}[\. ]{build}", version):
87+
elif re.match(rf"{base} {build}", version):
8888
version = re.sub(rf"({base})[\. ]({build})", r"\1+\2", version)
8989
elif re.match(rf"{base}[\. ]{prerelease}", version):
9090
version = re.sub(rf"({base})[\. ]({prerelease})", r"\1-\2", version)
@@ -106,32 +106,6 @@ def __init__(self, name: str, version: str = "0.0.0"):
106106

107107
self.version = Version(version)
108108

109-
if name == "ruby":
110-
if len(self.version.build) != 0 or len(self.version.prerelease) != 0:
111-
# we are not in a released version
112-
113-
# dd-trace-rb main branch expose a version equal to the last release, so hack it:
114-
# * add 1 to minor version
115-
# * and set z as prerelease if not prerelease is set, because z will be after any other prerelease
116-
117-
# if dd-trace-rb repo fix the underlying issue, we can remove this hack.
118-
self.version = Version(
119-
major=self.version.major,
120-
minor=self.version.minor,
121-
patch=self.version.patch + 1,
122-
prerelease=self.version.prerelease,
123-
build=self.version.build,
124-
)
125-
126-
if not self.version.prerelease:
127-
self.version = Version(
128-
major=self.version.major,
129-
minor=self.version.minor,
130-
patch=self.version.patch,
131-
prerelease=("z",),
132-
build=self.version.build,
133-
)
134-
135109
self.add_known_version(self.version)
136110
else:
137111
self.version = Version("0.0.0")

0 commit comments

Comments
 (0)