Skip to content

Commit 7e329cf

Browse files
authored
Enable Test_TelemetryEnhancedConfigReporting for java (#5324)
1 parent f8d5b34 commit 7e329cf

19 files changed

+24
-5
lines changed

manifests/java.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2412,8 +2412,10 @@ tests/:
24122412
spring-boot-3-native: irrelevant (GraalVM. Tracing support only)
24132413
Test_Telemetry:
24142414
'*': v0.108.1
2415-
spring-boot-3-native: irrelevant (GraalVM. Tracing support only)
2416-
Test_TelemetryEnhancedConfigReporting: missing_feature
2415+
spring-boot-3-native: missing_feature (GraalVM. Tracing support only)
2416+
Test_TelemetryEnhancedConfigReporting:
2417+
'*': v1.54.0-SNAPSHOT
2418+
spring-boot-3-native: missing_feature (GraalVM. Tracing support only)
24172419
Test_TelemetrySCAEnvVar: missing_feature
24182420
Test_TelemetryV2: v1.23.0
24192421
test_v1_payloads.py: missing_feature

tests/test_telemetry.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,10 @@ class Test_TelemetryEnhancedConfigReporting:
612612
"name": "logs_injection_enabled",
613613
"precedence": [
614614
{"origin": "default", "value": "true"},
615-
{"origin": "jvm_prop", "value": "true"},
615+
{
616+
"origin": "jvm_prop",
617+
"value": "true",
618+
}, # File-based properties differ from sysprops, but still report with origin:jvm_prop, even though they have a lower precedence than env_var: https://github.com/DataDog/dd-trace-java/blob/5c66a150ff3b16ebf9626c0f0170fc9715461a6b/utils/config-utils/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java#L507-L514
616619
{"origin": "env_var", "value": "false"},
617620
],
618621
},

utils/_context/_scenarios/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ class _Scenarios:
128128
weblog_env={
129129
"DD_LOGS_INJECTION": "false",
130130
"CONFIG_CHAINING_TEST": "true",
131-
"DD_TRACE_CONFIG": "ConfigChaining.properties",
131+
"DD_TRACE_CONFIG": "/app/ConfigChaining.properties",
132132
},
133133
doc="Test telemetry for environment variable configurations",
134134
scenario_groups=[scenario_groups.telemetry],

utils/build/docker/java/spring-boot/ConfigChaining.properties renamed to utils/build/docker/java/ConfigChaining.properties

File renamed without changes.

utils/build/docker/java/akka-http.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ COPY --from=build /binaries/SYSTEM_TESTS_LIBRARY_VERSION SYSTEM_TESTS_LIBRARY_VE
2222
COPY --from=build /app/target/my-akka-http-app-1.0.0-allinone.jar /app/app.jar
2323
COPY --from=build /dd-tracer/dd-java-agent.jar .
2424

25+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
2526
COPY ./utils/build/docker/java/app.sh /app/app.sh
2627
RUN chmod +x /app/app.sh
2728

utils/build/docker/java/jersey-grizzly2.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ COPY --from=build /binaries/SYSTEM_TESTS_LIBRARY_VERSION SYSTEM_TESTS_LIBRARY_VE
2121
COPY --from=build /app/target/jersey-grizzly2-1.0-SNAPSHOT.jar /app/app.jar
2222
COPY --from=build /dd-tracer/dd-java-agent.jar .
2323

24+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
2425
COPY ./utils/build/docker/java/app.sh /app/app.sh
2526
RUN chmod +x /app/app.sh
2627

utils/build/docker/java/play.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ COPY --from=build /binaries/SYSTEM_TESTS_LIBRARY_VERSION SYSTEM_TESTS_LIBRARY_VE
2121
COPY --from=build /app/target/dist/play-app-1.0.0 .
2222
COPY --from=build /dd-tracer/dd-java-agent.jar .
2323

24+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
2425
COPY ./utils/build/docker/java/app-play.sh /app/app.sh
2526
RUN chmod +x /app/app.sh
2627

utils/build/docker/java/ratpack.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ COPY --from=build /binaries/SYSTEM_TESTS_LIBRARY_VERSION SYSTEM_TESTS_LIBRARY_VE
2121
COPY --from=build /app/target/ratpack-1.0-SNAPSHOT.jar /app/app.jar
2222
COPY --from=build /dd-tracer/dd-java-agent.jar .
2323

24+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
2425
COPY ./utils/build/docker/java/app.sh /app/app.sh
2526
RUN chmod +x /app/app.sh
2627

utils/build/docker/java/resteasy-netty3.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ COPY --from=build /binaries/SYSTEM_TESTS_LIBRARY_VERSION SYSTEM_TESTS_LIBRARY_VE
2222
COPY --from=build /app/target/resteasy-netty3-1.0-SNAPSHOT.jar /app/app.jar
2323
COPY --from=build /dd-tracer/dd-java-agent.jar .
2424

25+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
2526
COPY ./utils/build/docker/java/app.sh /app/app.sh
2627
RUN chmod +x /app/app.sh
2728

utils/build/docker/java/spring-boot-3-native.Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ COPY --from=build /app/without-profiling/myproject ./without-profiling/
2929
ENV DD_TRACE_HEADER_TAGS='user-agent:http.request.headers.user-agent'
3030
ENV DD_TRACE_INTERNAL_EXIT_ON_FAILURE=true
3131

32+
COPY ./utils/build/docker/java/ConfigChaining.properties /app/ConfigChaining.properties
3233
COPY ./utils/build/docker/java/app-native-profiling.sh app.sh
3334
RUN chmod +x app.sh
3435
CMD [ "/app/app.sh" ]

0 commit comments

Comments
 (0)