prevent incomplete MAC address from spamming logs (#1473)

brycekahle · web-flow · commit 3f9b993a44a5 · 2025-03-18T15:51:28.000Z
diff --git a/scenarios/aws/microVMs/microvms/network.go b/scenarios/aws/microVMs/microvms/network.go
@@ -259,6 +259,9 @@ func parseArpDhcpLeases() ([]dhcpLease, error) {
 			fmt.Printf("warning: error parsing arp line: %v\n", err)
 			continue
 		}
+		if lease.mac == "" {
+			continue
+		}
 
 		leases = append(leases, lease)
 	}
@@ -275,6 +278,10 @@ func parseArpLine(line string) (dhcpLease, error) {
 	}
 
 	ip := strings.Trim(parts[1], "()")
+	if parts[3] == "(incomplete)" {
+		return dhcpLease{}, nil
+	}
+
 	mac, err := normalizeMAC(parts[3])
 	if err != nil {
 		return dhcpLease{}, fmt.Errorf("error normalizing MAC address: %w", err)

Original file line number	Diff line number	Diff line change
`@@ -259,6 +259,9 @@ func parseArpDhcpLeases() ([]dhcpLease, error) {`
`259`	`259`	`fmt.Printf("warning: error parsing arp line: %v\n", err)`
`260`	`260`	`continue`
`261`	`261`	`}`
	`262`	`+ if lease.mac == "" {`
	`263`	`+ continue`
	`264`	`+ }`
`262`	`265`
`263`	`266`	`leases = append(leases, lease)`
`264`	`267`	`}`
`@@ -275,6 +278,10 @@ func parseArpLine(line string) (dhcpLease, error) {`
`275`	`278`	`}`
`276`	`279`
`277`	`280`	`ip := strings.Trim(parts[1], "()")`
	`281`	`+ if parts[3] == "(incomplete)" {`
	`282`	`+ return dhcpLease{}, nil`
	`283`	`+ }`
	`284`	`+`
`278`	`285`	`mac, err := normalizeMAC(parts[3])`
`279`	`286`	`if err != nil {`
`280`	`287`	`return dhcpLease{}, fmt.Errorf("error normalizing MAC address: %w", err)`