Update changelog for v0.3.8.3 and enhance function ownership SQL macro to fix argument signature handling

Author: jonhopper-dataengineers

CHANGELOG.md

@@ -1,6 +1,12 @@
 # Data Engineers Snowflake DataOps Utils Project Changelog
+This file contains the changelog for the Data Engineers Snowflake DataOps Utils project, detailing updates, fixes, and enhancements made to the project over time.
 
-## v0.3.8.2 2025-08-15 - Stored Procedure Grants Fix
+## v0.3.8.3 2025-07-30 - Grant Fixes
+
+* updated macro `get_grant_functions_ownership_sql` to fix issue with parameterless function signature not being returned correctly
+* added additional logging to `grant_object` macro to ensure that the correct parameters are being passed
+
+## v0.3.8.2 2025-07-15 - Grant Fixes
 
 * added additional logging to `grant_object` macro to ensure that the correct parameters are being passed
 

macros/grants/grant_object.sql

@@ -3,9 +3,10 @@
         {% set revoke_statements = [] %}
         {% set grant_statements = [] %}
         {% set existing_grants = [] %}
+        {% set execute_statements = [] %}
 
         {% for object in objects %}
-            {% do log("processing " ~ grant_types ~ " for " ~ object ~ " for " ~ grant_roles, info=True) %}
+            {% do log("====> Processing " ~ object_type ~ " for " ~ object, info=True) %}
             {% set query %}
                 show grants on {{ object_type }} {{ target.database }}.{{ object }};
             {% endset %}
@@ -40,18 +41,20 @@
             {%endif%}
         {%endfor%}
         {% for stm in revoke_statements %}
-            {% set grant_query %}
-                revoke {{ stm.privilege }} on {{ object_type }} {{ target.database }}.{{ stm.object }} from role {{ stm.role }};
-            {% endset %}
-            {% do log(grant_query, info=True) %}
-            {% set grant = run_query(grant_query) %}
+            {{ execute_statements.append("revoke " ~ stm.privilege ~ " on " ~ object_type ~ " " ~ target.database ~ "." ~ stm.object ~ " from role " ~ stm.role ~ ";") }}
         {% endfor %}
         {% for stm in grant_statements %}
-            {% set grant_query %}
-                grant {{ stm.privilege }} on {{ object_type }} {{ target.database }}.{{ stm.object }} to role {{ stm.role }};
-            {% endset %}
-            {% do log(grant_query, info=True) %}
-            {% set grant = run_query(grant_query) %}
+            {{ execute_statements.append("grant " ~ stm.privilege ~ " on " ~ object_type ~ " " ~ target.database ~ "." ~ stm.object ~ " to role " ~ stm.role ~ ";") }}
         {% endfor %}
+        {% if execute_statements | length > 0 %}
+            {% do log("Executing privilege grants and revokes for " ~ object_type ~"s...", info=True) %}
+            {% for statement in execute_statements %}
+                {% do log(statement, info=True) %}
+                {% set grant = run_query(statement) %}
+            {% endfor %}
+            {% do log("Privilege grants and revokes executed successfully for " ~ object_type ~ "s.", info=True) %}
+        {% else %}
+            {% do log("No privilege grants or revokes to execute for " ~ object_type ~ "s.", info=True) %}
+        {% endif %}
     {% endif %}
 {% endmacro %}

macros/grants/ownerships/get_grant_functions_ownership_sql.sql

@@ -4,7 +4,11 @@
             function_catalog,
             function_schema as schema_name,
             function_name,
-            listagg(trim(split_part(arg, ' ', -1)), ',') as argument_signature
+            regexp_replace(
+                listagg(trim(split_part(arg, ' ', -1)), ',') within group (order by arg),
+                '^,',
+                ''
+            ) as argument_signature
         from (
             select
                 function_catalog,
@@ -22,7 +26,6 @@
                 and function_schema in ({{ schema_list }})
             ),
             lateral flatten(input => args) as f
-			where trim(f.value) <> ''
         )
         group by function_catalog, function_schema, function_name;
     {% endset %}