Skip to content

Update players.sql #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update players.sql #128

wants to merge 2 commits into from

Conversation

guyr85
Copy link

@guyr85 guyr85 commented Nov 18, 2024

Adjust ddl, season_stats type and insert query to make the script work.

@guyr85
Update players.sql
8dbaaac 
Adjust ddl, season_stats type and insert query to make the script work.
@guyr85
Update players.sql
b55f033
anologicon
anologicon approved these changes Nov 20, 2024
View reviewed changes
Copy link

@anologicon anologicon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

ry-v1
ry-v1 requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@ry-v1 ry-v1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema changes doesnt align with pipeline_query.sql or load_players_table_day2.sql

EcZachly
EcZachly requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@EcZachly EcZachly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoke previous approval due to changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EcZachly EcZachly EcZachly requested changes

@ry-v1 ry-v1 ry-v1 requested changes

+2 more reviewers

@anologicon anologicon anologicon approved these changes

@Cellybelli Cellybelli Cellybelli approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guyr85 @EcZachly @anologicon @Cellybelli @ry-v1