Skip to content

Conversation

uditgt
Copy link

@uditgt uditgt commented Dec 20, 2024

Fixes issues with DatasetAPI notebook preventing it from executing. And using batch processing in Bucket-Join-In-Iceberg notebook to prevent OOM error.

Fixes issues with DatasetAPI notebook preventing it from executing. And using batch processing in Bucket-Join-In-Iceberg notebook to prevent OOM error.
Corrected 'current_year' filter in the query and cast it as BIGINT instead of INTEGER
Corrected schema and expected dataframe
@uditgt
Copy link
Author

uditgt commented Dec 20, 2024

pytest ran successfully on test_actors_scd

Added a step for creating a user and database in Postgres before loading data.
Copy link
Member

@EcZachly EcZachly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates in Notebook regarding DatasetAPI and batch processing improvements enhance the workbook's execution efficiency and prevent errors, like OOM.

Recommendation: Approve for Merge

Copy link
Member

@EcZachly EcZachly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoke previous approval due to changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants