Skip to content

Fixed season_stats and load query for day 2 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed season_stats and load query for day 2 #229

wants to merge 2 commits into from

Conversation

jsiddh1616
Copy link

No description provided.

ry-v1
ry-v1 requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@ry-v1 ry-v1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break "bootcamp/materials/1-dimensional-data-modeling/lecture-lab/pipeline_query.sql". Please modify load_players_table_day2.sql accordingly

@jsiddh1616
Copy link
Author

@ry-v1
Can we update "bootcamp/materials/1-dimensional-data-modeling/lecture-lab/pipeline_query.sql" instead to use gp as those metrics were used in the lab lecture?

@sanchezg7 sanchezg7 mentioned this pull request Jul 30, 2025
Closed
EcZachly
EcZachly approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@EcZachly EcZachly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments to the season_stats and load query are necessary for accurate data processing and validity within Lab 2 workflows. This update ensures correct operations.

Recommendation: Approve for Merge

EcZachly
EcZachly requested changes Aug 6, 2025
View reviewed changes
Copy link
Member

@EcZachly EcZachly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoke previous approval due to changes needed.

@isangwanrahul
Copy link
Contributor

code already corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EcZachly EcZachly EcZachly requested changes

@ry-v1 ry-v1 ry-v1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsiddh1616 @isangwanrahul @EcZachly @ry-v1