feat: MMD-1309 / Update from Substrate 3 to latest commit 852bab073407b65b5e3e461baaa0541c4e0bc3d6 dated 31st Aug (#223)

* update to Substrate commit 5e1aab8192cd84b653e023db5ee83abda856438c

* update to Substrate commit 670ca51e954182746fa3bf76214f2b1b560c1f90

* update to Substrate commit b7a1a2cda5c860f18a7802051e881c5062828042

* update to Substrate commit 852bab073407b65b5e3e461baaa0541c4e0bc3d6

* fix indentation

* rebuild Cargo.lock

* update rustc version

* remove old wasm

* generate chain spec, definitions, and wasm

* add uncles

* remove useless extension for light clients since it only supports Babe but we are using Aura now

Author: ltfschoen

.github/workflows/release.yml

@@ -18,16 +18,16 @@ jobs:
       - name: Add wasm toolchain
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2021-07-30
+          toolchain: nightly-2021-08-31
           target: wasm32-unknown-unknown
           override: true
 
       - name: Initialize environment and build
         run: |
           rustup update stable
-          rustup toolchain install nightly-2021-07-30
-          rustup default nightly-2021-07-30
-          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-07-30
+          rustup toolchain install nightly-2021-08-31
+          rustup default nightly-2021-08-31
+          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-08-31
           cargo build --release
 
       - name: Upload artifact

.github/workflows/test.yml

@@ -26,12 +26,12 @@ jobs:
       - name: Initialize WASM build environment
         run: |
           rustup update stable
-          rustup toolchain install nightly-2021-07-30
-          rustup default nightly-2021-07-30
-          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-07-30
+          rustup toolchain install nightly-2021-08-31
+          rustup default nightly-2021-08-31
+          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-08-31
 
       - name: Run cargo check
-        run: cargo +nightly-2021-07-30 check
+        run: cargo +nightly-2021-08-31 check
 
   test:
     name: Test Suite
@@ -56,46 +56,46 @@ jobs:
       - name: Initialize WASM build environment
         run: |
           rustup update stable
-          rustup toolchain install nightly-2021-07-30
-          rustup default nightly-2021-07-30
-          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-07-30
+          rustup toolchain install nightly-2021-08-31
+          rustup default nightly-2021-08-31
+          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-08-31
 
       # Runs integration tests in the runtime/tests folder
       - name: Run Integration Tests across all runtime modules
         run: |
-          cargo +nightly-2021-07-30 test -p datahighway-runtime
+          cargo +nightly-2021-08-31 test -p datahighway-runtime
 
       # Runs unit tests in each runtime module of the pallet folder
       - name: Run Unit Tests in each runtime module
         run: |
-          cargo +nightly-2021-07-30 test -p roaming-operators &&
-          cargo +nightly-2021-07-30 test -p roaming-networks &&
-          cargo +nightly-2021-07-30 test -p roaming-organizations &&
-          cargo +nightly-2021-07-30 test -p roaming-network-servers &&
-          cargo +nightly-2021-07-30 test -p roaming-devices &&
-          cargo +nightly-2021-07-30 test -p roaming-routing-profiles &&
-          cargo +nightly-2021-07-30 test -p roaming-service-profiles &&
-          cargo +nightly-2021-07-30 test -p roaming-accounting-policies &&
-          cargo +nightly-2021-07-30 test -p roaming-agreement-policies &&
-          cargo +nightly-2021-07-30 test -p roaming-network-profiles &&
-          cargo +nightly-2021-07-30 test -p roaming-device-profiles &&
-          cargo +nightly-2021-07-30 test -p roaming-sessions &&
-          cargo +nightly-2021-07-30 test -p roaming-billing-policies &&
-          cargo +nightly-2021-07-30 test -p roaming-charging-policies &&
-          cargo +nightly-2021-07-30 test -p roaming-packet-bundles &&
-          cargo +nightly-2021-07-30 test -p mining-setting-token &&
-          cargo +nightly-2021-07-30 test -p mining-setting-hardware &&
-          cargo +nightly-2021-07-30 test -p mining-rates-token &&
-          cargo +nightly-2021-07-30 test -p mining-rates-hardware &&
-          cargo +nightly-2021-07-30 test -p mining-sampling-token &&
-          cargo +nightly-2021-07-30 test -p mining-sampling-hardware &&
-          cargo +nightly-2021-07-30 test -p mining-eligibility-token &&
-          cargo +nightly-2021-07-30 test -p mining-eligibility-hardware &&
-          cargo +nightly-2021-07-30 test -p mining-eligibility-proxy &&
-          cargo +nightly-2021-07-30 test -p mining-claims-token &&
-          cargo +nightly-2021-07-30 test -p mining-claims-hardware &&
-          cargo +nightly-2021-07-30 test -p mining-execution-token &&
-          cargo +nightly-2021-07-30 test -p exchange-rate
+          cargo +nightly-2021-08-31 test -p roaming-operators &&
+          cargo +nightly-2021-08-31 test -p roaming-networks &&
+          cargo +nightly-2021-08-31 test -p roaming-organizations &&
+          cargo +nightly-2021-08-31 test -p roaming-network-servers &&
+          cargo +nightly-2021-08-31 test -p roaming-devices &&
+          cargo +nightly-2021-08-31 test -p roaming-routing-profiles &&
+          cargo +nightly-2021-08-31 test -p roaming-service-profiles &&
+          cargo +nightly-2021-08-31 test -p roaming-accounting-policies &&
+          cargo +nightly-2021-08-31 test -p roaming-agreement-policies &&
+          cargo +nightly-2021-08-31 test -p roaming-network-profiles &&
+          cargo +nightly-2021-08-31 test -p roaming-device-profiles &&
+          cargo +nightly-2021-08-31 test -p roaming-sessions &&
+          cargo +nightly-2021-08-31 test -p roaming-billing-policies &&
+          cargo +nightly-2021-08-31 test -p roaming-charging-policies &&
+          cargo +nightly-2021-08-31 test -p roaming-packet-bundles &&
+          cargo +nightly-2021-08-31 test -p mining-setting-token &&
+          cargo +nightly-2021-08-31 test -p mining-setting-hardware &&
+          cargo +nightly-2021-08-31 test -p mining-rates-token &&
+          cargo +nightly-2021-08-31 test -p mining-rates-hardware &&
+          cargo +nightly-2021-08-31 test -p mining-sampling-token &&
+          cargo +nightly-2021-08-31 test -p mining-sampling-hardware &&
+          cargo +nightly-2021-08-31 test -p mining-eligibility-token &&
+          cargo +nightly-2021-08-31 test -p mining-eligibility-hardware &&
+          cargo +nightly-2021-08-31 test -p mining-eligibility-proxy &&
+          cargo +nightly-2021-08-31 test -p mining-claims-token &&
+          cargo +nightly-2021-08-31 test -p mining-claims-hardware &&
+          cargo +nightly-2021-08-31 test -p mining-execution-token &&
+          cargo +nightly-2021-08-31 test -p exchange-rate
 
   lints:
     name: Lints
@@ -120,19 +120,19 @@ jobs:
           override: true
           components: rustfmt, clippy
 
-      # nightly-2021-07-30-x86_64-unknown-linux-gnu
+      # nightly-2021-08-31-x86_64-unknown-linux-gnu
       - name: Initialize WASM build environment
         run: |
           rustup update stable
-          rustup toolchain install nightly-2021-07-30
-          rustup default nightly-2021-07-30
-          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-07-30
+          rustup toolchain install nightly-2021-08-31
+          rustup default nightly-2021-08-31
+          rustup target add wasm32-unknown-unknown --toolchain nightly-2021-08-31
 
       # Ignore use of Rust Linting since rearranging makes it challenging to update to latest Substrate
       # - name: Run cargo fmt
       #   run: |
-      #     rustup component add rustfmt --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
-      #     cargo +nightly-2021-07-30 fmt --all -- --check
+      #     rustup component add rustfmt --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
+      #     cargo +nightly-2021-08-31 fmt --all -- --check
 
       # Ignore use of Clippy until a clippy.toml file may be used. See README.md
       # - name: Run cargo clippy
@@ -142,6 +142,6 @@ jobs:
       #   #   args:  --release -- -D warnings
       #   # FIXME - temporary fix below. See https://github.com/rust-lang/rust-clippy/issues/5094#issuecomment-579116431
       #   run: |
-      #     rustup component add clippy --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
-      #     rustup component add clippy-preview --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
-      #     cargo +nightly-2021-07-30 clippy-preview -Zunstable-options
+      #     rustup component add clippy --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
+      #     rustup component add clippy-preview --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
+      #     cargo +nightly-2021-08-31 clippy-preview -Zunstable-options

CONTRIBUTING.md

@@ -22,7 +22,7 @@ To skip running the CI unnecessarily for simple changes such as updating the doc
 
 ### Linting
 
-Check with Rust Format. Note: If you need a specific version of it replace `+nightly` with say `+nightly-2021-07-30`
+Check with Rust Format. Note: If you need a specific version of it replace `+nightly` with say `+nightly-2021-08-31`
 ```
 cargo +nightly fmt --all -- --check
 ```
@@ -148,9 +148,9 @@ cargo clippy --release -- -D warnings
 The following is a temporary fix. See https://github.com/rust-lang/rust-clippy/issues/5094#issuecomment-579116431
 
 ```
-rustup component add clippy --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
-rustup component add clippy-preview --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
-cargo +nightly-2021-07-30 clippy-preview -Zunstable-options
+rustup component add clippy --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
+rustup component add clippy-preview --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
+cargo +nightly-2021-08-31 clippy-preview -Zunstable-options
 ```
 
 #### Clippy and Continuous Integration (CI)
@@ -176,7 +176,7 @@ The styles are defined in the rustfmt.toml configuration file, which was generat
 #### Install RustFmt
 
 ```bash
-rustup component add rustfmt --toolchain nightly-2021-07-30-x86_64-unknown-linux-gnu
+rustup component add rustfmt --toolchain nightly-2021-08-31-x86_64-unknown-linux-gnu
 ```
 
 #### Check Formating Changes that RustFmt before applying them
@@ -221,7 +221,7 @@ substrate-module-new <module-name> <author>
 	so we must manually change this to the latest Rust Nightly version only
 	when it is known to work.
 		```bash
-		rustup toolchain install nightly-2021-07-30
+		rustup toolchain install nightly-2021-08-31
 		rustup update stable
 		rustup target add wasm32-unknown-unknown --toolchain nightly
 		```
@@ -231,7 +231,7 @@ substrate-module-new <module-name> <author>
 	and because developers may forget to update to the latest version of Rust
 	Nightly locally. So the solution is to install a specific version of
 	Rust Nightly in .github/workflows/rust.yml (i.e.
-	`rustup toolchain install nightly-2021-07-30`), since for example
+	`rustup toolchain install nightly-2021-08-31`), since for example
 	the latest Rust Nightly version nightly-2020-02-20 may cause our CI tests
 	to fail (i.e. https://github.com/DataHighway-DHX/node/issues/32)
 
@@ -330,7 +330,7 @@ pub trait Config: frame_system::Config {
 * Question: When using Docker you get error: `FileNotFoundError: [Errno 2] No such file or directory: '/Users/ls/code/src/DataHighway-com/node/target/rls/debug/deps/save-analysis/libsc_executor_common-f236f3ddcd6862b3.json'`
     * Answer: Try run `rm -rf ./target/rls/debug` a few times until it no longer says `Directory not empty`
 
-* Quesion: If I am using an Apple ARM (M1) processor instead of an Apple Intel processor, it gives warnings like `warning: toolchain 'nightly-2021-07-30-x86_64-unknown-linux-gnu' may not be able to run on this system.` and you are unable to install it with `x86_64-unknown-linux-gnu`, what may I need to do?
+* Quesion: If I am using an Apple ARM (M1) processor instead of an Apple Intel processor, it gives warnings like `warning: toolchain 'nightly-2021-08-31-x86_64-unknown-linux-gnu' may not be able to run on this system.` and you are unable to install it with `x86_64-unknown-linux-gnu`, what may I need to do?
     * Answer: Try using `aarch64-apple-darwin` instead, e.g.
 ```
 softwareupdate --install-rosetta
@@ -340,16 +340,16 @@ echo 'eval "$(/opt/homebrew/bin/brew shellenv)"' >> /Users/ls2/.profile
 eval "$(/opt/homebrew/bin/brew shellenv)"
 brew update
 
-rustup toolchain install nightly-2021-07-30-aarch64-apple-darwin
-rustup component add rustfmt --toolchain nightly-2021-07-30-aarch64-apple-darwin
-cargo +nightly-2021-07-30-aarch64-apple-darwin fmt --all -- --check
+rustup toolchain install nightly-2021-08-31-aarch64-apple-darwin
+rustup component add rustfmt --toolchain nightly-2021-08-31-aarch64-apple-darwin
+cargo +nightly-2021-08-31-aarch64-apple-darwin fmt --all -- --check
 ```
 
 * Question: Why do I get an error `1002: Verification Error: Execution: Could not convert parameter 'tx' between node and runtime: Error decoding field Call:: MiningEligibilityProxy.0 RuntimeApi` when in polkadot.js.apps when I try to 'Add Item' with data to a Vec?
     * Ans: Because there is a type mismatch, perhaps the first variable requires a `Balance` instead of `u32` in custom_types.json or similar.
 
 * Question: How to debug when running tests?
-    * Ans: Run tests with this `SKIP_WASM_BUILD=1 RUST_LOG=runtime=debug` in front, i.e. `SKIP_WASM_BUILD=1 RUST_LOG=runtime=debug cargo +nightly-2021-07-30 test -p datahighway-runtime`, and use `println!` where you want to log the output (i.e. `println!("claim duration {:#?}", claim_duration);`), as `debug::info!` not work in tests. Try using `info!` (have not tried yet)
+    * Ans: Run tests with this `SKIP_WASM_BUILD=1 RUST_LOG=runtime=debug` in front, i.e. `SKIP_WASM_BUILD=1 RUST_LOG=runtime=debug cargo +nightly-2021-08-31 test -p datahighway-runtime`, and use `println!` where you want to log the output (i.e. `println!("claim duration {:#?}", claim_duration);`), as `debug::info!` not work in tests. Try using `info!` (have not tried yet)
 
 * Question: Why can't I connect my node to telemetry?
     * Ans: Try use these flags when running your node `--telemetry-url 'wss://telemetry.polkadot.io/submit/ 0' --unsafe-ws-external --unsafe-rpc-external --rpc-cors=all --rpc-methods=Unsafe`