Add shared dimensions check for derived metrics to bulk validation (#1943)

* Add dimensions check for derived metrics

Bump version to v0.0.111 (#1944)

Add impact preview for any deployment

Clean up

Clean up

Add impact checks

Add tests

Refactor seed bfs stage

Refactor BFS propagation per level

Remove single node impact, fix tests

Refactor by cleaning up initial diff component

Add test coverage, refactor dim link validation to be cleaner

Remove logger.info debug calls, fix unit tests, add timing metric to analyze_deployment_impact

Fix

Fix

Latest fixes

Switch to using single validation setup

Fix deployment impact test

Reuse diff col map

Reuse diff col map

Add check for required dimensions changes

Add better display of header and outputs

unify dry-run and real run validation

Make sure dry and wet runs are in sync from the same orchestration logic

Reveal errors from deployment

Remove unused impact

Fix

Fix lint

Fix

Fix tests

Fix

Fix tests

Catch discrepancies between YAML changes and displayed output

Output all downstream impacts

Display impacts in cli

Fix remaining

When dimension nodes lose columns, we should validate that no nodes that linked to that dimension or cubes that use that dimension are broken

When metrics are broken, that should propagate down to the downstream cubes

Add edge case test coverage

Fix lint

Fix tests

Fix

Author: shangyian

datajunction-clients/python/datajunction/cli.py

@@ -15,225 +15,13 @@
 from rich.text import Text
 
 from datajunction import DJBuilder, Project
-from datajunction.deployment import DeploymentService
+from datajunction.deployment import DeploymentService, display_impact_analysis
 from datajunction.exceptions import DJClientException, DJDeploymentFailure
 
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
 
-def display_impact_analysis(impact: dict, console: Console | None = None) -> None:
-    """
-    Display deployment impact analysis with rich formatting.
-
-    Args:
-        impact: The impact analysis response from the server
-        console: Optional Rich console for output
-    """
-    console = console or Console()
-    namespace = impact.get("namespace", "unknown")
-
-    # Header
-    console.print()
-    console.print(
-        f"[bold blue]📊 Impact Analysis for namespace:[/bold blue] [bold green]{namespace}[/bold green]",
-    )
-    console.print("━" * 60)
-    console.print()
-
-    # Direct Changes Table
-    changes = impact.get("changes", [])
-    if changes:
-        changes_table = Table(
-            title="[bold]📝 Direct Changes[/bold]",
-            box=box.ROUNDED,
-            show_header=True,
-            header_style="bold cyan",
-        )
-        changes_table.add_column("Operation", style="bold", width=10)
-        changes_table.add_column("Node", style="magenta")
-        changes_table.add_column("Type", style="dim", width=12)
-        changes_table.add_column("Changed Fields", style="white")
-
-        operation_styles = {
-            "create": ("🟢 Create", "green"),
-            "update": ("🟡 Update", "yellow"),
-            "delete": ("🔴 Delete", "red"),
-            "noop": ("⚪ Skip", "dim"),
-        }
-
-        for change in changes:
-            op = change.get("operation", "unknown")
-            op_display, op_color = operation_styles.get(op, (op.upper(), "white"))
-            changed_fields = ", ".join(change.get("changed_fields", [])) or "-"
-            changes_table.add_row(
-                f"[{op_color}]{op_display}[/{op_color}]",
-                change.get("name", ""),
-                change.get("node_type", ""),
-                changed_fields,
-            )
-
-        console.print(changes_table)
-        console.print()
-
-    # Summary for direct changes
-    create_count = impact.get("create_count", 0)
-    update_count = impact.get("update_count", 0)
-    delete_count = impact.get("delete_count", 0)
-    skip_count = impact.get("skip_count", 0)
-
-    summary_parts = []
-    if create_count:
-        summary_parts.append(
-            f"[green]{create_count} create{'s' if create_count != 1 else ''}[/green]",
-        )
-    if update_count:
-        summary_parts.append(
-            f"[yellow]{update_count} update{'s' if update_count != 1 else ''}[/yellow]",
-        )
-    if delete_count:
-        summary_parts.append(
-            f"[red]{delete_count} delete{'s' if delete_count != 1 else ''}[/red]",
-        )
-    if skip_count:
-        summary_parts.append(f"[dim]{skip_count} skipped[/dim]")
-
-    if summary_parts:
-        console.print(f"[bold]Summary:[/bold] {', '.join(summary_parts)}")
-        console.print()
-
-    # Column Changes (if any)
-    column_changes_found = []
-    for change in changes:
-        for col_change in change.get("column_changes", []):
-            column_changes_found.append(
-                {
-                    "node": change.get("name"),
-                    **col_change,
-                },
-            )
-
-    if column_changes_found:
-        col_table = Table(
-            title="[bold]⚡ Column Changes[/bold]",
-            box=box.ROUNDED,
-            show_header=True,
-            header_style="bold cyan",
-        )
-        col_table.add_column("Node", style="magenta")
-        col_table.add_column("Change", style="bold", width=10)
-        col_table.add_column("Details", style="white")
-
-        change_type_styles = {
-            "added": ("🟢 Added", "green"),
-            "removed": ("🔴 Removed", "red"),
-            "type_changed": ("🟡 Type Changed", "yellow"),
-        }
-
-        for col in column_changes_found:
-            change_type = col.get("change_type", "unknown")
-            display, color = change_type_styles.get(
-                change_type,
-                (change_type.upper(), "white"),
-            )
-
-            if change_type == "type_changed":
-                details = f"'{col.get('column')}': {col.get('old_type')} → {col.get('new_type')}"
-            elif change_type == "removed":
-                details = f"Column '{col.get('column')}' removed"
-            else:
-                details = f"Column '{col.get('column')}' added"
-
-            col_table.add_row(
-                col.get("node", ""),
-                f"[{color}]{display}[/{color}]",
-                details,
-            )
-
-        console.print(col_table)
-        console.print()
-
-    # Downstream Impact
-    downstream_impacts = impact.get("downstream_impacts", [])
-    if downstream_impacts:
-        impact_table = Table(
-            title="[bold]🔗 Downstream Impact[/bold]",
-            box=box.ROUNDED,
-            show_header=True,
-            header_style="bold cyan",
-        )
-        impact_table.add_column("Node", style="magenta")
-        impact_table.add_column("Impact", style="bold", width=18)
-        impact_table.add_column("Reason", style="white")
-
-        impact_styles = {
-            "will_invalidate": ("❌ Will Invalidate", "bold red"),
-            "may_affect": ("⚠️  May Affect", "yellow"),
-            "unchanged": ("✓ Unchanged", "dim"),
-        }
-
-        for downstream in downstream_impacts:
-            impact_type = downstream.get("impact_type", "unknown")
-            display, style = impact_styles.get(
-                impact_type,
-                (impact_type.upper(), "white"),
-            )
-            impact_table.add_row(
-                downstream.get("name", ""),
-                f"[{style}]{display}[/{style}]",
-                downstream.get("impact_reason", ""),
-            )
-
-        console.print(impact_table)
-        console.print()
-
-        # Downstream summary
-        will_invalidate = impact.get("will_invalidate_count", 0)
-        may_affect = impact.get("may_affect_count", 0)
-
-        impact_summary = []
-        if will_invalidate:
-            impact_summary.append(f"[red]{will_invalidate} will invalidate[/red]")
-        if may_affect:
-            impact_summary.append(f"[yellow]{may_affect} may be affected[/yellow]")
-
-        if impact_summary:
-            console.print(
-                f"[bold]Downstream Summary:[/bold] {', '.join(impact_summary)}",
-            )
-            console.print()
-    else:
-        console.print("[green]✅ No downstream impact detected.[/green]")
-        console.print()
-
-    # Warnings
-    warnings = impact.get("warnings", [])
-    if warnings:
-        console.print("[bold red]⚠️  Warnings:[/bold red]")
-        for warning in warnings:
-            console.print(f"  [yellow]• {warning}[/yellow]")
-        console.print()
-    else:
-        console.print("[green]✅ No warnings.[/green]")
-        console.print()
-
-    # Final verdict
-    has_issues = (
-        impact.get("will_invalidate_count", 0) > 0
-        or len(warnings) > 0
-        or delete_count > 0
-    )
-
-    if has_issues:
-        console.print(
-            "[yellow bold]⚠️  Review the warnings and downstream impacts before deploying.[/yellow bold]",
-        )
-    else:
-        console.print("[green bold]✅ Ready to deploy![/green bold]")
-
-    console.print()
-
-
 class DJCLI:
     """DJ command-line tool"""
 
@@ -281,14 +69,24 @@ def dryrun(
         console = Console()
 
         try:
-            impact = self.deployment_service.get_impact(directory, namespace=namespace)
+            with console.status(
+                "[dim]Analyzing deployment impact...[/dim]",
+                spinner="dots",
+            ):
+                impact = self.deployment_service.get_impact(
+                    directory,
+                    namespace=namespace,
+                )
 
             if format == "json":
                 print(json.dumps(impact, indent=2))
             else:
-                console.print(f"[bold]Analyzing deployment from:[/bold] {directory}")
-                console.print()
-                display_impact_analysis(impact, console=console)
+                display_impact_analysis(
+                    impact,
+                    console=console,
+                    server_url=self.builder_client.uri,
+                    source=DeploymentService._build_deployment_source(cwd=directory),
+                )
         except DJClientException as exc:
             error_data = exc.args[0] if exc.args else str(exc)
             message = (
@@ -1357,8 +1155,7 @@ def dispatch_command(self, args, parser):
                 return
             try:
                 self.push(args.directory, verbose=args.verbose, force=args.force)
-            except DJDeploymentFailure as exc:
-                logger.error("Deployment failed: %s", exc)
+            except DJDeploymentFailure:
                 raise SystemExit(1)
         elif args.command == "push":
             # Handle dry run first
@@ -1387,8 +1184,7 @@ def dispatch_command(self, args, parser):
                     verbose=args.verbose,
                     force=args.force,
                 )
-            except DJDeploymentFailure as exc:
-                logger.error("Deployment failed: %s", exc)
+            except DJDeploymentFailure:
                 raise SystemExit(1)
         elif args.command == "generate-codeowners":
             count = DeploymentService.build_codeowners(
@@ -1649,7 +1445,7 @@ def _setup_mcp_server(self, console: Console):
 
         if not config_path:
             console.print(
-                "\n[yellow]⚠️  Could not find Claude config directory[/yellow]",
+                "\n[yellow]▲ Could not find Claude config directory[/yellow]",
             )
             console.print(
                 "[dim]Skipping MCP setup. You can manually add DJ MCP to your Claude config.[/dim]",
@@ -1662,7 +1458,7 @@ def _setup_mcp_server(self, console: Console):
         # Find dj-mcp command
         dj_mcp_path = shutil.which("dj-mcp")
         if not dj_mcp_path:
-            console.print("[yellow]⚠️  dj-mcp command not found in PATH[/yellow]")
+            console.print("[yellow]▲ dj-mcp command not found in PATH[/yellow]")
             console.print(
                 "[dim]Make sure datajunction client is installed with MCP extras:[/dim]",
             )
@@ -1680,7 +1476,7 @@ def _setup_mcp_server(self, console: Console):
                     config = json.load(f)
             except json.JSONDecodeError:
                 console.print(
-                    "[yellow]⚠️  Invalid JSON in Claude config, creating backup[/yellow]",
+                    "[yellow]▲ Invalid JSON in Claude config, creating backup[/yellow]",
                 )
                 backup_path = config_path.with_suffix(".json.backup")
                 shutil.copy(config_path, backup_path)
@@ -1716,7 +1512,7 @@ def _setup_mcp_server(self, console: Console):
         console.print("  [dim]DJ_USERNAME: dj[/dim]")
         console.print("  [dim]DJ_PASSWORD: *** (default)[/dim]\n")
         console.print(
-            "[bold yellow]⚠️  Restart Claude Desktop/Code to load the MCP server[/bold yellow]",
+            "[bold yellow]▲ Restart Claude Desktop/Code to load the MCP server[/bold yellow]",
         )
 
     def seed(self, type: str = "nodes"):