Skip to content

Commit e7806e0

Browse files
committed
Add display name to cube
1 parent ae99464 commit e7806e0

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

datajunction-server/datajunction_server/internal/cube_materializations.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ async def build_cube_materialization(
262262
cube=NodeNameVersion(
263263
name=current_revision.name,
264264
version=current_revision.version,
265+
display_name=current_revision.display_name,
265266
),
266267
metrics=[
267268
CubeMetric(

datajunction-server/tests/api/cubes_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2213,7 +2213,7 @@ async def test_cube_materialization_metadata(
22132213
assert results["cube"] == {
22142214
"name": "default.example_repairs_cube",
22152215
"version": "v1.0",
2216-
"display_name": None,
2216+
"display_name": "Example Repairs Cube",
22172217
}
22182218
assert results["job"] == "DRUID_CUBE"
22192219
assert results["lookback_window"] == "1 DAY"

datajunction-server/tests/api/materializations_test.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -803,6 +803,7 @@ async def test_druid_cube_incremental(
803803
assert mat.cube == NodeNameVersion(
804804
name="default.repairs_cube__default_incremental",
805805
version="v1.0",
806+
display_name="Repairs Cube Default Incremental",
806807
)
807808
assert mat.dimensions == [
808809
"default.repair_orders_fact.order_date",

0 commit comments

Comments
 (0)