Merge branch 'aarthy/fix-queries' into 'enterprise'

QA fixes

See merge request dkinternal/testgen/dataops-testgen!289

Author: ci bot

testgen/commands/run_generate_tests.py

@@ -4,11 +4,13 @@
 from testgen.commands.queries.generate_tests_query import CDeriveTestsSQL
 from testgen.common import execute_db_queries, fetch_dict_from_db, get_test_generation_params, set_target_db_params
 from testgen.common.mixpanel_service import MixpanelService
+from testgen.common.models import with_database_session
 from testgen.common.models.connection import Connection
 
 LOG = logging.getLogger("testgen")
 
 
+@with_database_session
 def run_test_gen_queries(table_group_id: str, test_suite: str, generation_set: str | None = None):
     if table_group_id is None:
         raise ValueError("Table Group ID was not specified")

testgen/commands/run_profiling_bridge.py

@@ -216,7 +216,7 @@ def run_profiling_in_background(table_group_id):
         background_thread.start()
     else:
         LOG.info(msg)
-        script = ["testgen", "run-profile", "-tg", table_group_id]
+        script = ["testgen", "run-profile", "-tg", str(table_group_id)]
         subprocess.Popen(script)  # NOQA S603
 
 

testgen/common/database/flavor/redshift_flavor_service.py

@@ -15,8 +15,3 @@ def get_connection_string_head(self):
     def get_connection_string_from_fields(self):
         # STANDARD FORMAT:  strConnect = 'flavor://username:password@host:port/database'
         return f"{self.flavor}://{self.username}:{quote_plus(self.password)}@{self.host}:{self.port}/{self.dbname}"
-
-    def get_pre_connection_queries(self):
-        return [
-            ("SET SEARCH_PATH = :schema", {"schema": self.dbschema}),
-        ]

testgen/common/models/profiling_run.py

@@ -99,7 +99,7 @@ def get_minimal(cls, run_id: str | UUID) -> ProfilingRunMinimal | None:
             select(cls._minimal_columns).join(TableGroup, cls.table_groups_id == TableGroup.id).where(cls.id == run_id)
         )
         result = get_current_session().execute(query).first()
-        return ProfilingRunMinimal(**result)
+        return ProfilingRunMinimal(**result) if result else None
 
     @classmethod
     def get_latest_run(cls, project_code: str) -> LatestProfilingRun | None:

testgen/common/models/project.py

@@ -38,7 +38,7 @@ class Project(Entity):
 
     @classmethod
     @st.cache_data(show_spinner=False)
-    def get_summary(cls, project_code: str) -> ProjectSummary:
+    def get_summary(cls, project_code: str) -> ProjectSummary | None:
         query = """
         SELECT
             (
@@ -81,7 +81,7 @@ def get_summary(cls, project_code: str) -> ProjectSummary:
 
         db_session = get_current_session()
         result = db_session.execute(text(query), {"project_code": project_code}).first()
-        return ProjectSummary(**result, project_code=project_code)
+        return ProjectSummary(**result, project_code=project_code) if result else None
 
     @classmethod
     def is_in_use(cls, ids: list[str]) -> bool:

testgen/common/models/test_run.py

@@ -100,7 +100,7 @@ def get_minimal(cls, run_id: str | UUID) -> TestRunMinimal | None:
 
         query = select(cls._minimal_columns).join(TestSuite).where(cls.id == run_id)
         result = get_current_session().execute(query).first()
-        return TestRunMinimal(**result)
+        return TestRunMinimal(**result) if result else None
 
     @classmethod
     def get_latest_run(cls, project_code: str) -> LatestTestRun | None:

testgen/ui/components/frontend/js/display_utils.js

@@ -30,11 +30,13 @@ function formatDuration(/** @type string */ duration) {
     return formatted.trim() || '< 1s';
 }
 
-function formatNumber(/** @type number | string */ number, /** @type number */ precision = 3) {
+function formatNumber(/** @type number | string */ number, /** @type number */ decimals = 3) {
     if (!['number', 'string'].includes(typeof number) || isNaN(number)) {
         return '--';
     }
-    return parseFloat(Number(number).toPrecision(precision)).toLocaleString();
+    // toFixed - rounds to specified number of decimal places
+    // toLocaleString - adds commas as necessary
+    return parseFloat(Number(number).toFixed(decimals)).toLocaleString();
 }
 
 function capitalize(/** @type string */ text) {

testgen/ui/queries/source_data_queries.py

@@ -192,7 +192,7 @@ def _get_lookup_data(
     table_group_id: str,
     anomaly_id: str,
     error_type: Literal["Profile Anomaly", "Test Results"],
-) -> LookupData:
+) -> LookupData | None:
     result = fetch_one_from_db(
         """
         SELECT
@@ -214,12 +214,12 @@ def _get_lookup_data(
             "anomaly_id": anomaly_id,
         },
     )
-    return LookupData(**result)
+    return LookupData(**result) if result else None
 
 
 def _get_lookup_data_custom(
     test_definition_id: str,
-) -> LookupData:
+) -> LookupData | None:
     result = fetch_one_from_db(
         """
         SELECT 
@@ -229,4 +229,4 @@ def _get_lookup_data_custom(
         """,
         {"test_definition_id": test_definition_id},
     )
-    return LookupData(**result)
+    return LookupData(**result) if result else None