[fix] role menu update issue (#4492)

Author: liunaijie

dinky-admin/src/main/java/org/dinky/service/impl/RoleMenuServiceImpl.java

@@ -28,8 +28,10 @@
 import org.dinky.service.RoleMenuService;
 
 import java.util.List;
+import java.util.stream.Collectors;
 
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
 
@@ -38,36 +40,28 @@
 @Service
 public class RoleMenuServiceImpl extends SuperServiceImpl<RoleMenuMapper, RoleMenu> implements RoleMenuService {
     @Override
+    @Transactional(rollbackFor = Exception.class)
     public Result<Void> assignMenuToRole(AssignMenuToRoleDTO assignMenuToRoleDto) {
 
         if (CollUtil.isEmpty(assignMenuToRoleDto.getMenuIds())) {
             return Result.failed(Status.SELECT_MENU);
         }
-
-        int insertSize = 0;
         // 先删除原有的关系
-        List<RoleMenu> roleMenus = getBaseMapper()
-                .selectList(
-                        new LambdaQueryWrapper<RoleMenu>().eq(RoleMenu::getRoleId, assignMenuToRoleDto.getRoleId()));
-
-        // if not empty , delete all role menus
-        if (CollUtil.isNotEmpty(roleMenus)) {
-            roleMenus.forEach(rm -> {
-                getBaseMapper().delete(new LambdaQueryWrapper<RoleMenu>().eq(RoleMenu::getMenuId, rm.getMenuId()));
-            });
-        }
-
-        // then insert new role menus
-        for (Integer id : assignMenuToRoleDto.getMenuIds()) {
-            RoleMenu roleMenu = new RoleMenu();
-            roleMenu.setRoleId(assignMenuToRoleDto.getRoleId());
-            roleMenu.setMenuId(id);
-            insertSize += getBaseMapper().insert(roleMenu);
-        }
-
-        if (assignMenuToRoleDto.getMenuIds().size() == insertSize) {
+        getBaseMapper()
+                .delete(new LambdaQueryWrapper<RoleMenu>().eq(RoleMenu::getRoleId, assignMenuToRoleDto.getRoleId()));
+        List<RoleMenu> newRoles = assignMenuToRoleDto.getMenuIds().stream()
+                .map(menuId -> {
+                    RoleMenu roleMenu = new RoleMenu();
+                    roleMenu.setRoleId(assignMenuToRoleDto.getRoleId());
+                    roleMenu.setMenuId(menuId);
+                    return roleMenu;
+                })
+                .collect(Collectors.toList());
+        boolean res = saveBatch(newRoles);
+        if (res) {
             return Result.succeed(Status.ASSIGN_MENU_SUCCESS);
+        } else {
+            return Result.failed(Status.ASSIGN_MENU_FAILED);
         }
-        return Result.failed(Status.ASSIGN_MENU_FAILED);
     }
 }