Fix HTTP return code for 404 and 500 returns

Author: rogerdahl

gmn/src/d1_gmn/app/views/internal.py

@@ -83,7 +83,7 @@ def error_404(request, exception):
   Note: Cannot raise NotFound() here, as this method is not covered by the GMN
   middleware handler that catches DataONE exceptions raised by normal views.
   """
-  return django.http.HttpResponse(
+  return django.http.HttpResponseNotFound(
     d1_common.types.exceptions.NotFound(
       0,
       'Invalid API endpoint',
@@ -96,7 +96,7 @@ def error_404(request, exception):
 
 
 def error_500(request):
-  return django.http.HttpResponse(
+  return django.http.HttpResponseServerError(
     d1_common.types.exceptions.ServiceFailure(
       0,
       'Internal error',

lib_common/src/d1_common/tests/test_wrap_simple_xml.py

@@ -152,8 +152,8 @@ def test_1120(self):
       xml.replace_by_etree(new_replication_policy_el)
       assert len(xml.get_element_list_by_name('preferredMemberNode')) == 1
       assert len(xml.get_element_list_by_name('blockedMemberNode')) == 1
-      assert xml.get_element('replicationPolicy').attrib['a'] == 'b'
-      assert xml.get_element('replicationPolicy').attrib['c'] == 'd'
+      assert xml.get_element_by_name('replicationPolicy').attrib['a'] == 'b'
+      assert xml.get_element_by_name('replicationPolicy').attrib['c'] == 'd'
       d1_test.sample.assert_equals(xml.get_xml(), 'replace_by_etree')
 
   def test_1130(self):