Fix misleading error message

Author: rogerdahl

gmn/src/d1_gmn/app/did.py

@@ -59,6 +59,12 @@ def is_valid_pid_for_create(did):
   )
 
 
+def is_valid_sid_for_new_standalone(did):
+  """Return True if {did} can be assigned to a new standalone object
+  """
+  return _is_unused_did(did)
+
+
 def is_valid_pid_to_be_updated(did):
   """Return True if {did} is the PID of an object that can be updated
   (obsoleted) with MNStorage.update()
@@ -69,12 +75,6 @@ def is_valid_pid_to_be_updated(did):
   )
 
 
-def is_valid_sid_for_new_standalone(did):
-  """Return True if {did} can be assigned to a new standalone object
-  """
-  return _is_unused_did(did)
-
-
 def is_valid_sid_for_chain(pid, sid):
   """Return True if {sid} can be assigned to the single object {pid} or to the
   chain to which {pid} belongs.
@@ -148,6 +148,12 @@ def classify_identifier(did):
     return 'a Series ID (SID) of a revision chain'
   elif is_local_replica(did):
     return 'a Persistent ID (PID) of a local replica'
+  elif is_unprocessed_local_replica(did):
+    return 'a Persistent ID (PID) of an accepted but not yet processed local replica'
+  elif is_archived(did):
+    return 'a Persistent ID (PID) of a previously archived local object'
+  elif is_obsoleted(did):
+    return 'a Persistent ID (PID) of a previously updated (obsoleted) local object'
   elif is_resource_map_db(did):
     return 'a Persistent ID (PID) of a local resource map'
   elif is_existing_object(did):

gmn/src/d1_gmn/app/views/assert_db.py

@@ -78,11 +78,14 @@ def is_valid_pid_for_create(did):
 
 
 def is_valid_pid_to_be_updated(did):
+  """Assert that {did} is the PID of an object that can be updated (obsoleted)
+  with MNStorage.update()
+  """
   if not d1_gmn.app.did.is_valid_pid_to_be_updated(did):
     raise d1_common.types.exceptions.InvalidRequest(
-      0,
-      'Identifier cannot be used for an update. did="{}" cause="Object is {}"'
-      .format(did, d1_gmn.app.did.classify_identifier(did)), identifier=did
+      0, 'Object cannot be updated because the identifier for the object to be '
+      'updated is {}. did="{}"'.format(
+        d1_gmn.app.did.classify_identifier(did), did), identifier=did
     )