Exclude SLF4J and Log4J from iceberg-aws-bundle (#244)

Author: ferenc-csaky

flink-sql-runner/pom.xml

@@ -72,7 +72,6 @@
       <scope>provided</scope>
     </dependency>
 
-    <!-- Will be shipped as Flink lib -->
     <dependency>
       <groupId>org.apache.iceberg</groupId>
       <artifactId>iceberg-aws-bundle</artifactId>
@@ -452,41 +451,48 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-dependency-plugin</artifactId>
-        <version>3.8.1</version>
         <executions>
           <execution>
-            <id>copy-s3-fs-hadoop</id>
+            <id>unpack-iceberg-aws-bundle-without-logging</id>
             <goals>
-              <goal>copy-dependencies</goal>
+              <goal>unpack</goal>
             </goals>
             <phase>process-resources</phase>
             <configuration>
-              <includeGroupIds>org.apache.flink</includeGroupIds>
-              <includeArtifactIds>flink-s3-fs-hadoop</includeArtifactIds>
-              <outputDirectory>${project.build.directory}</outputDirectory>
+              <artifactItems>
+                <artifactItem>
+                  <groupId>org.apache.iceberg</groupId>
+                  <artifactId>iceberg-aws-bundle</artifactId>
+                  <version>${iceberg.version}</version>
+                  <type>jar</type>
+                  <overWrite>true</overWrite>
+                  <outputDirectory>${project.build.directory}/iceberg-aws-bundle-temp</outputDirectory>
+                  <excludes>org/apache/logging/**,org/slf4j/**</excludes>
+                </artifactItem>
+              </artifactItems>
             </configuration>
           </execution>
           <execution>
-            <id>copy-iceberg-runtime</id>
+            <id>copy-s3-fs-hadoop</id>
             <goals>
               <goal>copy-dependencies</goal>
             </goals>
             <phase>process-resources</phase>
             <configuration>
-              <includeGroupIds>org.apache.iceberg</includeGroupIds>
-              <includeArtifactIds>iceberg-flink-runtime-1.19</includeArtifactIds>
+              <includeGroupIds>org.apache.flink</includeGroupIds>
+              <includeArtifactIds>flink-s3-fs-hadoop</includeArtifactIds>
               <outputDirectory>${project.build.directory}</outputDirectory>
             </configuration>
           </execution>
           <execution>
-            <id>copy-iceberg-aws-bundle</id>
+            <id>copy-iceberg-runtime</id>
             <goals>
               <goal>copy-dependencies</goal>
             </goals>
             <phase>process-resources</phase>
             <configuration>
               <includeGroupIds>org.apache.iceberg</includeGroupIds>
-              <includeArtifactIds>iceberg-aws-bundle</includeArtifactIds>
+              <includeArtifactIds>iceberg-flink-runtime-1.19</includeArtifactIds>
               <outputDirectory>${project.build.directory}</outputDirectory>
             </configuration>
           </execution>
@@ -551,6 +557,26 @@
           </execution>
         </executions>
       </plugin>
+
+      <!-- Repackage iceberg-aws-bundle without SLF4J using antrun plugin -->
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>repack-iceberg-aws-bundle</id>
+            <goals>
+              <goal>run</goal>
+            </goals>
+            <phase>prepare-package</phase>
+            <configuration>
+              <target>
+                <jar basedir="${project.build.directory}/iceberg-aws-bundle-temp" destfile="${project.build.directory}/iceberg-aws-bundle-${iceberg.version}.jar"/>
+              </target>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 

pom.xml

@@ -117,7 +117,9 @@
     <central-publishing-maven-plugin.version>0.8.0</central-publishing-maven-plugin.version>
     <exec-maven-plugin.version>3.5.1</exec-maven-plugin.version>
     <license-maven-plugin.version>5.0.0</license-maven-plugin.version>
-    <maven-enforcer-plugin.version>3.6.1</maven-enforcer-plugin.version>
+    <maven-antrun-plugin.version>3.1.0</maven-antrun-plugin.version>
+    <maven-dependency-plugin.version>3.9.0</maven-dependency-plugin.version>
+    <maven-enforcer-plugin.version>3.6.2</maven-enforcer-plugin.version>
     <maven-gpg-plugin.version>3.2.8</maven-gpg-plugin.version>
     <maven-javadoc-plugin.version>3.11.3</maven-javadoc-plugin.version>
     <maven-source-plugin.version>3.3.1</maven-source-plugin.version>
@@ -245,12 +247,24 @@
           <version>${sundr-maven-plugin.version}</version>
         </plugin>
 
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-antrun-plugin</artifactId>
+          <version>${maven-antrun-plugin.version}</version>
+        </plugin>
+
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-enforcer-plugin</artifactId>
           <version>${maven-enforcer-plugin.version}</version>
         </plugin>
 
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-dependency-plugin</artifactId>
+          <version>${maven-dependency-plugin.version}</version>
+        </plugin>
+
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-failsafe-plugin</artifactId>