Skip to content

Commit 04ede4a

Browse files
committed
Print all headers on trace logs
Signed-off-by: Marvin Froeder <[email protected]>
1 parent 6806bda commit 04ede4a

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

sqrl-cli/src/main/resources/templates/server-config.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,11 @@
119119
"fileRegionEnabled" : true
120120
},
121121
"pgConnectOptions" : {
122-
"host": "${POSTGRES_HOST}",
123-
"port": 5432,
124-
"user": "${POSTGRES_USERNAME}",
125-
"password": "${POSTGRES_PASSWORD}",
126-
"database": "${POSTGRES_DATABASE}",
122+
"host" : "${POSTGRES_HOST}",
123+
"port" : 5432,
124+
"user" : "${POSTGRES_USERNAME}",
125+
"password" : "${POSTGRES_PASSWORD}",
126+
"database" : "${POSTGRES_DATABASE}",
127127
"cachePreparedStatements" : false,
128128
"preparedStatementCacheMaxSize" : 256,
129129
"preparedStatementCacheSqlFilter" : { },
@@ -185,4 +185,4 @@
185185
"license" : "Apache License 2.0",
186186
"licenseUrl" : "https://www.apache.org/licenses/LICENSE-2.0"
187187
}
188-
}
188+
}

sqrl-server/sqrl-server-vertx-base/src/main/java/com/datasqrl/graphql/DetailedRequestTracer.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,7 @@ public void handle(RoutingContext context) {
6666
private void logIncomingRequest(HttpServerRequest request, String requestId) {
6767
var headers =
6868
request.headers().entries().stream()
69-
.map(
70-
entry ->
71-
entry.getKey() + ": " + maskSensitiveHeader(entry.getKey(), entry.getValue()))
69+
.map(entry -> entry.getKey() + ": " + entry.getValue())
7270
.collect(Collectors.joining(", "));
7371

7472
var params =
@@ -121,17 +119,6 @@ private void logOutgoingResponse(
121119
logResponseBody(responseBodyCapture, requestId);
122120
}
123121

124-
private String maskSensitiveHeader(String headerName, String value) {
125-
var lowerName = headerName.toLowerCase();
126-
if (lowerName.contains("authorization")
127-
|| lowerName.contains("cookie")
128-
|| lowerName.contains("x-api-key")
129-
|| lowerName.contains("bearer")) {
130-
return "[MASKED]";
131-
}
132-
return value;
133-
}
134-
135122
private String generateRequestId() {
136123
return "REQ-" + System.nanoTime() + "-" + Thread.currentThread().getId();
137124
}

0 commit comments

Comments
 (0)