Fix silently ignored JSON parsing exceptions in ServerConfigUtil (#1454)

velo · web-flow · commit 8825d49e3d5a · 2025-08-05T13:48:43.000-03:00
Signed-off-by: Marvin Froeder &lt;marvin@datasqrl.com&gt;
diff --git a/sqrl-server/sqrl-server-vertx-base/src/main/java/com/datasqrl/graphql/config/ServerConfigUtil.java b/sqrl-server/sqrl-server-vertx-base/src/main/java/com/datasqrl/graphql/config/ServerConfigUtil.java
@@ -62,13 +62,7 @@ public static <T> T mapField(
     if (fieldValue == null) {
       return defaultVal.get();
     }
-    try {
-      return ctor.apply(fieldValue);
-    } catch (Exception e) {
-      log.warn(
-          "Failed to parse configuration field '{}', using default: {}", fieldName, e.getMessage());
-      return defaultVal.get();
-    }
+    return ctor.apply(fieldValue);
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -62,13 +62,7 @@ public static <T> T mapField(`
`62`	`62`	`if (fieldValue == null) {`
`63`	`63`	`return defaultVal.get();`
`64`	`64`	`}`
`65`		`- try {`
`66`		`- return ctor.apply(fieldValue);`
`67`		`- } catch (Exception e) {`
`68`		`- log.warn(`
`69`		`- "Failed to parse configuration field '{}', using default: {}", fieldName, e.getMessage());`
`70`		`- return defaultVal.get();`
`71`		`- }`
	`65`	`+ return ctor.apply(fieldValue);`
`72`	`66`	`}`
`73`	`67`
`74`	`68`	`/**`