Skip to content

Commit 9244ac7

Browse files
authored
Simplify FullUseCasesIT to read package.json, exclude reusable parts to JUni5 extensions (#1421)
Also do not execute `run` goal in our internal test infra, as now that we manage `test` goal properly, it is redundant
1 parent a57464d commit 9244ac7

File tree

159 files changed

+894
-6420
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

159 files changed

+894
-6420
lines changed

sqrl-testing/sqrl-container-testing/src/test/java/com/datasqrl/container/testing/ExternalRedpandaContainerIT.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class ExternalRedpandaContainerIT extends SqrlContainerTestBase {
4242

4343
@Override
4444
protected String getTestCaseName() {
45-
return "flink+kafka";
45+
return "flink-kafka";
4646
}
4747

4848
@BeforeEach
@@ -68,7 +68,7 @@ void givenExternalRedpandaContainer_whenCompileAndRunFlinkKafka_thenUsesExternal
6868

6969
// When - Compile SQRL script with external Kafka configuration
7070
var cmdContainer = createCmdContainerWithExternalKafka();
71-
cmd = cmdContainer.withCommand("test", "flink_kafka.sqrl");
71+
cmd = cmdContainer.withCommand("test", "flink-kafka.sqrl");
7272

7373
log.info("Starting compilation with external Redpanda container");
7474
log.info(getDockerRunCommand(cmd, testDir));
@@ -189,7 +189,7 @@ private GenericContainer<?> createCmdContainerWithExternalKafka() {
189189
.withEnv("KAFKA_BOOTSTRAP_SERVERS", REDPANDA_CONTAINER_NAME + ":" + REDPANDA_PORT);
190190

191191
// Add additional mount to resolve the symlink
192-
// flink+kafka/loan-local -> ../banking/loan-local
192+
// flink-kafka/loan-local -> ../banking/loan-local
193193
var bankingDir = testDir.getParent().resolve("banking");
194194

195195
if (bankingDir.toFile().exists()) {

sqrl-testing/sqrl-container-testing/src/test/java/com/datasqrl/container/testing/SqrlTestContainerIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,14 @@ void givenAvroSchemaScript_whenTestCommandExecuted_thenSnapshotsValidateSuccessf
5858
@Test
5959
@SneakyThrows
6060
void givenAvroPackage_whenTestCommandExecuted_thenSnapshotsValidateSuccessfully() {
61-
var snapshots = testDir.resolve("snapshots");
61+
var snapshots = testDir.resolve("snapshots-tmp");
6262
FileUtils.deleteDirectory(snapshots.toFile());
6363

6464
// Assert that the test command throws a RuntimeException and capture the exception
6565
ContainerError exception =
6666
(ContainerError)
6767
assertThatThrownBy(
68-
() -> sqrlScript(testDir, "test -c complete-package.json".split(" ")))
68+
() -> sqrlScript(testDir, "test -c package-no-snapshots.json".split(" ")))
6969
.isInstanceOf(ContainerError.class)
7070
.hasMessageContaining("SQRL compilation failed")
7171
.actual();

0 commit comments

Comments
 (0)