Skip to content

Commit 52fb3be

Browse files
committed
Fixed tests.
1 parent 99c8cd5 commit 52fb3be

File tree

5 files changed

+112
-180
lines changed

5 files changed

+112
-180
lines changed

tests/testSerialization.cpp

Lines changed: 14 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ using std::unique_ptr;
1717
using std::stringstream;
1818

1919
TEST(emptyBoardSerialization) {
20-
vector<unique_ptr<Player>> players;
21-
22-
GameBoard testBoard(std::move(players));
20+
GameBoard testBoard({});
2321

2422
stringstream stream;
2523
testBoard.save(stream);
@@ -30,11 +28,7 @@ TEST(emptyBoardSerialization) {
3028
}
3129

3230
TEST(multiplePlayerSerialization) {
33-
vector<unique_ptr<Player>> players;
34-
players.emplace_back(unique_ptr<Player>(new Player("test")));
35-
players.emplace_back(unique_ptr<Player>(new Player("test2")));
36-
37-
GameBoard testBoard(std::move(players));
31+
GameBoard testBoard({"test", "test2"});
3832

3933
stringstream stream;
4034
testBoard.save(stream);
@@ -45,15 +39,13 @@ TEST(multiplePlayerSerialization) {
4539
}
4640

4741
TEST(testCardSerialization) {
48-
vector<unique_ptr<Player>> players;
49-
players.emplace_back(unique_ptr<Player>(new Player("test")));
50-
players[0]->buyCard(unique_ptr<DevelopmentCard>(new KnightCard()));
51-
players[0]->buyCard(unique_ptr<DevelopmentCard>(new VictoryPointCard()));
52-
players[0]->buyCard(unique_ptr<DevelopmentCard>(new YearOfPlentyCard()));
53-
players[0]->buyCard(unique_ptr<DevelopmentCard>(new MonopolyCard()));
54-
players[0]->buyCard(unique_ptr<DevelopmentCard>(new RoadBuildingCard()));
55-
56-
GameBoard testBoard(std::move(players));
42+
GameBoard testBoard({"test"});
43+
Player& testPlayer = testBoard.getPlayer(0);
44+
testPlayer.buyCard(unique_ptr<DevelopmentCard>(new KnightCard(testBoard)));
45+
testPlayer.buyCard(unique_ptr<DevelopmentCard>(new VictoryPointCard(testBoard)));
46+
testPlayer.buyCard(unique_ptr<DevelopmentCard>(new YearOfPlentyCard(testBoard)));
47+
testPlayer.buyCard(unique_ptr<DevelopmentCard>(new MonopolyCard(testBoard)));
48+
testPlayer.buyCard(unique_ptr<DevelopmentCard>(new RoadBuildingCard(testBoard)));
5749

5850
stringstream stream;
5951
testBoard.save(stream);
@@ -64,15 +56,9 @@ TEST(testCardSerialization) {
6456
}
6557

6658
TEST(roadSerialization) {
67-
vector<unique_ptr<Player>> players;
68-
players.emplace_back(unique_ptr<Player>(new Player("test")));
69-
players.emplace_back(unique_ptr<Player>(new Player("test2")));
70-
std::cout << __LINE__ << "\n";
71-
Player& firstPlayer = *players[0];
72-
Player& secondPlayer = *players[1];
73-
std::cout << __LINE__ << "\n";
74-
75-
GameBoard testBoard(std::move(players));
59+
GameBoard testBoard({"test", "test2"});
60+
Player& firstPlayer = testBoard.getPlayer(0);
61+
Player& secondPlayer = testBoard.getPlayer(1);
7662

7763
testBoard.PlaceSettlement(Coordinate(0,0), firstPlayer);
7864
testBoard.PlaceSettlement(Coordinate(-1,1), secondPlayer);
@@ -88,12 +74,8 @@ TEST(roadSerialization) {
8874
}
8975

9076
TEST(settlementSerialization) {
91-
vector<unique_ptr<Player>> players;
92-
players.emplace_back(unique_ptr<Player>(new Player("test")));
93-
94-
Player& player = *players[0];
95-
96-
GameBoard testBoard(std::move(players));
77+
GameBoard testBoard({"test"});
78+
Player& player = testBoard.getPlayer(0);
9779

9880
testBoard.PlaceSettlement(Coordinate(0, 0), player);
9981
testBoard.PlaceSettlement(Coordinate(1, 1), player);

tests/test_Deck.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
*/
77

88
#include "Deck.h"
9+
#include "GameBoard.h"
910
#include "Util.h"
1011
#include "UnitTest++.h"
1112

1213
TEST(deck_draw)
1314
{
14-
Deck* testDeck= new Deck();
15+
GameBoard board({});
16+
Deck* testDeck= new Deck(board);
1517
DevelopmentCard* temp = testDeck->drawCard();
1618
CHECK(temp!=NULL);
1719
testDeck->discard(temp);
@@ -21,7 +23,8 @@ TEST(deck_draw)
2123

2224
TEST(reshuffle_discard_pile)
2325
{
24-
Deck* testDeck= new Deck();
26+
GameBoard board({});
27+
Deck* testDeck= new Deck(board);
2528
DevelopmentCard* drawn = NULL;
2629
for (int i = 0; i<300; i++)
2730
{

tests/test_DevelopmentCards.cpp

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,12 @@
1111

1212

1313
TEST(RoadBuildingCard_good){
14-
std::vector<std::unique_ptr<Player>> players {};
15-
players.emplace_back(new Player("tester"));
16-
Player& test_player = *players[0];
17-
GameBoard test_board(std::move(players));
18-
test_player.setBoard(&test_board);
14+
GameBoard test_board({"tester"});
15+
Player& test_player = test_board.getPlayer(0);
1916

2017
test_board.PlaceSettlement(Coordinate(0,0), test_player);
2118

22-
RoadBuildingCard test_card;
19+
RoadBuildingCard test_card(test_board);
2320

2421
try{
2522
test_card.playCard(&test_player, Coordinate(0,0), Coordinate(-1,1), Coordinate(0,0), Coordinate(1,0));
@@ -31,15 +28,12 @@ TEST(RoadBuildingCard_good){
3128
}
3229

3330
TEST(RoadBuildingCard_bad){
34-
std::vector<std::unique_ptr<Player>> players {};
35-
players.emplace_back(new Player("tester"));
36-
Player& test_player = *players[0];
37-
GameBoard test_board(std::move(players));
38-
test_player.setBoard(&test_board);
31+
GameBoard test_board({"tester"});
32+
Player& test_player = test_board.getPlayer(0);
3933

4034
test_board.PlaceSettlement(Coordinate(0,0), test_player);
4135

42-
RoadBuildingCard test_card;
36+
RoadBuildingCard test_card(test_board);
4337

4438
try{
4539
test_card.playCard(&test_player, Coordinate(0,0), Coordinate(0,2), Coordinate(0,0), Coordinate(1,0));

0 commit comments

Comments
 (0)