Merge pull request #58 from Databean/removeWarnings

Fixed some G++ warnings

Author: Kdog0073

include/GameController.h

@@ -63,7 +63,7 @@ class GameController {
 	ControlState popState();
 	void storeClick(Coordinate clickCoordinate);
 	Coordinate getLastClick();
-	Coordinate getPastClick(int howLongAgo);
+	Coordinate getPastClick(unsigned int howLongAgo);
 	void clearClickHistory();
 	bool hasClickHistory();
 	int getClickHistorySize();

src/GameController.cpp

@@ -109,7 +109,7 @@ Coordinate GameController::getLastClick(){
  * Gets a click from param clicks ago
  * @ param an integer
  */
-Coordinate GameController::getPastClick(int howLongAgo){
+Coordinate GameController::getPastClick(unsigned int howLongAgo){
 	if (howLongAgo < clickHistory.size()){
 		return clickHistory[clickHistory.size() - 1 - howLongAgo];
 	}
@@ -473,7 +473,7 @@ bool GameController::handlePlayerClick(ScreenCoordinate coord, Player& player) {
 			return handleCancelButtonEvent(coord);
 		}
 	}
-	
+	return true;
 }
 
 /**

tests/test_GameBoard.cpp

@@ -328,11 +328,9 @@ TEST(GameBoardTest, updateLongestRoadPlayer){
 TEST(GameBoardTest, canRobberRob){
 	GameBoard test_board({"tester1", "tester2"});
 	Player& test_player1 = test_board.getPlayer(0);
-	Player& test_player2 = test_board.getPlayer(1);
-
-
+	
 	ASSERT_FALSE(test_board.canRobberRob(test_player1, Coordinate(0,1)));
-
+	
 	test_board.PlaceSettlement(Coordinate(0,0), test_player1);
 	ASSERT_TRUE(test_board.canRobberRob(test_player1, Coordinate(0,1)));
 }