Fixed resource payout. Made road and settlement buttons require and deduct resources

Author: Databean

include/GameBoard.h

@@ -101,11 +101,13 @@ class GameBoard {
 	void PlaceSettlement(Coordinate location, Player& Owner);
 	void UpgradeSettlement(Coordinate location);
 	void UpgradeToWonder(Coordinate location);
-
-
+	
 	bool verifyRoadPlacement(Coordinate start, Coordinate end, Player& Owner) const;
 	bool buyRoad(Coordinate start, Coordinate end, Player& Owner);
-
+	
+	bool canPlaceSettlement(const Coordinate& location, const Player& owner);
+	bool buySettlement(const Coordinate& location, Player& owner);
+	
 	//void PlaceSettlement(Coordinate location, Player& Owner);
 	void PlaceCity(Coordinate location, Player& Owner);
 	void PlaceWonder(Coordinate location, Player& Owner);

include/Player.h

@@ -71,7 +71,7 @@ class Player {
     void setLongestRoad(bool);
     void setLongestRoadSize(int);
 
-    std::tuple<float, float, float> getColor();
+    std::tuple<float, float, float> getColor() const;
 
     int getVictoryPointsWithoutCards();
     int getVictoryPointCards();

src/GameBoard.cpp

@@ -410,8 +410,8 @@ std::vector<CornerPiece*> GameBoard::GetNeighboringCorners(
 		const Coordinate& diff = adjacentCoordDiffs[i];
 		Coordinate adjacentPoint(location.first + diff.first,
 				location.second + diff.second);
-		auto it = resources.find(adjacentPoint);
-		if (it != resources.end()) {
+		auto it = corners.find(adjacentPoint);
+		if (it != corners.end()) {
 			GamePiece* piece = it->second.get();
 			if (dynamic_cast<CornerPiece*>(piece)) {
 				v.push_back(static_cast<CornerPiece*>(piece));
@@ -489,18 +489,26 @@ bool GameBoard::isRoadConnectionPoint(Coordinate point, Player& Owner) const {
  * @return If the road can be placed at the locations by the player.
  */
 bool GameBoard::verifyRoadPlacement(Coordinate start, Coordinate end, Player& Owner) const {
-	if (outOfBounds(start) || outOfBounds(end))
+	if (outOfBounds(start) || outOfBounds(end)) {
+		std::cout << "out of bounds" << std::endl;
 		return false;
-
-	if (roadExists(start, end))
+	}
+	
+	if (roadExists(start, end)) {
+		std::cout << "road exists" << std::endl;
 		return false;
-
-	if (!isRoadConnectionPoint(start, Owner) && !isRoadConnectionPoint(end, Owner)) //need to XOR
+	}
+	
+	if (!isRoadConnectionPoint(start, Owner) && !isRoadConnectionPoint(end, Owner)) { //need to XOR
+		std::cout << "not a road connection point" << std::endl;
 		return false;
-
-	if(!Road::isValidRoad(start, end))
+	}
+	
+	if(!Road::isValidRoad(start, end)) {
+		std::cout << "not a valid road" << std::endl;
 		return false;
-
+	}
+	
 	return true;
 }
 
@@ -548,8 +556,12 @@ Coordinate GameBoard::getRobber() const {
  * @returns True if the road was placed, false otherwise
  */
 bool GameBoard::PlaceRoad(Coordinate start, Coordinate end, Player& Owner) {
-	if (!verifyRoadPlacement(start, end, Owner))
+	if (!verifyRoadPlacement(start, end, Owner)) {
+		std::cout << "invalid road placement" << std::endl;
 		return false;
+	}
+	
+	std::cout << "passed verify" << std::endl;
 
 	std::shared_ptr<Road> newRoad;
 	try {
@@ -600,6 +612,7 @@ bool GameBoard::buyRoad(Coordinate start, Coordinate end, Player& Owner){
 		Owner.buyRoad();
 		return true;
 	}
+	std::cout << "failed to buy for some reason" << std::endl;
 	return false;
 }
 
@@ -743,6 +756,60 @@ void GameBoard::updateLargestArmyPlayer(){
 
 }
 
+/**
+ * Whether a player can place a settlement at a location.
+ * @param location The place to put the settlement.
+ * @param owner The player placing the settlement.
+ * @return If the location is a valid place to put a settlement.
+ */
+bool GameBoard::canPlaceSettlement(const Coordinate& location, const Player& owner) {
+	//Don't place this on top of a resource
+	if(resources.find(location) != resources.end()) {
+		std::cout << "can't put settlements on top of resource tiles" << std::endl;
+		return false;
+	}
+	//Don't place this on top of another settlement
+	if(corners.find(location) != corners.end()) {
+		std::cout << "can't put a settlement on top of another corner piece" << std::endl;
+		return false;
+	}
+	//Don't place this off the map
+	if(outOfBounds(location)) {
+		std::cout << "this is out of bounds" << std::endl;
+		return false;
+	}
+	//Can't have a settlement next to another settlement.
+	if(GetNeighboringCorners(location).size() > 0) {
+		std::cout << "there's an adjacent corner piece" << std::endl;
+		return false;
+	}
+	for(auto road : getRoads(location)) {
+		if(road->getOwner() == owner) {
+			//Player has a connecting road
+			return true;
+		}
+	}
+	std::cout << "there are no connecting roads" << std::endl;
+	//Player has no connecting roads
+	return false;
+}
+
+/**
+ * Buy a settlement if possible.
+ * @param location The location to place the settlement.
+ * @param owner The player buying the settlement.
+ * @return If placing the settlement was a success.
+ */
+bool GameBoard::buySettlement(const Coordinate& location, Player& owner) {
+	if(canPlaceSettlement(location, owner) && owner.canBuySettlement()) {
+		if(!owner.buySettlement()) {
+			std::cout << "wat" << std::endl;
+			return false;
+		}
+		PlaceSettlement(location, owner);
+	}
+	return false;
+}
 
 /**
  * Place a settlement on the board.

src/GameController.cpp

@@ -131,15 +131,18 @@ int GameController::getClickHistorySize(){
 	return clickHistory.size();
 }
 
-
-
-
+void printPlayerInfo(const Player& player) {
+	auto color = player.getColor();
+	std::cout << player.getName() << "'s turn. (" << std::get<0>(color) << ", " << std::get<1>(color) << ", " << std::get<2>(color) <<")" << std::endl;
+	std::cout << "Wood: " << player.getWood() << ", Brick: " << player.getBrick() << ", Ore: " << player.getOre() << ", Wheat: " << player.getWheat() << ", Wool: " << player.getWool() << std::endl;
+}
 
 /**
  *  calls a function to advance turn, check for victory and roll dice
  */
 bool GameController::nextTurn(ScreenCoordinate) {
 	model.endTurn();
+	printPlayerInfo(model.getCurrentPlayer());
 	return true;
 }
 
@@ -150,14 +153,15 @@ bool GameController::nextTurn(ScreenCoordinate) {
  * @return Whether this event was handled by this element. Always true.
  */
 bool GameController::handleBoardEvent(ScreenCoordinate screenCoord) {
+	printPlayerInfo(model.getCurrentPlayer());
 	auto coord = screenToCoord(screenCoord);
-
+	
 	switch (getState()){
 	case BUILDROAD:
 		if(!hasClickHistory()) {
 			storeClick(coord);
 		} else {
-			if (model.PlaceRoad(getLastClick(), coord, *model.getPlayers()[0]));
+			if (model.buyRoad(getLastClick(), coord, model.getCurrentPlayer()));
 			{
 				popState();
 			}
@@ -196,8 +200,8 @@ bool GameController::handleBoardEvent(ScreenCoordinate screenCoord) {
 		popState();
 		break;
 	case BUILDSETTLEMENT:
-		std::cout << "BUILDSETTLEMENT\n";
-		model.PlaceSettlement(coord, *model.getPlayers()[0]);
+		std::cout << "attempting to buy a settlement" << std::endl;
+		model.buySettlement(coord, model.getCurrentPlayer());
 		popState();
 		break;
 	default:

src/Player.cpp

@@ -111,7 +111,7 @@ Player::~Player() {
 
 }
 
-std::tuple<float, float, float> Player::getColor(){
+std::tuple<float, float, float> Player::getColor() const {
 	return color;
 }
 

src/Renderer.cpp

@@ -145,7 +145,7 @@ pair<float, float> coordToScreen(const Coordinate& coord) {
 	using std::sin;
 	using std::cos;
 	// TODO not magic numbers
-	static const float xscale = 9.f / 16.f / 7.f;
+	static const float xscale = 9.f / 16.f / 6.f;
 	static const float yscale = 0.1f;
 	static const float angle = M_PI / 3.f;
 	float x = .25f + (xscale * coord.first) + ((yscale * coord.second) * cos(angle));
@@ -159,7 +159,7 @@ pair<float, float> coordToScreen(const Coordinate& coord) {
  * @return The game coordinate.
  */
 Coordinate screenToCoord(const pair<float, float>& screen) {
-	static const float xscale = 9.f / 16.f / 7.f;
+	static const float xscale = 9.f / 16.f / 6.f;
 	static const float yscale = 0.1f;
 	static const float angle = M_PI / 3.f;
 	Coordinate ret;

tests/test_GameBoard.cpp

@@ -175,8 +175,8 @@ TEST(payout_simple) {
 	test_board.getResourceTile(Coordinate(0,1)).Payout();
 
 
-	CHECK(!(test_player.getWheat() || test_player.getWood() || 
-		test_player.getOre() || test_player.getBrick() || test_player.getWool()));
+	CHECK(test_player.getWheat() || test_player.getWood() || 
+		test_player.getOre() || test_player.getBrick() || test_player.getWool());
 }
 
 TEST(upgrade_simple){