Skip to content

Commit 791b987

Browse files
BGruenbergBGruenberg
committed
refactor: remove aria-hidden attribute
`fontawesome` SVGs contain this attribute by default.
1 parent 572d67e commit 791b987

File tree

8 files changed

+41
-41
lines changed

8 files changed

+41
-41
lines changed

‎src/app/create-appointment/create-appointment.component.html‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ <h1 class="text-center" id="change-details-heading">
4949
role="alert"
5050
aria-atomic="false"
5151
>
52-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
52+
<i class="fa-solid fa-triangle-exclamation"></i>
5353
{{ 'poll.title.noTitle' | translate }}
5454
</div>
5555
}
@@ -61,7 +61,7 @@ <h1 class="text-center" id="change-details-heading">
6161
role="alert"
6262
aria-atomic="false"
6363
>
64-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
64+
<i class="fa-solid fa-triangle-exclamation"></i>
6565
{{ 'poll.title.invalid' | translate }}
6666
</div>
6767
}
@@ -73,7 +73,7 @@ <h1 class="text-center" id="change-details-heading">
7373
role="alert"
7474
aria-atomic="false"
7575
>
76-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
76+
<i class="fa-solid fa-triangle-exclamation"></i>
7777
{{ 'poll.title.tooLong' | translate }}
7878
</div>
7979
}
@@ -106,7 +106,7 @@ <h1 class="text-center" id="change-details-heading">
106106
role="alert"
107107
aria-atomic="false"
108108
>
109-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
109+
<i class="fa-solid fa-triangle-exclamation"></i>
110110
{{ 'poll.details.name.noName' | translate }}
111111
</div>
112112
}
@@ -118,7 +118,7 @@ <h1 class="text-center" id="change-details-heading">
118118
role="alert"
119119
aria-atomic="false"
120120
>
121-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
121+
<i class="fa-solid fa-triangle-exclamation"></i>
122122
{{ 'poll.details.name.invalid' | translate }}
123123
</div>
124124
}
@@ -130,7 +130,7 @@ <h1 class="text-center" id="change-details-heading">
130130
role="alert"
131131
aria-atomic="false"
132132
>
133-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
133+
<i class="fa-solid fa-triangle-exclamation"></i>
134134
{{ 'poll.details.name.tooLong' | translate }}
135135
</div>
136136
}
@@ -161,7 +161,7 @@ <h1 class="text-center" id="change-details-heading">
161161
role="alert"
162162
aria-atomic="false"
163163
>
164-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
164+
<i class="fa-solid fa-triangle-exclamation"></i>
165165
{{ 'poll.details.place.invalid' | translate }}
166166
</div>
167167
}
@@ -173,7 +173,7 @@ <h1 class="text-center" id="change-details-heading">
173173
role="alert"
174174
aria-atomic="false"
175175
>
176-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
176+
<i class="fa-solid fa-triangle-exclamation"></i>
177177
{{ 'poll.details.place.tooLong' | translate }}
178178
</div>
179179
}
@@ -210,7 +210,7 @@ <h1 class="text-center" id="change-details-heading">
210210
role="alert"
211211
aria-atomic="false"
212212
>
213-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
213+
<i class="fa-solid fa-triangle-exclamation"></i>
214214
{{ 'poll.details.description.tooLong' | translate }}
215215
</div>
216216
}

‎src/app/create-suggested-dates/create-suggested-dates.component.html‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
9393
role="alert"
9494
aria-atomic="false"
9595
>
96-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
96+
<i class="fa-solid fa-triangle-exclamation"></i>
9797
{{ 'date.setStart' | translate }}
9898
</div>
9999
}
@@ -105,7 +105,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
105105
role="alert"
106106
aria-atomic="false"
107107
>
108-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
108+
<i class="fa-solid fa-triangle-exclamation"></i>
109109
{{ 'date.startInvalid' | translate }}
110110
</div>
111111
}
@@ -117,7 +117,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
117117
role="alert"
118118
aria-atomic="false"
119119
>
120-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
120+
<i class="fa-solid fa-triangle-exclamation"></i>
121121
{{ 'date.startFuture' | translate }}
122122
</div>
123123
}
@@ -149,7 +149,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
149149
&& (getEndDateOfSuggestedStartDateByIndex(i).dirty
150150
|| getEndDateOfSuggestedStartDateByIndex(i).touched)) {
151151
<div class="invalid-message" id="invalid-date" role="alert" aria-atomic="false">
152-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
152+
<i class="fa-solid fa-triangle-exclamation"></i>
153153
{{ 'date.endInvalid' | translate }}
154154
</div>
155155
}
@@ -361,7 +361,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
361361
role="alert"
362362
aria-atomic="false"
363363
>
364-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
364+
<i class="fa-solid fa-triangle-exclamation"></i>
365365
{{ 'poll.details.description.tooLong' | translate }}
366366
</div>
367367
}
@@ -374,7 +374,7 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
374374
class="col my-1 px-1 px-lg-3 my-1 form-group">
375375
@if (!!getSuggestedDatesForm(i).errors?.startDateAfterEndDate) {
376376
<div class="invalid-message" id="start-date-after-end-date" role="alert" aria-atomic="false">
377-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
377+
<i class="fa-solid fa-triangle-exclamation"></i>
378378
{{ 'date.startAfterEnd' | translate }}
379379
</div>
380380
}
@@ -385,13 +385,13 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
385385
role="alert"
386386
aria-atomic="false"
387387
>
388-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
388+
<i class="fa-solid fa-triangle-exclamation"></i>
389389
{{ 'date.noStart' | translate }}
390390
</div>
391391
}
392392
@if (!!getSuggestedDatesForm(i).errors?.startDateTimeInPast) {
393393
<div class="invalid-message" id="start-date-time-in-past" role="alert" aria-atomic="false">
394-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
394+
<i class="fa-solid fa-triangle-exclamation"></i>
395395
{{ 'date.inPast' | translate }}
396396
</div>
397397
}
@@ -409,13 +409,13 @@ <h2 class="font-medium text-bold d-inline" data-id="enterDate">
409409
>
410410
@if (!!getSuggestedDatesFromForm().errors?.invalidMinLengthArray) {
411411
<div class="invalid-message" role="alert" aria-atomic="false">
412-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
412+
<i class="fa-solid fa-triangle-exclamation"></i>
413413
{{ 'date.noValue' | translate }}
414414
</div>
415415
}
416416
@if (!!getSuggestedDatesFromForm().errors?.invalidMaxLengthArray) {
417417
<div class="invalid-message" role="alert" aria-atomic="false">
418-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
418+
<i class="fa-solid fa-triangle-exclamation"></i>
419419
{{ 'date.tooManyValues' | translate }}
420420
</div>
421421
}

‎src/app/home/home.component.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ <h1 class="text-center">
4545
role="alert"
4646
aria-atomic="false"
4747
>
48-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
48+
<i class="fa-solid fa-triangle-exclamation"></i>
4949
{{ 'poll.title.noTitle' | translate }}
5050
</div>
5151
}
@@ -57,7 +57,7 @@ <h1 class="text-center">
5757
role="alert"
5858
aria-atomic="false"
5959
>
60-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
60+
<i class="fa-solid fa-triangle-exclamation"></i>
6161
{{ 'poll.title.invalid' | translate }}
6262
</div>
6363
}
@@ -69,7 +69,7 @@ <h1 class="text-center">
6969
role="alert"
7070
aria-atomic="false"
7171
>
72-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
72+
<i class="fa-solid fa-triangle-exclamation"></i>
7373
{{ 'poll.title.tooLong' | translate }}
7474
</div>
7575
}

‎src/app/password/password.component.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ <h1 class="text-center" data-id="locked">
3535
(click)="togglePasswordVisibility()"
3636
[attr.aria-description]="'password.' + (passwordHidden ? 'showPassword' : 'hidePassword') | translate"
3737
>
38-
<i class="fa-solid" aria-hidden="true" [ngClass]="passwordHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
38+
<i class="fa-solid" [ngClass]="passwordHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
3939
</button>
4040
</div>
4141
@if (showIsInvalid && isInvalid) {
@@ -46,7 +46,7 @@ <h1 class="text-center" data-id="locked">
4646
role="alert"
4747
aria-atomic="false"
4848
>
49-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
49+
<i class="fa-solid fa-triangle-exclamation"></i>
5050
{{ 'password.invalid' | translate }}
5151
</div>
5252
}

‎src/app/poll/mobile-poll-table.component.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,19 @@
6868
@if ((formHelper.getParticipantFormName().dirty || formHelper.getParticipantFormName().touched)
6969
&& !!formHelper.getParticipantFormName().errors?.required) {
7070
<div class="invalid-message" role="alert" aria-atomic="false">
71-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
71+
<i class="fa-solid fa-triangle-exclamation"></i>
7272
{{ 'poll.details.name.noName' | translate }}
7373
</div>
7474
}
7575
@if (!!formHelper.getParticipantFormName().errors?.invalidName) {
7676
<div class="invalid-message" id="invalid-add-name" role="alert" aria-atomic="false">
77-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
77+
<i class="fa-solid fa-triangle-exclamation"></i>
7878
{{ 'poll.details.name.invalid' | translate }}
7979
</div>
8080
}
8181
@if (!!formHelper.getParticipantFormName().errors?.maxlength) {
8282
<div class="invalid-message" role="alert" aria-atomic="false">
83-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
83+
<i class="fa-solid fa-triangle-exclamation"></i>
8484
{{ 'poll.details.name.tooLong' | translate }}
8585
</div>
8686
}

‎src/app/poll/poll.component.html‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ <h1 class="text-center" data-id="pollHeading">
146146
role="alert"
147147
aria-atomic="false"
148148
>
149-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
149+
<i class="fa-solid fa-triangle-exclamation"></i>
150150
{{ 'poll.details.name.noName' | translate }}
151151
</div>
152152
}
@@ -158,7 +158,7 @@ <h1 class="text-center" data-id="pollHeading">
158158
role="alert"
159159
aria-atomic="false"
160160
>
161-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
161+
<i class="fa-solid fa-triangle-exclamation"></i>
162162
{{ 'poll.details.name.invalid' | translate }}
163163
</div>
164164
}
@@ -170,7 +170,7 @@ <h1 class="text-center" data-id="pollHeading">
170170
role="alert"
171171
aria-atomic="false"
172172
>
173-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
173+
<i class="fa-solid fa-triangle-exclamation"></i>
174174
{{ 'poll.details.name.tooLong' | translate }}
175175
</div>
176176
}
@@ -283,19 +283,19 @@ <h1 class="text-center" data-id="pollHeading">
283283
&& (formHelper.getParticipantFormName().dirty || formHelper.getParticipantFormName().touched)
284284
&& !!formHelper.getParticipantFormName().errors?.required) {
285285
<div class="invalid-message" id="no-name-edit" role="alert" aria-atomic="false">
286-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
286+
<i class="fa-solid fa-triangle-exclamation"></i>
287287
{{ 'poll.details.name.noName' | translate }}
288288
</div>
289289
}
290290
@if (formHelper.getParticipantFormName() && !!formHelper.getParticipantFormName().errors?.invalidName) {
291291
<div class="invalid-message" id="invalid-edit-name" role="alert" aria-atomic="false">
292-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
292+
<i class="fa-solid fa-triangle-exclamation"></i>
293293
{{ 'poll.details.name.invalid' | translate }}
294294
</div>
295295
}
296296
@if (formHelper.getParticipantFormName() && !!formHelper.getParticipantFormName().errors?.maxlength) {
297297
<div class="invalid-message" id="too-long-edit" role="alert" aria-atomic="false">
298-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
298+
<i class="fa-solid fa-triangle-exclamation"></i>
299299
{{ 'poll.details.name.tooLong' | translate }}
300300
</div>
301301
}

‎src/app/settings/settings.component.html‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
6262
(click)="togglePasswordVisibility()"
6363
[attr.aria-description]="'password.' + (passwordHidden ? 'showPassword' : 'hidePassword') | translate"
6464
>
65-
<i class="fa-solid" aria-hidden="true" [ngClass]="passwordHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
65+
<i class="fa-solid" [ngClass]="passwordHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
6666
</button>
6767
</div>
6868
@if (getPassword().touched || getPassword().dirty) {
@@ -75,7 +75,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
7575
role="alert"
7676
aria-atomic="false"
7777
>
78-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
78+
<i class="fa-solid fa-triangle-exclamation"></i>
7979
{{ 'password.set' | translate }}
8080
</div>
8181
}
@@ -87,7 +87,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
8787
role="alert"
8888
aria-atomic="false"
8989
>
90-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
90+
<i class="fa-solid fa-triangle-exclamation"></i>
9191
{{ 'password.setMinimum' | translate }}
9292
</div>
9393
}
@@ -126,7 +126,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
126126
(click)="togglePasswordRepeatVisibility()"
127127
[attr.aria-description]="'password.' + (passwordRepeatHidden ? 'showPassword' : 'hidePassword') | translate"
128128
>
129-
<i class="fa-solid" aria-hidden="true" [ngClass]="passwordRepeatHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
129+
<i class="fa-solid" [ngClass]="passwordRepeatHidden ? 'fa-eye-slash' : 'fa-eye'"></i>
130130
</button>
131131
</div>
132132
<!-- show message if:
@@ -142,7 +142,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
142142
role="alert"
143143
aria-atomic="false"
144144
>
145-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
145+
<i class="fa-solid fa-triangle-exclamation"></i>
146146
{{ 'password.set' | translate }}
147147
</div>
148148
} @else if (getPasswordRepeat().dirty) {
@@ -154,7 +154,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
154154
role="alert"
155155
aria-atomic="false"
156156
>
157-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
157+
<i class="fa-solid fa-triangle-exclamation"></i>
158158
{{ 'password.noMatch' | translate }}
159159
</div>
160160
}
@@ -166,7 +166,7 @@ <h2 class="my-1 font-medium text-bold" data-id="generatePassword">{{ 'password.g
166166
role="alert"
167167
aria-atomic="false"
168168
>
169-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
169+
<i class="fa-solid fa-triangle-exclamation"></i>
170170
{{ 'password.setMinimum' | translate }}
171171
</div>
172172
}

‎src/app/shared/components/tos/tos.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ <h2>{{ 'tos.header' | translate }}</h2>
1717

1818
@if (isTosRead.dirty && isTosRead.invalid) {
1919
<div class="col-12 invalid-message" id="tos-accept" role="alert" aria-atomic="false">
20-
<i class="fa-solid fa-triangle-exclamation" aria-hidden="true"></i>
20+
<i class="fa-solid fa-triangle-exclamation"></i>
2121
{{ 'tos.accept' | translate }}
2222
</div>
2323
}

0 commit comments

Comments
 (0)