Align TransportVersion#bestKnownVersion with 8.x

DaveCTurner · DaveCTurner · commit 0006d5022bb5 · 2025-03-01T17:57:05.000Z
In backporting elastic#123397 to 8.x we discovered that we needed to generalize `TransportVersion#bestKnownVersion` slightly to handle older versions. This commit forward-ports this change to keep the branches aligned.
diff --git a/server/src/main/java/org/elasticsearch/TransportVersion.java b/server/src/main/java/org/elasticsearch/TransportVersion.java
@@ -131,7 +131,7 @@ public boolean isKnown() {
      *         there are no such versions.
      */
     public TransportVersion bestKnownVersion() {
-        if (VersionsHolder.ALL_VERSIONS_MAP.containsKey(id)) {
+        if (isKnown()) {
             return this;
         }
         TransportVersion bestSoFar = TransportVersions.ZERO;

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ public boolean isKnown() {`
`131`	`131`	`* there are no such versions.`
`132`	`132`	`*/`
`133`	`133`	`public TransportVersion bestKnownVersion() {`
`134`		`- if (VersionsHolder.ALL_VERSIONS_MAP.containsKey(id)) {`
	`134`	`+ if (isKnown()) {`
`135`	`135`	`return this;`
`136`	`136`	`}`
`137`	`137`	`TransportVersion bestSoFar = TransportVersions.ZERO;`