Skip to content

Commit f8547ba

Browse files
committed
Reinstate comment lost in elastic#135008
... and reformat Javadoc
1 parent 38c05ea commit f8547ba

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

server/src/main/java/org/elasticsearch/cluster/service/MasterService.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,10 +1407,11 @@ private interface Batch {
14071407
/**
14081408
* Called when the batch is rejected due to the master service shutting down.
14091409
*
1410-
* @param e is a {@link NotMasterException} to cause things like {@link TransportMasterNodeAction} to retry after
1411-
* submitting a task to a master which shut down. {@code e.getCause()} is the rejection exception, which should be a
1412-
* {@link EsRejectedExecutionException} with {@link EsRejectedExecutionException#isExecutorShutdown()} true.
1410+
* @param e is a {@link NotMasterException} to cause things like {@link TransportMasterNodeAction} to retry after submitting a task
1411+
* to a master which shut down. {@code e.getCause()} is the rejection exception, which should be a
1412+
* {@link EsRejectedExecutionException} with {@link EsRejectedExecutionException#isExecutorShutdown()} true.
14131413
*/
1414+
// Should really be a NodeClosedException instead, but this exception type doesn't trigger retries today.
14141415
void onRejection(NotMasterException e);
14151416

14161417
/**

0 commit comments

Comments
 (0)