propelorm#1086: Code review suggestions applying

tworzenieweb · tworzenieweb · commit 5aa667cafb89 · 2020-06-24T00:01:53.000+02:00
diff --git a/runtime/lib/parser/yaml/sfYamlInline.php b/runtime/lib/parser/yaml/sfYamlInline.php
@@ -122,10 +122,8 @@ protected static function dumpArray($value)
   {
     // array
     $keys = array_keys($value);
-    if (
-      (1 == count($keys) && '0' == $keys[0])
-      ||
-      (count($keys) > 1 && array_reduce($keys, function($v, $w) { return (integer) $v + $w; }, 0) == count($keys) * (count($keys) - 1) / 2))
+    
+    if (count($value) > 0 && array_values($value) === $value)
     {
       $output = array();
       foreach ($value as $val) {

Original file line number	Diff line number	Diff line change
`@@ -122,10 +122,8 @@ protected static function dumpArray($value)`
`122`	`122`	`{`
`123`	`123`	`// array`
`124`	`124`	`$keys = array_keys($value);`
`125`		`- if (`
`126`		`- (1 == count($keys) && '0' == $keys[0])`
`127`		`- \|\|`
`128`		`- (count($keys) > 1 && array_reduce($keys, function($v, $w) { return (integer) $v + $w; }, 0) == count($keys) * (count($keys) - 1) / 2))`
	`125`	`+`
	`126`	`+ if (count($value) > 0 && array_values($value) === $value)`
`129`	`127`	`{`
`130`	`128`	`$output = array();`
`131`	`129`	`foreach ($value as $val) {`