Merge pull request #9 from W0rma/php84-fix-implicitly-nullable-parameters

DavidGoodwin · web-flow · commit 12cdce7c353c · 2025-07-18T10:05:22.000+01:00
PHP 8.4: fix usage of deprecated implicitly nullable parameters
diff --git a/src/Nmap/Service.php b/src/Nmap/Service.php
@@ -19,7 +19,7 @@ class Service
 
     private ?string $version;
 
-    public function __construct(string $name = null, string $product = null, string $version = null)
+    public function __construct(?string $name = null, ?string $product = null, ?string $version = null)
     {
         $this->name = $name;
         $this->product = $product;

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ class Service`
`19`	`19`
`20`	`20`	`private ?string $version;`
`21`	`21`
`22`		`- public function __construct(string $name = null, string $product = null, string $version = null)`
	`22`	`+ public function __construct(?string $name = null, ?string $product = null, ?string $version = null)`
`23`	`23`	`{`
`24`	`24`	`$this->name = $name;`
`25`	`25`	`$this->product = $product;`