improved docs

Author: David Kraushuber

README.md

@@ -19,6 +19,4 @@ provider to build your own SimpleMDM infrastructure.Provider's official document
 
 ## Know issues
 
-- API current doesnt support Create and Delete for Device Groups
-- API currently doesnt support update of "name" attribute for Device Groups 
-- Custom Profiles/Profiles for Assignment group and Devices can no be updated because of API limitation (they are compared only between plan and state from previous plan), aka adding profile via web will not be considered in next apply.
+-app assignemnt is not exactly working as expected because of missing data from API (changes requested already), currently there will be always diff in app assignement.

docs/resources/assignmentgroup.md

@@ -3,12 +3,12 @@
 page_title: "simplemdm_assignmentgroup Resource - simplemdm"
 subcategory: ""
 description: |-
-  Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s), Device Group(s) and set addition details regarding Group.
+  Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s) and set addition details regarding Group. In case you dont want to manage device/app assignments use lifecycle. Currently App assignment will always show diff in configuration as API is not providing all needed data (request for API change was already submitted).
 ---
 
 # simplemdm_assignmentgroup (Resource)
 
-Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s), Device Group(s) and set addition details regarding Group.
+Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s) and set addition details regarding Group. In case you dont want to manage device/app assignments use lifecycle. Currently App assignment will always show diff in configuration as API is not providing all needed data (request for API change was already submitted).
 
 ## Example Usage
 
@@ -19,15 +19,15 @@ resource "simplemdm_assignmentgroup" "myfirstgroup" {
   //auto deploy true or false, default is true
   auto_deploy = true
   //group type "standard" or "munki", defaults to standard. If this parameter is changed it will destroy/create whole group
-  group_type    = "standard"
-  install_type  = "managed"
-  apps          = [123456]
   profiles      = [123456, 987654]
-  groups        = [135431, 654321]
   devices       = [135431, 987654]
   profiles_sync = false
   apps_push     = false
   apps_update   = false
+  attributes = {
+    "testAttribute" = "attributevalue"
+  }
+  apps = [{ app_id = 553192, deployment_type = "munki", install_type = "managed" }]
 }
 ```
 

docs/resources/customdeclaration.md

@@ -43,3 +43,13 @@ resource "simplemdm_customdeclaration" "test" {
 ### Read-Only
 
 - `id` (String) ID of a Custom Declaration in SimpleMDM
+
+## Import
+
+Import is supported using the following syntax:
+
+The [`terraform import` command](https://developer.hashicorp.com/terraform/cli/commands/import) can be used, for example:
+
+```shell
+terraform import simplemdm_customdeclaration.example 12345
+```

docs/resources/scriptjob.md

@@ -16,7 +16,6 @@ Script resource can be used to manage Scripts Jobs.
 resource "simplemdm_scriptjob" "test" {
   script_id              = "35"
   device_ids             = ["1", "2", "3"]
-  group_ids              = ["4", "5"]
   assignment_group_ids   = ["6", "7"]
   custom_attribute       = "greeting_attribute"
   custom_attribute_regex = "\\n"

examples/resources/simplemdm_assignmentgroup/resource.tf

@@ -4,13 +4,13 @@ resource "simplemdm_assignmentgroup" "myfirstgroup" {
   //auto deploy true or false, default is true
   auto_deploy = true
   //group type "standard" or "munki", defaults to standard. If this parameter is changed it will destroy/create whole group
-  group_type    = "standard"
-  install_type  = "managed"
-  apps          = [123456]
   profiles      = [123456, 987654]
-  groups        = [135431, 654321]
   devices       = [135431, 987654]
   profiles_sync = false
   apps_push     = false
   apps_update   = false
+  attributes = {
+    "testAttribute" = "attributevalue"
+  }
+  apps = [{ app_id = 553192, deployment_type = "munki", install_type = "managed" }]
 }

examples/resources/simplemdm_customdeclaration/import.sh

@@ -0,0 +1 @@
+terraform import simplemdm_customdeclaration.example 12345

examples/resources/simplemdm_devicegroup/import.sh

@@ -1,7 +1,6 @@
 resource "simplemdm_scriptjob" "test" {
   script_id              = "35"
   device_ids             = ["1", "2", "3"]
-  group_ids              = ["4", "5"]
   assignment_group_ids   = ["6", "7"]
   custom_attribute       = "greeting_attribute"
   custom_attribute_regex = "\\n"

examples/resources/simplemdm_devicegroup/resource.tf

@@ -75,7 +75,7 @@ func (r *assignment_groupResource) Metadata(_ context.Context, req resource.Meta
 // Schema defines the schema for the resource.
 func (r *assignment_groupResource) Schema(_ context.Context, _ resource.SchemaRequest, resp *resource.SchemaResponse) {
 	resp.Schema = schema.Schema{
-		Description: "Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s), Device Group(s) and set addition details regarding Group.",
+		Description: "Assignment Group resource is used to manage group, you can assign App(s), Profile(s), Custom Profile(s), Custom Declaration(s), Device(s) and set addition details regarding Group. In case you dont want to manage device/app assignments use lifecycle. Currently App assignment will always show diff in configuration as API is not providing all needed data (request for API change was already submitted).",
 		Attributes: map[string]schema.Attribute{
 			"name": schema.StringAttribute{
 				Required:    true,