Make value a property, automatically set parent

Author: DavidMStraub

gedcom7/parser.py

@@ -36,12 +36,7 @@ def loads(string: str) -> list[GedcomStructure]:
         # append structure to output
         if level > 0:
             parent = context[level - 1]
-            structure.parent = parent
-        structure.value = cast.cast_value(
-            text=structure.text, type_id=structure.type_id
-        )
-        if level > 0:
-            parent.children.append(structure)
+            parent.append_child(structure)
         else:
             records.append(structure)
     return records

gedcom7/types.py

@@ -5,7 +5,7 @@
 from dataclasses import dataclass, field
 from typing import Literal, Union
 
-from . import const
+from . import cast, const
 
 
 @dataclass
@@ -18,7 +18,6 @@ class GedcomStructure:
     xref: str
     children: list["GedcomStructure"] = field(default_factory=list)
     parent: "GedcomStructure | None" = None
-    value: "DataType" | None = None
 
     @property
     def type_id(self) -> str:
@@ -33,6 +32,20 @@ def type_id(self) -> str:
             return const.substructures[""][self.tag]
         return const.substructures[self.parent.type_id][self.tag]
 
+    def __post_init__(self):
+        """Post-init steps: set parent on children."""
+        for child in self.children:
+            child.parent = self
+
+    def append_child(self, child: "GedcomStructure") -> None:
+        """Append a child to the structure and set the child's parent to self."""
+        child.parent = self
+        self.children.append(child)
+
+    @property
+    def value(self) -> "DataType | None":
+        return cast.cast_value(text=self.text, type_id=self.type_id)
+
 
 @dataclass
 class PersonalName: