Skip to content

Commit 528fbe2

Browse files
committed
[lldb][test] Enable non-address bit WritePointerToMemory test on Linux
First added in llvm#153585 for Darwin only. All Linux AArch64 systems also have Top Byte Ignore enabled in userspace so the test "just works" there. FreeBSD has very recently gained Top Byte Ignore support: freebsd/freebsd-src@4c6c27d However it's so recent, I don't want to assume it'll be available on any random FreeBSD system out there. There isn't really a good place to put this test, so I put it in the top level of API, next to the other non-address bit test that didn't have a good home either.
1 parent f20640b commit 528fbe2

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed
Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55
from lldbsuite.test.lldbtest import *
66
from lldbsuite.test import lldbutil
77

8-
9-
@skipUnlessDarwin
10-
@skipIf(archs=no_match(["arm64", "arm64e"]))
8+
# On AArch64 systems, unused top bits of pointers can be used for other things.
9+
@skipIf(archs=no_match(["aarch64", "arm64", "arm64e"]))
10+
# Only run this test on systems where Top Byte Ignore is known to be enabled
11+
# and widely available (FreeBSD has support but only since recently).
12+
@skipUnlessPlatform(["linux"] + lldbplatformutil.getDarwinOSTriples())
1113
class TestArmPointerMetadataStripping(TestBase):
1214
# Use extra_symbols.json as a template to add a new symbol whose address
1315
# contains non-zero high order bits set.

0 commit comments

Comments
 (0)