Altered Sample inits to store the text of caught NoValidObservation errors in the failed reason property of the sample

Author: David Turner

xga/samples/base.py

@@ -1,5 +1,5 @@
 #  This code is a part of X-ray: Generate and Analyse (XGA), a module designed for the XMM Cluster Survey (XCS).
-#  Last modified by David J Turner (turne540@msu.edu) 14/07/2025, 08:55. Copyright (c) The Contributors
+#  Last modified by David J Turner (djturner@umbc.edu) 11/12/2025, 17:14. Copyright (c) The Contributors
 
 from typing import Union, List, Dict
 from warnings import warn
@@ -13,7 +13,7 @@
 
 from .. import DEFAULT_COSMO
 from ..exceptions import (NoMatchFoundError, ModelNotAssociatedError, ParameterNotAssociatedError, \
-    NotAssociatedError, TelescopeNotAssociatedError, NoValidObservationsError)
+                          NotAssociatedError, TelescopeNotAssociatedError, NoValidObservationsError)
 from ..sources.base import BaseSource
 from ..sourcetools.misc import coord_to_name
 from ..utils import check_telescope_choices, PRETTY_TELESCOPE_NAMES
@@ -135,7 +135,7 @@ def __init__(self, ra: ndarray, dec: ndarray, redshift: ndarray = None, name: nd
                     self._sources[n] = temp
                     self._names.append(n)
                     self._accepted_inds.append(ind)
-                except (NoMatchFoundError, NoValidObservationsError):
+                except (NoMatchFoundError, NoValidObservationsError) as err:
                     if n is not None:
                         # We don't be liking spaces in source names
                         # n = n.replace(" ", "")
@@ -145,7 +145,7 @@ def __init__(self, ra: ndarray, dec: ndarray, redshift: ndarray = None, name: nd
                         n = coord_to_name(ra_dec)
 
                     # We record that a particular source name was not successfully declared
-                    self._failed_sources[n] = "NoMatch"
+                    self._failed_sources[n] = str(err)
                 dec_base.update(1)
 
         # It is possible (especially if someone is using the Sample classes as a way to check whether things have

xga/samples/general.py

@@ -1,5 +1,5 @@
 #  This code is a part of X-ray: Generate and Analyse (XGA), a module designed for the XMM Cluster Survey (XCS).
-#  Last modified by David J Turner (turne540@msu.edu) 14/07/2025, 08:55. Copyright (c) The Contributors
+#  Last modified by David J Turner (djturner@umbc.edu) 11/12/2025, 17:14. Copyright (c) The Contributors
 
 from typing import Union, List
 from warnings import warn
@@ -184,11 +184,11 @@ def __init__(self, ra: np.ndarray, dec: np.ndarray, redshift: np.ndarray = None,
                                                           load_fits, peak_find_method, True, telescope, search_distance,
                                                           clean_obs, clean_obs_reg, clean_obs_threshold)
                         final_names.append(n)
-                    except NoValidObservationsError:
-                        self._failed_sources[n] = "Failed ObsClean"
+                    except NoValidObservationsError as err:
+                        self._failed_sources[n] = str(err)
 
-                except NoValidObservationsError:
-                    self._failed_sources[n] = "CleanedNoMatch"
+                except NoValidObservationsError as err:
+                    self._failed_sources[n] = str(err)
 
                 dec_lb.update(1)
         self._names = final_names
@@ -423,11 +423,11 @@ def __init__(self, ra: np.ndarray, dec: np.ndarray, redshift: np.ndarray = None,
                                                        search_distance=search_distance,
                                                        clean_obs=clean_obs, clean_obs_threshold=clean_obs_threshold)
                         final_names.append(n)
-                    except NoValidObservationsError:
-                        self._failed_sources[n] = "FailedObsClean"
+                    except NoValidObservationsError as err:
+                        self._failed_sources[n] = str(err)
 
-                except NoValidObservationsError:
-                    self._failed_sources[n] = "CleanedNoMatch"
+                except NoValidObservationsError as err:
+                    self._failed_sources[n] = str(err)
 
                 dec_lb.update(1)
         self._names = final_names

xga/samples/point.py

@@ -1,5 +1,5 @@
 #  This code is a part of X-ray: Generate and Analyse (XGA), a module designed for the XMM Cluster Survey (XCS).
-#  Last modified by David J Turner (turne540@msu.edu) 14/07/2025, 08:55. Copyright (c) The Contributors
+#  Last modified by David J Turner (djturner@umbc.edu) 11/12/2025, 17:14. Copyright (c) The Contributors
 
 from typing import Union, List
 from warnings import warn
@@ -204,8 +204,8 @@ def __init__(self, ra: np.ndarray, dec: np.ndarray, distance: np.ndarray = None,
                     #  been set yet when all radii should be forced to be the same unit
                     self._pr_unit = pr.unit
                     final_names.append(n)
-                except NoValidObservationsError:
-                    self._failed_sources[n] = "CleanedNoMatch"
+                except NoValidObservationsError as err:
+                    self._failed_sources[n] = str(err)
 
                 dec_lb.update(1)
         self._names = final_names